Re: [PATCH v1 9/9] .travis.yml: allow failure for unreliable hosts
On 02/06/2020 17.46, Alex Bennée wrote: > They will still run but they won't get in the way of the result. What does this exactly mean? Will we still get a notification e-mail when something went wrong during the test? Thomas
Re: [PATCH v1 9/9] .travis.yml: allow failure for unreliable hosts
On 6/3/20 10:18 AM, Philippe Mathieu-Daudé wrote:
> On 6/2/20 5:46 PM, Alex Bennée wrote:
>> They will still run but they won't get in the way of the result.
>>
>> Signed-off-by: Alex Bennée
>> ---
>> .travis.yml | 5 +
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index 564be50a3c1..ec6367af1f0 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -429,6 +429,7 @@ jobs:
>>env:
>> - TEST_CMD="make check check-tcg V=1"
>> - CONFIG="--disable-containers
>> --target-list=${MAIN_SOFTMMU_TARGETS}"
>> +- UNRELIABLE=true
>>
>> - name: "[ppc64] GCC check-tcg"
>>arch: ppc64le
>> @@ -493,6 +494,7 @@ jobs:
>>env:
>> - TEST_CMD="make check check-tcg V=1"
>> - CONFIG="--disable-containers
>> --target-list=${MAIN_SOFTMMU_TARGETS},s390x-linux-user"
>> +- UNRELIABLE=true
>>script:
>> - ( cd ${SRC_DIR} ; git submodule update --init roms/SLOF )
>> - BUILD_RC=0 && make -j${JOBS} || BUILD_RC=$?
>> @@ -535,6 +537,7 @@ jobs:
>> - TEST_CMD="make check-unit"
>> - CONFIG="--disable-containers --disable-tcg --enable-kvm
>>--disable-tools --host-cc=clang --cxx=clang++"
>> +- UNRELIABLE=true
>>
>> # Release builds
>> # The make-release script expect a QEMU version, so our tag must start
>> with a 'v'.
>> @@ -556,3 +559,5 @@ jobs:
>> - mkdir -p release-build && cd release-build
>> - ../configure ${BASE_CONFIG} ${CONFIG} || { cat config.log && exit
>> 1; }
>> - make install
>> + allow_failures:
>> +- env: UNRELIABLE=true
>>
>
> It is frustrating when you are expecting Travis to fail to see test this
> patch, but Travis is back working correctly...
>
Reviewed-by: Philippe Mathieu-Daudé
Apparently Travis fixed their problem:
$ df -h
Filesystem
Size Used Avail Use% Mounted on
/var/snap/lxd/common/lxd/storage-pools/instances/containers/travis-job-philmd-qemu-694161395/rootfs
19G 2.8G 16G 15% /
I couldn't test if allow_failures works as expected, anyway:
Tested-by: Philippe Mathieu-Daudé
Re: [PATCH v1 9/9] .travis.yml: allow failure for unreliable hosts
On 6/2/20 5:46 PM, Alex Bennée wrote:
> They will still run but they won't get in the way of the result.
>
> Signed-off-by: Alex Bennée
> ---
> .travis.yml | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index 564be50a3c1..ec6367af1f0 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -429,6 +429,7 @@ jobs:
>env:
> - TEST_CMD="make check check-tcg V=1"
> - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS}"
> +- UNRELIABLE=true
>
> - name: "[ppc64] GCC check-tcg"
>arch: ppc64le
> @@ -493,6 +494,7 @@ jobs:
>env:
> - TEST_CMD="make check check-tcg V=1"
> - CONFIG="--disable-containers
> --target-list=${MAIN_SOFTMMU_TARGETS},s390x-linux-user"
> +- UNRELIABLE=true
>script:
> - ( cd ${SRC_DIR} ; git submodule update --init roms/SLOF )
> - BUILD_RC=0 && make -j${JOBS} || BUILD_RC=$?
> @@ -535,6 +537,7 @@ jobs:
> - TEST_CMD="make check-unit"
> - CONFIG="--disable-containers --disable-tcg --enable-kvm
>--disable-tools --host-cc=clang --cxx=clang++"
> +- UNRELIABLE=true
>
> # Release builds
> # The make-release script expect a QEMU version, so our tag must start
> with a 'v'.
> @@ -556,3 +559,5 @@ jobs:
> - mkdir -p release-build && cd release-build
> - ../configure ${BASE_CONFIG} ${CONFIG} || { cat config.log && exit
> 1; }
> - make install
> + allow_failures:
> +- env: UNRELIABLE=true
>
It is frustrating when you are expecting Travis to fail to see test this
patch, but Travis is back working correctly...
