Re: [PATCH v11 09/14] machine: Use ms instead of global current_machine in sanity-check

[Philippe Mathieu-Daudé]

On 9/28/21 05:57, Yanan Wang wrote:
> In the sanity-check of smp_cpus and max_cpus against mc in function
> machine_set_smp(), we are now using ms->smp.max_cpus for the check
> but using current_machine->smp.max_cpus in the error message.
> Tweak this by uniformly using the local ms.
> 
> Signed-off-by: Yanan Wang 
> Reviewed-by: Andrew Jones 
> Reviewed-by: Pankaj Gupta 
> Reviewed-by: Cornelia Huck 
> ---
>  hw/core/machine.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé 

Re: [PATCH v11 09/14] machine: Use ms instead of global current_machine in sanity-check

[Daniel P . Berrangé]

On Tue, Sep 28, 2021 at 11:57:50AM +0800, Yanan Wang wrote:
> In the sanity-check of smp_cpus and max_cpus against mc in function
> machine_set_smp(), we are now using ms->smp.max_cpus for the check
> but using current_machine->smp.max_cpus in the error message.
> Tweak this by uniformly using the local ms.
> 
> Signed-off-by: Yanan Wang 
> Reviewed-by: Andrew Jones 
> Reviewed-by: Pankaj Gupta 
> Reviewed-by: Cornelia Huck 
> ---
>  hw/core/machine.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé 


Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|