Re: Re: [PATCH v2 0/2] linux-user: two fixes to coredump generation

2024-01-09 Thread Thomas Weißschuh
On 2024-01-10 08:33:11+1100, Richard Henderson wrote:
> On 1/8/24 01:01, Thomas Weißschuh wrote:
> > Signed-off-by: Thomas Weißschuh 
> > ---
> > Changes in v2:
> > - Rebase on 8.2 master
> > - Resend after closed tree and holidays
> > - Link to v1: 
> > https://lore.kernel.org/r/20231115-qemu-user-dumpable-v1-0-edbe7f0fb...@t-8ch.de
> > 
> > ---
> > Thomas Weißschuh (2):
> >linux-user/elfload: test return value of getrlimit
> >linux-user/elfload: check PR_GET_DUMPABLE before creating coredump
> > 
> >   linux-user/elfload.c | 8 ++--
> >   1 file changed, 6 insertions(+), 2 deletions(-)
> > ---
> > base-commit: 0c1eccd368af8805ec0fb11e6cf25d0684d37328
> > change-id: 20231115-qemu-user-dumpable-d499c0396103
> > 
> > Best regards,
> 
> Both patches look good for correctness, but both have style issues: need
> braces on those if statements.
> 
> With that fixed,
> Reviewed-by: Richard Henderson 

Thanks,

I added the braces for the next revision, which I'll send after waiting
some more feedback.



Re: [PATCH v2 0/2] linux-user: two fixes to coredump generation

2024-01-09 Thread Richard Henderson

On 1/8/24 01:01, Thomas Weißschuh wrote:

Signed-off-by: Thomas Weißschuh 
---
Changes in v2:
- Rebase on 8.2 master
- Resend after closed tree and holidays
- Link to v1: 
https://lore.kernel.org/r/20231115-qemu-user-dumpable-v1-0-edbe7f0fb...@t-8ch.de

---
Thomas Weißschuh (2):
   linux-user/elfload: test return value of getrlimit
   linux-user/elfload: check PR_GET_DUMPABLE before creating coredump

  linux-user/elfload.c | 8 ++--
  1 file changed, 6 insertions(+), 2 deletions(-)
---
base-commit: 0c1eccd368af8805ec0fb11e6cf25d0684d37328
change-id: 20231115-qemu-user-dumpable-d499c0396103

Best regards,


Both patches look good for correctness, but both have style issues: need braces on those 
if statements.


With that fixed,
Reviewed-by: Richard Henderson 


r~