Re: [PATCH v2 00/13] ppc/e500: Add support for two types of flash, cleanup
On 10/9/22 00:30, Bin Meng wrote: On Sun, Oct 9, 2022 at 12:11 AM Bernhard Beschow wrote: Am 4. Oktober 2022 12:43:35 UTC schrieb Daniel Henrique Barboza : Hey, On 10/3/22 18:27, Philippe Mathieu-Daudé wrote: Hi Daniel, On 3/10/22 22:31, Bernhard Beschow wrote: Cover letter: ~ This series adds support for -pflash and direct SD card access to the PPC e500 boards. The idea is to increase compatibility with "real" firmware images where only the bare minimum of drivers is compiled in. Bernhard Beschow (13): hw/ppc/meson: Allow e500 boards to be enabled separately hw/gpio/meson: Introduce dedicated config switch for hw/gpio/mpc8xxx docs/system/ppc/ppce500: Add heading for networking chapter hw/ppc/e500: Reduce usage of sysbus API hw/ppc/mpc8544ds: Rename wrongly named method hw/ppc/mpc8544ds: Add platform bus hw/ppc/e500: Remove if statement which is now always true This first part is mostly reviewed and can already go via your ppc-next queue. We're missing an ACK in patch 6/13: hw/ppc/mpc8544ds: Add platform bus Bin: Ping? Sorry for the delay. I have provided the R-b to this patch. Thanks for the review. Patches 1-7 queued in gitlab.com/danielhb/qemu/tree/ppc-next. Daniel Regards, Bin
Re: [PATCH v2 00/13] ppc/e500: Add support for two types of flash, cleanup
On Sun, Oct 9, 2022 at 12:11 AM Bernhard Beschow wrote: > > Am 4. Oktober 2022 12:43:35 UTC schrieb Daniel Henrique Barboza > : > >Hey, > > > >On 10/3/22 18:27, Philippe Mathieu-Daudé wrote: > >> Hi Daniel, > >> > >> On 3/10/22 22:31, Bernhard Beschow wrote: > >>> Cover letter: > >>> ~ > >>> > >>> This series adds support for -pflash and direct SD card access to the > >>> PPC e500 boards. The idea is to increase compatibility with "real" > >>> firmware > >>> images where only the bare minimum of drivers is compiled in. > >> > >>> Bernhard Beschow (13): > >>>hw/ppc/meson: Allow e500 boards to be enabled separately > >>>hw/gpio/meson: Introduce dedicated config switch for hw/gpio/mpc8xxx > >>>docs/system/ppc/ppce500: Add heading for networking chapter > >>>hw/ppc/e500: Reduce usage of sysbus API > >>>hw/ppc/mpc8544ds: Rename wrongly named method > >>>hw/ppc/mpc8544ds: Add platform bus > >>>hw/ppc/e500: Remove if statement which is now always true > >> > >> This first part is mostly reviewed and can already go via your > >> ppc-next queue. > > > >We're missing an ACK in patch 6/13: > > > >hw/ppc/mpc8544ds: Add platform bus > > Bin: Ping? > Sorry for the delay. I have provided the R-b to this patch. Regards, Bin
Re: [PATCH v2 00/13] ppc/e500: Add support for two types of flash, cleanup
Am 4. Oktober 2022 12:43:35 UTC schrieb Daniel Henrique Barboza : >Hey, > >On 10/3/22 18:27, Philippe Mathieu-Daudé wrote: >> Hi Daniel, >> >> On 3/10/22 22:31, Bernhard Beschow wrote: >>> Cover letter: >>> ~ >>> >>> This series adds support for -pflash and direct SD card access to the >>> PPC e500 boards. The idea is to increase compatibility with "real" firmware >>> images where only the bare minimum of drivers is compiled in. >> >>> Bernhard Beschow (13): >>> hw/ppc/meson: Allow e500 boards to be enabled separately >>> hw/gpio/meson: Introduce dedicated config switch for hw/gpio/mpc8xxx >>> docs/system/ppc/ppce500: Add heading for networking chapter >>> hw/ppc/e500: Reduce usage of sysbus API >>> hw/ppc/mpc8544ds: Rename wrongly named method >>> hw/ppc/mpc8544ds: Add platform bus >>> hw/ppc/e500: Remove if statement which is now always true >> >> This first part is mostly reviewed and can already go via your >> ppc-next queue. > >We're missing an ACK in patch 6/13: > >hw/ppc/mpc8544ds: Add platform bus Bin: Ping? Best regards, Bernhard > >I'll need some time to understand what's been doing there to provide my own >R-b. Or you can toss a R-b there :D > > >Thanks, > > >Daniel > > > >> >>> hw/block/pflash_cfi01: Error out if device length isn't a power of two >>> hw/ppc/e500: Implement pflash handling >>> hw/sd/sdhci-internal: Unexport ESDHC defines >>> hw/sd/sdhci: Rename ESDHC_* defines to USDHC_* >>> hw/sd/sdhci: Implement Freescale eSDHC device model >>> hw/ppc/e500: Add Freescale eSDHC to e500 boards >> >> This second part still need work. I can take it via the sdmmc-next >> queue. >> >> Regards, >> >> Phil.
Re: [PATCH v2 00/13] ppc/e500: Add support for two types of flash, cleanup
Hey, On 10/3/22 18:27, Philippe Mathieu-Daudé wrote: Hi Daniel, On 3/10/22 22:31, Bernhard Beschow wrote: Cover letter: ~ This series adds support for -pflash and direct SD card access to the PPC e500 boards. The idea is to increase compatibility with "real" firmware images where only the bare minimum of drivers is compiled in. Bernhard Beschow (13): hw/ppc/meson: Allow e500 boards to be enabled separately hw/gpio/meson: Introduce dedicated config switch for hw/gpio/mpc8xxx docs/system/ppc/ppce500: Add heading for networking chapter hw/ppc/e500: Reduce usage of sysbus API hw/ppc/mpc8544ds: Rename wrongly named method hw/ppc/mpc8544ds: Add platform bus hw/ppc/e500: Remove if statement which is now always true This first part is mostly reviewed and can already go via your ppc-next queue. We're missing an ACK in patch 6/13: hw/ppc/mpc8544ds: Add platform bus I'll need some time to understand what's been doing there to provide my own R-b. Or you can toss a R-b there :D Thanks, Daniel hw/block/pflash_cfi01: Error out if device length isn't a power of two hw/ppc/e500: Implement pflash handling hw/sd/sdhci-internal: Unexport ESDHC defines hw/sd/sdhci: Rename ESDHC_* defines to USDHC_* hw/sd/sdhci: Implement Freescale eSDHC device model hw/ppc/e500: Add Freescale eSDHC to e500 boards This second part still need work. I can take it via the sdmmc-next queue. Regards, Phil.
Re: [PATCH v2 00/13] ppc/e500: Add support for two types of flash, cleanup
Hi Daniel, On 3/10/22 22:31, Bernhard Beschow wrote: Cover letter: ~ This series adds support for -pflash and direct SD card access to the PPC e500 boards. The idea is to increase compatibility with "real" firmware images where only the bare minimum of drivers is compiled in. Bernhard Beschow (13): hw/ppc/meson: Allow e500 boards to be enabled separately hw/gpio/meson: Introduce dedicated config switch for hw/gpio/mpc8xxx docs/system/ppc/ppce500: Add heading for networking chapter hw/ppc/e500: Reduce usage of sysbus API hw/ppc/mpc8544ds: Rename wrongly named method hw/ppc/mpc8544ds: Add platform bus hw/ppc/e500: Remove if statement which is now always true This first part is mostly reviewed and can already go via your ppc-next queue. hw/block/pflash_cfi01: Error out if device length isn't a power of two hw/ppc/e500: Implement pflash handling hw/sd/sdhci-internal: Unexport ESDHC defines hw/sd/sdhci: Rename ESDHC_* defines to USDHC_* hw/sd/sdhci: Implement Freescale eSDHC device model hw/ppc/e500: Add Freescale eSDHC to e500 boards This second part still need work. I can take it via the sdmmc-next queue. Regards, Phil.