Re: [PATCH v2 1/5] hw/arm/aspeed: Remove dead code

2024-01-24 Thread Gavin Shan

On 1/24/24 08:48, Philippe Mathieu-Daudé wrote:

Remove copy/paste typo from commit 6c323aba40 ("hw/arm/aspeed:
Adding new machine Tiogapass in QEMU").

Signed-off-by: Philippe Mathieu-Daudé 
---
  hw/arm/aspeed.c | 1 -
  1 file changed, 1 deletion(-)



Reviewed-by: Gavin Shan 




Re: [PATCH v2 1/5] hw/arm/aspeed: Remove dead code

2024-01-24 Thread Richard Henderson

On 1/24/24 08:48, Philippe Mathieu-Daudé wrote:

Remove copy/paste typo from commit 6c323aba40 ("hw/arm/aspeed:
Adding new machine Tiogapass in QEMU").

Signed-off-by: Philippe Mathieu-Daudé
---
  hw/arm/aspeed.c | 1 -
  1 file changed, 1 deletion(-)


Reviewed-by: Richard Henderson 

r~



Re: [PATCH v2 1/5] hw/arm/aspeed: Remove dead code

2024-01-23 Thread Cédric Le Goater

On 1/23/24 23:48, Philippe Mathieu-Daudé wrote:

Remove copy/paste typo from commit 6c323aba40 ("hw/arm/aspeed:
Adding new machine Tiogapass in QEMU").

Signed-off-by: Philippe Mathieu-Daudé 




Reviewed-by: Cédric Le Goater 

Thanks,

C.



---
  hw/arm/aspeed.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index cc59176563..4bc292ff84 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -1301,7 +1301,6 @@ static void 
aspeed_machine_tiogapass_class_init(ObjectClass *oc, void *data)
  mc->default_ram_size   = 1 * GiB;
  mc->default_cpus = mc->min_cpus = mc->max_cpus =
  aspeed_soc_num_cpus(amc->soc_name);
-aspeed_soc_num_cpus(amc->soc_name);
  };
  
  static void aspeed_machine_sonorapass_class_init(ObjectClass *oc, void *data)