Re: [PATCH v3 000/150] Meson integration for 5.2

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/17/20 4:34 PM, Paolo Bonzini wrote:
> - Simplified/rewrote handling of the modules variable [Howard]
> - Fixed access to gdb-xml files [Howard]
> - Fixed cross-compilation failure due to mingw prefix [Howard]
> - Fixed SDL2 detection on cross compiles [Howard]
> - Fixed sub-makefiles that include config-host.mak
> 
> You can find it at the usual place, https://gitlab.com/bonzini/qemu.git
> branch meson-poc-next.

Also for later, 'make help' doesn't list various targets:

---
 Generic targets:
   all- Build all
   dir/file.o - Build specified target only
   install- Install QEMU
   ctags/TAGS - Generate tags file for editors
   cscope - Generate cscope index
-
-Architecture specific targets:
-  aarch64-softmmu/all- Build for aarch64-softmmu
-  alpha-softmmu/all  - Build for alpha-softmmu
-  arm-softmmu/all- Build for arm-softmmu
-  avr-softmmu/all- Build for avr-softmmu
-  cris-softmmu/all   - Build for cris-softmmu
-  hppa-softmmu/all   - Build for hppa-softmmu
-  i386-softmmu/all   - Build for i386-softmmu
-  lm32-softmmu/all   - Build for lm32-softmmu
-  m68k-softmmu/all   - Build for m68k-softmmu
-  microblazeel-softmmu/all   - Build for microblazeel-softmmu
-  microblaze-softmmu/all - Build for microblaze-softmmu
-  mips64el-softmmu/all   - Build for mips64el-softmmu
-  mips64-softmmu/all - Build for mips64-softmmu
-  mipsel-softmmu/all - Build for mipsel-softmmu
-  mips-softmmu/all   - Build for mips-softmmu
-  moxie-softmmu/all  - Build for moxie-softmmu
-  nios2-softmmu/all  - Build for nios2-softmmu
-  or1k-softmmu/all   - Build for or1k-softmmu
-  ppc64-softmmu/all  - Build for ppc64-softmmu
-  ppc-softmmu/all- Build for ppc-softmmu
-  riscv32-softmmu/all- Build for riscv32-softmmu
-  riscv64-softmmu/all- Build for riscv64-softmmu
-  rx-softmmu/all - Build for rx-softmmu
-  s390x-softmmu/all  - Build for s390x-softmmu
-  sh4eb-softmmu/all  - Build for sh4eb-softmmu
-  sh4-softmmu/all- Build for sh4-softmmu
-  sparc64-softmmu/all- Build for sparc64-softmmu
-  sparc-softmmu/all  - Build for sparc-softmmu
-  tricore-softmmu/all- Build for tricore-softmmu
-  unicore32-softmmu/all  - Build for unicore32-softmmu
-  x86_64-softmmu/all - Build for x86_64-softmmu
-  xtensaeb-softmmu/all   - Build for xtensaeb-softmmu
-  xtensa-softmmu/all - Build for xtensa-softmmu
-  aarch64_be-linux-user/all  - Build for aarch64_be-linux-user
-  aarch64-linux-user/all - Build for aarch64-linux-user
-  alpha-linux-user/all   - Build for alpha-linux-user
-  armeb-linux-user/all   - Build for armeb-linux-user
-  arm-linux-user/all - Build for arm-linux-user
-  cris-linux-user/all- Build for cris-linux-user
-  hppa-linux-user/all- Build for hppa-linux-user
-  i386-linux-user/all- Build for i386-linux-user
-  m68k-linux-user/all- Build for m68k-linux-user
-  microblazeel-linux-user/all- Build for microblazeel-linux-user
-  microblaze-linux-user/all  - Build for microblaze-linux-user
-  mips64el-linux-user/all- Build for mips64el-linux-user
-  mips64-linux-user/all  - Build for mips64-linux-user
-  mipsel-linux-user/all  - Build for mipsel-linux-user
-  mips-linux-user/all- Build for mips-linux-user
-  mipsn32el-linux-user/all   - Build for mipsn32el-linux-user
-  mipsn32-linux-user/all - Build for mipsn32-linux-user
-  nios2-linux-user/all   - Build for nios2-linux-user
-  or1k-linux-user/all- Build for or1k-linux-user
-  ppc64abi32-linux-user/all  - Build for ppc64abi32-linux-user
-  ppc64le-linux-user/all - Build for ppc64le-linux-user
-  ppc64-linux-user/all   - Build for ppc64-linux-user
-  ppc-linux-user/all - Build for ppc-linux-user
-  riscv32-linux-user/all - Build for riscv32-linux-user
-  riscv64-linux-user/all - Build for riscv64-linux-user
-  s390x-linux-user/all   - Build for s390x-linux-user
-  sh4eb-linux-user/all   - Build for sh4eb-linux-user
-  sh4-linux-user/all - Build for sh4-linux-user
-  sparc32plus-linux-user/all - Build for sparc32plus-linux-user
-  sparc64-linux-user/all - Build for sparc64-linux-user
-  sparc-linux-user/all   - Build for sparc-linux-user
-  tilegx-linux-user/all  - Build for tilegx-linux-user
-  x86_64-linux-user/all  - Build for x86_64-linux-user
-  xtensaeb-linux-user/all- Build for 

Re: [PATCH v3 000/150] Meson integration for 5.2

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/17/20 4:34 PM, Paolo Bonzini wrote:
> - Simplified/rewrote handling of the modules variable [Howard]
> - Fixed access to gdb-xml files [Howard]
> - Fixed cross-compilation failure due to mingw prefix [Howard]
> - Fixed SDL2 detection on cross compiles [Howard]
> - Fixed sub-makefiles that include config-host.mak
> 
> You can find it at the usual place, https://gitlab.com/bonzini/qemu.git
> branch meson-poc-next.

I'm getting this warning (nothing critical, so can be fix later):

../configure: line 183: shift: shift count out of range

which is in version_ge().

I used:

../configure \
  --enable-trace-backends=log \
  --disable-docs \
  --enable-debug \
  --extra-cflags=-ggdb \
  --audio-drv-list=oss alsa sdl pa'

Thanks,

Phil.




Re: [PATCH v3 000/150] Meson integration for 5.2

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 12:25 PM, Paolo Bonzini wrote:
> On 18/08/20 11:59, Cornelia Huck wrote:
>> On Mon, 17 Aug 2020 16:34:53 +0200
>> Paolo Bonzini  wrote:
>>
>>> - Simplified/rewrote handling of the modules variable [Howard]
>>> - Fixed access to gdb-xml files [Howard]
>>> - Fixed cross-compilation failure due to mingw prefix [Howard]
>>> - Fixed SDL2 detection on cross compiles [Howard]
>>> - Fixed sub-makefiles that include config-host.mak
>>>
>>> You can find it at the usual place, https://gitlab.com/bonzini/qemu.git
>>> branch meson-poc-next.
>>
>> Builds (on x86 & s390x), runs (this time with the right binary ;), and
>> passes make check, make check-tcg, and kvm unit tests (s390x) for me.
>>
> 
> Great, I'll do the last tests here and send a pull request.

What about the 2 patchew errors?

../src/meson.build:227:2: ERROR: 'sdl2' is not a config-tool dependency

ERROR: meson setup failed



../src/meson.build:547:0: ERROR: Program 'scripts/tracetool.py' not found

ERROR: meson setup failed




Re: [PATCH v3 000/150] Meson integration for 5.2

2020-08-18 Thread Paolo Bonzini
On 18/08/20 11:59, Cornelia Huck wrote:
> On Mon, 17 Aug 2020 16:34:53 +0200
> Paolo Bonzini  wrote:
> 
>> - Simplified/rewrote handling of the modules variable [Howard]
>> - Fixed access to gdb-xml files [Howard]
>> - Fixed cross-compilation failure due to mingw prefix [Howard]
>> - Fixed SDL2 detection on cross compiles [Howard]
>> - Fixed sub-makefiles that include config-host.mak
>>
>> You can find it at the usual place, https://gitlab.com/bonzini/qemu.git
>> branch meson-poc-next.
> 
> Builds (on x86 & s390x), runs (this time with the right binary ;), and
> passes make check, make check-tcg, and kvm unit tests (s390x) for me.
> 

Great, I'll do the last tests here and send a pull request.

Paolo




Re: [PATCH v3 000/150] Meson integration for 5.2

2020-08-18 Thread Cornelia Huck
On Mon, 17 Aug 2020 16:34:53 +0200
Paolo Bonzini  wrote:

> - Simplified/rewrote handling of the modules variable [Howard]
> - Fixed access to gdb-xml files [Howard]
> - Fixed cross-compilation failure due to mingw prefix [Howard]
> - Fixed SDL2 detection on cross compiles [Howard]
> - Fixed sub-makefiles that include config-host.mak
> 
> You can find it at the usual place, https://gitlab.com/bonzini/qemu.git
> branch meson-poc-next.

Builds (on x86 & s390x), runs (this time with the right binary ;), and
passes make check, make check-tcg, and kvm unit tests (s390x) for me.




Re: [PATCH v3 000/150] Meson integration for 5.2

2020-08-17 Thread no-reply
Patchew URL: 
https://patchew.org/QEMU/20200817143723.343284-1-pbonz...@redhat.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

C++ linker for the host machine: c++ ld.bfd 2.27-43
Host machine cpu family: x86_64
Host machine cpu: x86_64
../src/meson.build:9: WARNING: Module unstable-keyval has no backwards or 
forwards compatibility and might not exist in future releases.
Program sh found: YES
Program python3 found: YES (/usr/bin/python3)
Configuring ninjatool using configuration
---
Program scripts/qapi-gen.py found: YES
Program scripts/tracetool.py found: NO

../src/meson.build:547:0: ERROR: Program 'scripts/tracetool.py' not found

A full log can be found at /tmp/qemu-test/build/meson-logs/meson-log.txt

ERROR: meson setup failed

# QEMU configure log Mon Aug 17 19:48:17 UTC 2020
# Configured with: '/tmp/qemu-test/src/configure' '--enable-werror' 
'--target-list=x86_64-softmmu,aarch64-softmmu' '--prefix=/tmp/qemu-test/install'
---
funcs: do_compiler do_cc compile_object check_define main
lines: 92 124 636 714 0
cc -std=gnu99 -Wall -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
-Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings 
-Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -c -o 
config-temp/qemu-conf.o config-temp/qemu-conf.c
config-temp/qemu-conf.c:2:2: error: #error __i386__ not defined
 #error __i386__ not defined
  ^

---
funcs: do_compiler do_cc compile_object check_define main
lines: 92 124 636 717 0
cc -std=gnu99 -Wall -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
-Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings 
-Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -c -o 
config-temp/qemu-conf.o config-temp/qemu-conf.c
config-temp/qemu-conf.c:2:2: error: #error __ILP32__ not defined
 #error __ILP32__ not defined
  ^

---
funcs: do_compiler do_cc compile_prog cc_has_warning_flag main
lines: 92 130 2117 2121 0
cc -std=gnu99 -Wall -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 
-D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef 
-Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv 
-Wold-style-declaration -Wold-style-definition -Wtype-limits -Wformat-security 
-Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs 
-Wendif-labels -Werror -Wexpansion-to-defined -o config-temp/qemu-conf.exe 
config-temp/qemu-conf.c -m64
cc: error: unrecognized command line option '-Wexpansion-to-defined'

funcs: do_compiler do_cc compile_prog cc_has_warning_flag main
lines: 92 130 2117 2121 0
cc -std=gnu99 -Wall -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 
-D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef 
-Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv 
-Wold-style-declaration -Wold-style-definition -Wtype-limits -Wformat-security 
-Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs 
-Wendif-labels -Werror -Winitializer-overrides -o config-temp/qemu-conf.exe 
config-temp/qemu-conf.c -m64
cc: error: unrecognized command line option '-Winitializer-overrides'

funcs: do_compiler do_cc compile_prog cc_has_warning_flag main
lines: 92 130 2117 2121 0
---
funcs: do_compiler do_cc compile_prog cc_has_warning_flag main
lines: 92 130 2117 2121 0
cc -std=gnu99 -Wall -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 
-D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef 
-Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv 
-Wold-style-declaration -Wold-style-definition -Wtype-limits -Wformat-security 
-Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs 
-Wendif-labels -Wno-missing-include-dirs -Werror -Wshift-negative-value -o 
config-temp/qemu-conf.exe config-temp/qemu-conf.c -m64
cc: error: unrecognized command line option '-Wshift-negative-value'

funcs: do_compiler do_cc compile_prog cc_has_warning_flag main
lines: 92 130 2117 2121 0
cc -std=gnu99 -Wall -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 
-D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef 
-Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv 
-Wold-style-declaration -Wold-style-definition -Wtype-limits -Wformat-security 
-Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs 
-Wendif-labels -Wno-missing-include-dirs -Werror -Wstring-plus-int -o 
config-temp/qemu-conf.exe config-temp/qemu-conf.c -m64
cc: error: unrecognized command line option '-Wstring-plus-int'

funcs: do_compiler do_cc compile_prog cc_has_warning_flag main
lines: 92 130 2117 2121 0
cc -std=gnu99 -Wall -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 

Re: [PATCH v3 000/150] Meson integration for 5.2

2020-08-17 Thread no-reply
Patchew URL: 
https://patchew.org/QEMU/20200817143723.343284-1-pbonz...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200817143723.343284-1-pbonz...@redhat.com
Subject: [PATCH v3 000/150] Meson integration for 5.2

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
cfca5eb docs: convert build system documentation to rST
47d3f16 meson: update build-system documentation
ee3e8f0 acceptance: use stable URLs for the Debian and Ubuntu installer
d32e034 meson: avoid unstable module warning with Meson 0.56.0 or newer
5048084 meson: convert po/
d471bf5 meson: convert VNC and dependent libraries to meson
52b85c3 meson: move SDL and SDL-image detection to meson
314d3de meson: convert sample plugins
7bc2848 meson: replace create-config with meson configure_file
1d00ab4 rules.mak: drop unneeded macros
3a8302e meson: convert check-block
550f14b meson: build texi doc
99630ce docs: automatically track manual dependencies
e752a31 meson: sphinx-build
db069e0 remove Makefile.target
c056fb8 rules.mak: remove version.o
fd39f41 meson: convert systemtap files
d757edb meson: link emulators without Makefile.target
ccfd28e meson: plugins
3d70591 meson: cpu-emu
e3c22a1 meson: bsd-user
8138ec6 meson: linux-user
ff68217 meson: accel
9af7358 meson: target
938092f meson: convert hw/arch*
0265714 meson: convert hw/9pfs, cleanup
85f768e meson: convert hw/acpi
a9cda42 meson: convert hw/adc
1299919 meson: convert hw/audio
e8d8db3 meson: convert hw/block
72d098f meson: convert hw/char
136ccee meson: convert hw/cpu
1201a53 meson: convert hw/display
d45ffa0 meson: convert hw/dma
4fc9dbc meson: convert hw/gpio
f3bcbfb meson: convert hw/hyperv
393c21d meson: convert hw/i2c
4901095 meson: convert hw/ide
b1eed4a meson: convert hw/input
c0e344e meson: convert hw/intc
4835f22 meson: convert hw/ipack
52cea55 meson: convert hw/ipmi
b1a7693 meson: convert hw/isa
ee07ff7 meson: convert hw/misc
4555db2 meson: convert hw/net
e98223d meson: convert hw/rdma
4431543 meson: convert hw/nvram
f45e13a meson: convert hw/pci
61d58b0 meson: convert hw/pci-bridge
c81a602 meson: convert hw/pci-host
5458565 meson: convert hw/pcmcia
a1f7421 meson: convert hw/scsi
9f5233f meson: convert hw/sd
127cc92 meson: convert hw/ssi
e266fdb meson: convert hw/rtc
39647a1 meson: convert hw/timer
5b5b609 meson: convert hw/tpm
d871fad meson: convert hw/usb
2bf1097 meson: convert hw/vfio
5956770 meson: convert hw/virtio
a99fcbc meson: convert hw/watchdog
08ce721 meson: convert hw/mem
8f017d4 meson: convert hw/smbios
e427db3 meson: convert hw/nubus
335ec79 meson: convert hw/semihosting
200f04c meson: convert hw/core
ecc58d9 meson: convert hw/xen
9dc32dc meson: convert qapi-specific to meson
90f375d meson: convert disas directory to Meson
9993d1a meson: convert fsdev/
29af682 meson: convert backends directory to Meson
9aa2891 meson: convert net directory to Meson
d7499ba meson: convert migration directory to Meson
a2b72ae meson: convert replay directory to Meson
32dc620 meson: convert qemu-storage-daemon
b122501 meson: convert common QMP bits for qemu and qemu-storage-daemon
334dfac meson: convert dump/
9bff987 meson: convert trace/
e94493b meson: convert most of softmmu/
3f4a282 meson: convert root directory to Meson
b3111a7 meson: convert ui directory to Meson
d2f3a8a meson: convert audio directory to Meson
df6b371 meson: convert tests/qtest to meson
d0e44f4 meson: convert chardev directory to Meson (emulator part)
8fc3428 configure, Makefile; remove TOOLS and HELPERS-y variable
455e48c meson: qemu-pr-helper
adfbff1 meson: qemu-{img,io,nbd}
bc5b34a meson: convert block
3de75cb meson: convert chardev directory to Meson (tools part)
4450835 meson: add modules infrastructure
2429b50 meson: infrastructure for building emulators
3e60ebf meson: convert target/s390x/gen-features.h
dd78445 meson: convert io directory to Meson
c72c20a meson: convert crypto directory to Meson
f468902 meson: convert authz directory to Meson
818776c meson: convert qom directory to Meson (tools part)
f1c2943 meson: convert check-qapi-schema
eb95467 meson: convert tests/fp and check-softfloat
cfc6a94 meson: convert check-decodetree
aba4407 meson: handle edk2 bios and descriptors
a2ac4c4 meson: generate hxtool files
1c4f69c meson: generate shader headers
14f240b meson: generate qemu-version.h
9be648a meson: keymap-gen
5e33b13 meson: add virtfs-proxy-helper
bc1ebb8 meson: add qemu-edid
d1c6c06 meson: add qemu-keymap
3b98d9d meson: add qemu-bridge-helper
134df55 meson: convert dummy Windows qga/qemu-ga target
6f816ba meson: add msi generation
fc7cfad meson: convert vss-win32
fbd085a meson: convert qemu-ga
29b968b meson: add solaris