On 12/19/22 07:49, Alex Bennée wrote:
Richard Henderson writes:
The assignment to mem_coherent should be done with any
modification, not simply with a newly allocated register.
What exactly does mem_coherent mean in this case? Is it that our
register store is potentially out of sync with live values in temp regs
or that we have memory loads and stores in flight?
I think it would be useful to add a doc patch for TCGTemp do specify
what the various fields mean. It would certainly help reviewers that
don't have it committed to memory ;-)
mem_coherent means that the register value and the memory value are the same, so that if
we must release the register we do not need to save the value back to memory.
r~
