Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too

[Cornelia Huck]

On Thu, 14 Sep 2017 12:36:03 +0200
Thomas Huth  wrote:

> libseccomp supports s390x since version 2.3.0, and I was able to start
> a VM with "-sandbox on" without any obvious problems by using this patch,
> so it should be safe to allow --enable-seccomp on s390x nowadays, too.
> 
> Signed-off-by: Thomas Huth 
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index fd7e3a5..83ba64e 100755
> --- a/configure
> +++ b/configure
> @@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
>  arm|aarch64)
>  libseccomp_minver="2.2.3"
>  ;;
> -ppc|ppc64)
> +ppc|ppc64|s390x)
>  libseccomp_minver="2.3.0"
>  ;;
>  *)

Thanks, applied.

Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too

[Halil Pasic]

On 09/14/2017 12:36 PM, Thomas Huth wrote:
> libseccomp supports s390x since version 2.3.0, and I was able to start
> a VM with "-sandbox on" without any obvious problems by using this patch,
> so it should be safe to allow --enable-seccomp on s390x nowadays, too.
> 
> Signed-off-by: Thomas Huth 

ack

Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too

[Eduardo Otubo]

On Thu, Sep 14, 2017 at 01:55:46PM +0200, Christian Borntraeger wrote:
> On 09/14/2017 12:36 PM, Thomas Huth wrote:
> > libseccomp supports s390x since version 2.3.0, and I was able to start
> > a VM with "-sandbox on" without any obvious problems by using this patch,
> > so it should be safe to allow --enable-seccomp on s390x nowadays, too.
> 
> Seems to work fine on s390x.
> Acked-by: Christian Borntraeger 

Cool, thanks :-)

Acked-by: Eduardo Otubo 

> 
> > 
> > Signed-off-by: Thomas Huth 
> > ---
> >  configure | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configure b/configure
> > index fd7e3a5..83ba64e 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
> >  arm|aarch64)
> >  libseccomp_minver="2.2.3"
> >  ;;
> > -ppc|ppc64)
> > +ppc|ppc64|s390x)
> >  libseccomp_minver="2.3.0"
> >  ;;
> >  *)
> > 
> 

-- 
Eduardo Otubo
Senior Software Engineer @ RedHat

Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too

[Christian Borntraeger]

On 09/14/2017 12:36 PM, Thomas Huth wrote:
> libseccomp supports s390x since version 2.3.0, and I was able to start
> a VM with "-sandbox on" without any obvious problems by using this patch,
> so it should be safe to allow --enable-seccomp on s390x nowadays, too.

Seems to work fine on s390x.
Acked-by: Christian Borntraeger 

> 
> Signed-off-by: Thomas Huth 
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index fd7e3a5..83ba64e 100755
> --- a/configure
> +++ b/configure
> @@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
>  arm|aarch64)
>  libseccomp_minver="2.2.3"
>  ;;
> -ppc|ppc64)
> +ppc|ppc64|s390x)
>  libseccomp_minver="2.3.0"
>  ;;
>  *)
> 

Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too

[Eduardo Otubo]

On Thu, Sep 14, 2017 at 12:36:03PM +0200, Thomas Huth wrote:
> libseccomp supports s390x since version 2.3.0, and I was able to start
> a VM with "-sandbox on" without any obvious problems by using this patch,
> so it should be safe to allow --enable-seccomp on s390x nowadays, too.
> 

I don't have a s390x hardware to test so I'll have to trust you.
Anyone from IBM interested in testing this patch as well?

> Signed-off-by: Thomas Huth 
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index fd7e3a5..83ba64e 100755
> --- a/configure
> +++ b/configure
> @@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
>  arm|aarch64)
>  libseccomp_minver="2.2.3"
>  ;;
> -ppc|ppc64)
> +ppc|ppc64|s390x)
>  libseccomp_minver="2.3.0"
>  ;;
>  *)
> -- 
> 1.8.3.1
> 

-- 
Eduardo Otubo
Senior Software Engineer @ RedHat