Re: [Qemu-devel] [PATCH] iotests: Unify cache mode quoting

2019-08-27 Thread no-reply 
Patchew URL: https://patchew.org/QEMU/20190827173432.7656-1-nsof...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190827173432.7656-1-nsof...@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH] iotests: Unify cache mode quoting

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f682fe9 iotests: Unify cache mode quoting

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 38 lines checked

Commit f682fe9cf33c (iotests: Unify cache mode quoting) has style problems, 
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190827173432.7656-1-nsof...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [Qemu-devel] [PATCH] iotests: Unify cache mode quoting

2019-08-27 Thread Nir Soffer 
On Tue, Aug 27, 2019 at 8:43 PM Max Reitz  wrote:
>
> On 27.08.19 19:38, Nir Soffer wrote:
> > On Tue, Aug 27, 2019 at 8:36 PM Max Reitz  > > wrote:
> >
> > On 27.08.19 19:34, Nir Soffer wrote:
> > > Quoting cache mode is not needed, and most tests use unquoted values.
> > > Unify all test to use the same style.
> >
> > S-o-b is missing, shall I add it?
> >
> >
> > Thanks!
> >
> > Signed-off-by: Nir Soffer 
>
> Thanks, applied to my block branch:
>
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
>
> (By the way, did you set your author email address to an @gmail address
> on purpose?)

I configured my gmail address nowhere, I think this is a side affect of using
gmail to send the patches.

>
> Max
>

Re: [Qemu-devel] [PATCH] iotests: Unify cache mode quoting

2019-08-27 Thread Max Reitz 
On 27.08.19 19:38, Nir Soffer wrote:
> On Tue, Aug 27, 2019 at 8:36 PM Max Reitz  > wrote:
> 
> On 27.08.19 19:34, Nir Soffer wrote:
> > Quoting cache mode is not needed, and most tests use unquoted values.
> > Unify all test to use the same style.
> 
> S-o-b is missing, shall I add it?
> 
> 
> Thanks!
> 
> Signed-off-by: Nir Soffer 

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

(By the way, did you set your author email address to an @gmail address
on purpose?)

Max



signature.asc
Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH] iotests: Unify cache mode quoting

2019-08-27 Thread Nir Soffer 
On Tue, Aug 27, 2019 at 8:36 PM Max Reitz  wrote:

> On 27.08.19 19:34, Nir Soffer wrote:
> > Quoting cache mode is not needed, and most tests use unquoted values.
> > Unify all test to use the same style.
>
> S-o-b is missing, shall I add it?
>

Thanks!

Signed-off-by: Nir Soffer 


>
> Max
>
> > ---
> >  tests/qemu-iotests/026 | 4 ++--
> >  tests/qemu-iotests/039 | 4 ++--
> >  tests/qemu-iotests/052 | 2 +-
> >  tests/qemu-iotests/091 | 4 ++--
> >  4 files changed, 7 insertions(+), 7 deletions(-)
>
>

Re: [Qemu-devel] [PATCH] iotests: Unify cache mode quoting

2019-08-27 Thread Max Reitz 
On 27.08.19 19:34, Nir Soffer wrote:
> Quoting cache mode is not needed, and most tests use unquoted values.
> Unify all test to use the same style.

S-o-b is missing, shall I add it?

Max

> ---
>  tests/qemu-iotests/026 | 4 ++--
>  tests/qemu-iotests/039 | 4 ++--
>  tests/qemu-iotests/052 | 2 +-
>  tests/qemu-iotests/091 | 4 ++--
>  4 files changed, 7 insertions(+), 7 deletions(-)



signature.asc
Description: OpenPGP digital signature