Re: [Qemu-devel] [PATCH] qemu: Broken -smb with latest SAMBA package. (Unsupported security=share option)
On Sun, 03 Nov 2013 21:06:22 +0100, Jan Kiszka wrote: On 2013-11-01 11:10, Michael Tokarev wrote: 01.11.2013 13:54, Michael Büsch wrote: On Fri, 01 Nov 2013 13:32:49 +0400 Michael Tokarev m...@tls.msk.ru wrote: That looks right. Are you okay adding your Signed-off-by to the patch you initially submitted? If yes, I'll make a formal patch submission upstream. Here you go. Thank you! Adding Jan as slirp maintainer, and my Reviewed-by: Michael Tokarev m...@tls.msk.ru If Jan picks it up, that's fine. If not, I think it can go to the trivial patches queue. Works fine, applied to queues/slirp. But this is not a trivial patch as the fix is not obvious for a reader (unless you know smb.conf semantics by heart). Jan, did you forget to push the queue? Its been more than 2 months ago, and qemu git is still not fixed? Thanks, /mjt
Re: [Qemu-devel] [PATCH] qemu: Broken -smb with latest SAMBA package. (Unsupported security=share option)
04.11.2013 00:06, Jan Kiszka wrote: On 2013-11-01 11:10, Michael Tokarev wrote: [] If Jan picks it up, that's fine. If not, I think it can go to the trivial patches queue. Works fine, applied to queues/slirp. Okay, thank you Jan. But this is not a trivial patch as the fix is not obvious for a reader (unless you know smb.conf semantics by heart). It's trivial for my understanding. If we require that every change going to -trivial should be obvious to everyone, we should just close it right away. And this area does not have an active maintainer anyway, at least according to MAINTAINERS and ./scripts/get_maintainer.pl. Thanks, /mjt
Re: [Qemu-devel] [PATCH] qemu: Broken -smb with latest SAMBA package. (Unsupported security=share option)
On 2013-11-04 14:55, Michael Tokarev wrote: 04.11.2013 00:06, Jan Kiszka wrote: On 2013-11-01 11:10, Michael Tokarev wrote: [] If Jan picks it up, that's fine. If not, I think it can go to the trivial patches queue. Works fine, applied to queues/slirp. Okay, thank you Jan. But this is not a trivial patch as the fix is not obvious for a reader (unless you know smb.conf semantics by heart). It's trivial for my understanding. If we require that every change going to -trivial should be obvious to everyone, we should just close it right away. Then we may need -less-trivial, because - to my understanding - -trivial was once set up according to the rule that (most) QEMU hackers should be able to understand that a trivial change is at least mostly harmless. And this area does not have an active maintainer anyway, at least according to MAINTAINERS and ./scripts/get_maintainer.pl. Yeah, I think we have some holes there. That smb configuration conceptually belongs to slirp is right, just not clear documented in our script. Jan signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH] qemu: Broken -smb with latest SAMBA package. (Unsupported security=share option)
On 2013-11-01 11:10, Michael Tokarev wrote: 01.11.2013 13:54, Michael Büsch wrote: On Fri, 01 Nov 2013 13:32:49 +0400 Michael Tokarev m...@tls.msk.ru wrote: That looks right. Are you okay adding your Signed-off-by to the patch you initially submitted? If yes, I'll make a formal patch submission upstream. Here you go. Thank you! Adding Jan as slirp maintainer, and my Reviewed-by: Michael Tokarev m...@tls.msk.ru If Jan picks it up, that's fine. If not, I think it can go to the trivial patches queue. Works fine, applied to queues/slirp. But this is not a trivial patch as the fix is not obvious for a reader (unless you know smb.conf semantics by heart). Jan signature.asc Description: OpenPGP digital signature
