Re: [Qemu-devel] [PATCH] win32: fix README file in NSIS installer

2019-09-09 Thread Daniel P . Berrangé
On Mon, Sep 09, 2019 at 03:17:00PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/9/19 3:08 PM, Paolo Bonzini wrote:
> > Adjust after the rST conversion and consequent renaming.
> > 
> > Fixes: 336a7451e8803c21a2da6e7d1eca8cfb8e8b219a
> > Signed-off-by: Paolo Bonzini 
> > ---
> >  qemu.nsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/qemu.nsi b/qemu.nsi
> > index d0df0f4e3a..da18438071 100644
> > --- a/qemu.nsi
> > +++ b/qemu.nsi
> > @@ -119,7 +119,7 @@ Section "${PRODUCT} (required)"
> >  File "${SRCDIR}\Changelog"
> >  File "${SRCDIR}\COPYING"
> >  File "${SRCDIR}\COPYING.LIB"
> > -File "${SRCDIR}\README"
> > +File "${SRCDIR}\README.rst"
> >  File "${SRCDIR}\VERSION"
> >  
> >  File "${BINDIR}\*.bmp"
> > 
> 
> Also:
> 
> -- >8 --
> @@ -211,7 +211,7 @@ Section "Uninstall"
>  Delete "$INSTDIR\Changelog"
>  Delete "$INSTDIR\COPYING"
>  Delete "$INSTDIR\COPYING.LIB"
> -Delete "$INSTDIR\README"
> +Delete "$INSTDIR\README.rst"
>  Delete "$INSTDIR\VERSION"
>  Delete "$INSTDIR\*.bmp"
>  Delete "$INSTDIR\*.bin"
> ---
> 
> With the snippet amended:
> Reviewed-by: Philippe Mathieu-Daudé 
> Tested-by: Philippe Mathieu-Daudé 

Reviewed-by: Daniel P. Berrangé 

Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|



Re: [Qemu-devel] [PATCH] win32: fix README file in NSIS installer

2019-09-09 Thread Philippe Mathieu-Daudé
On 9/9/19 3:08 PM, Paolo Bonzini wrote:
> Adjust after the rST conversion and consequent renaming.
> 
> Fixes: 336a7451e8803c21a2da6e7d1eca8cfb8e8b219a
> Signed-off-by: Paolo Bonzini 
> ---
>  qemu.nsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu.nsi b/qemu.nsi
> index d0df0f4e3a..da18438071 100644
> --- a/qemu.nsi
> +++ b/qemu.nsi
> @@ -119,7 +119,7 @@ Section "${PRODUCT} (required)"
>  File "${SRCDIR}\Changelog"
>  File "${SRCDIR}\COPYING"
>  File "${SRCDIR}\COPYING.LIB"
> -File "${SRCDIR}\README"
> +File "${SRCDIR}\README.rst"
>  File "${SRCDIR}\VERSION"
>  
>  File "${BINDIR}\*.bmp"
> 

Also:

-- >8 --
@@ -211,7 +211,7 @@ Section "Uninstall"
 Delete "$INSTDIR\Changelog"
 Delete "$INSTDIR\COPYING"
 Delete "$INSTDIR\COPYING.LIB"
-Delete "$INSTDIR\README"
+Delete "$INSTDIR\README.rst"
 Delete "$INSTDIR\VERSION"
 Delete "$INSTDIR\*.bmp"
 Delete "$INSTDIR\*.bin"
---

With the snippet amended:
Reviewed-by: Philippe Mathieu-Daudé 
Tested-by: Philippe Mathieu-Daudé