Re: [Qemu-devel] [PATCH 0/4] scsi fixes
On 07/12/2011 03:37 PM, Kevin Wolf wrote: Am 11.07.2011 15:02, schrieb Hannes Reinecke: Hi all, these are some fixes I found during debugging my megasas HBA emulation. This time I've sent them as a separate patchset for inclusion. All of them have been acked, so please apply. Hannes Reinecke (4): iov: Update parameter usage in iov_(to|from)_buf() scsi: Add 'hba_private' to SCSIRequest scsi-disk: Fixup debugging statement scsi-disk: Mask out serial number EVPD Thanks, applied all to the block branch. Any chance to have them pulled into the main tree? My megasas emulation relies on them, and it feels a bit stupid to send a patch relying on some fixes not in mainline. At the same time it's really stupid to resend the entire patchset again ... Thanks. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
Re: [Qemu-devel] [PATCH 0/4] scsi fixes
Am 19.07.2011 08:31, schrieb Hannes Reinecke: On 07/12/2011 03:37 PM, Kevin Wolf wrote: Am 11.07.2011 15:02, schrieb Hannes Reinecke: Hi all, these are some fixes I found during debugging my megasas HBA emulation. This time I've sent them as a separate patchset for inclusion. All of them have been acked, so please apply. Hannes Reinecke (4): iov: Update parameter usage in iov_(to|from)_buf() scsi: Add 'hba_private' to SCSIRequest scsi-disk: Fixup debugging statement scsi-disk: Mask out serial number EVPD Thanks, applied all to the block branch. Any chance to have them pulled into the main tree? My megasas emulation relies on them, and it feels a bit stupid to send a patch relying on some fixes not in mainline. At the same time it's really stupid to resend the entire patchset again ... I'm hoping to send a pull request today, now that the VMDK patches look good finally. Anyway, I don't think that not having the patches in master yet should stop you from going forward with the next patches. They will go through the block tree anyway, so basing them on that tree is fine (and you wouldn't be the first one to do that). Just state in PATCH 0/n for the reviewers that it depends on the other patches. Kevin
Re: [Qemu-devel] [PATCH 0/4] scsi fixes
On 07/19/2011 09:39 AM, Kevin Wolf wrote: Am 19.07.2011 08:31, schrieb Hannes Reinecke: On 07/12/2011 03:37 PM, Kevin Wolf wrote: Am 11.07.2011 15:02, schrieb Hannes Reinecke: Hi all, these are some fixes I found during debugging my megasas HBA emulation. This time I've sent them as a separate patchset for inclusion. All of them have been acked, so please apply. Hannes Reinecke (4): iov: Update parameter usage in iov_(to|from)_buf() scsi: Add 'hba_private' to SCSIRequest scsi-disk: Fixup debugging statement scsi-disk: Mask out serial number EVPD Thanks, applied all to the block branch. Any chance to have them pulled into the main tree? My megasas emulation relies on them, and it feels a bit stupid to send a patch relying on some fixes not in mainline. At the same time it's really stupid to resend the entire patchset again ... I'm hoping to send a pull request today, now that the VMDK patches look good finally. Anyway, I don't think that not having the patches in master yet should stop you from going forward with the next patches. They will go through the block tree anyway, so basing them on that tree is fine (and you wouldn't be the first one to do that). Just state in PATCH 0/n for the reviewers that it depends on the other patches. Well, the remaining patch is 'just' the megasas emulation itself. And I want to make reviewing that as easy as possible, so that it's not again being held off by complains about missing patches. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
Re: [Qemu-devel] [PATCH 0/4] scsi fixes
On 19.07.2011, at 10:10, Hannes Reinecke wrote: On 07/19/2011 09:39 AM, Kevin Wolf wrote: Am 19.07.2011 08:31, schrieb Hannes Reinecke: On 07/12/2011 03:37 PM, Kevin Wolf wrote: Am 11.07.2011 15:02, schrieb Hannes Reinecke: Hi all, these are some fixes I found during debugging my megasas HBA emulation. This time I've sent them as a separate patchset for inclusion. All of them have been acked, so please apply. Hannes Reinecke (4): iov: Update parameter usage in iov_(to|from)_buf() scsi: Add 'hba_private' to SCSIRequest scsi-disk: Fixup debugging statement scsi-disk: Mask out serial number EVPD Thanks, applied all to the block branch. Any chance to have them pulled into the main tree? My megasas emulation relies on them, and it feels a bit stupid to send a patch relying on some fixes not in mainline. At the same time it's really stupid to resend the entire patchset again ... I'm hoping to send a pull request today, now that the VMDK patches look good finally. Anyway, I don't think that not having the patches in master yet should stop you from going forward with the next patches. They will go through the block tree anyway, so basing them on that tree is fine (and you wouldn't be the first one to do that). Just state in PATCH 0/n for the reviewers that it depends on the other patches. Well, the remaining patch is 'just' the megasas emulation itself. And I want to make reviewing that as easy as possible, so that it's not again being held off by complains about missing patches. Yes, no worries. Just state in the patch description that it's based on the block branch and actually do base it on it - the endianness specific ld./st. patches are upstream, so everything you need should be in that branch. Alex
Re: [Qemu-devel] [PATCH 0/4] scsi fixes
Am 11.07.2011 15:02, schrieb Hannes Reinecke: Hi all, these are some fixes I found during debugging my megasas HBA emulation. This time I've sent them as a separate patchset for inclusion. All of them have been acked, so please apply. Hannes Reinecke (4): iov: Update parameter usage in iov_(to|from)_buf() scsi: Add 'hba_private' to SCSIRequest scsi-disk: Fixup debugging statement scsi-disk: Mask out serial number EVPD Thanks, applied all to the block branch. Kevin
Re: [Qemu-devel] [PATCH 0/4] scsi fixes
On Mon, Jul 11, 2011 at 2:02 PM, Hannes Reinecke h...@suse.de wrote: Hi all, these are some fixes I found during debugging my megasas HBA emulation. This time I've sent them as a separate patchset for inclusion. All of them have been acked, so please apply. Are SCSI patches going through Kevin's tree? If not, perhaps Paolo or I should keep a tree and start doing some sanity testing on the subsystem in the future. Stefan
Re: [Qemu-devel] [PATCH 0/4] scsi fixes
Am 11.07.2011 15:34, schrieb Stefan Hajnoczi: On Mon, Jul 11, 2011 at 2:02 PM, Hannes Reinecke h...@suse.de wrote: Hi all, these are some fixes I found during debugging my megasas HBA emulation. This time I've sent them as a separate patchset for inclusion. All of them have been acked, so please apply. Are SCSI patches going through Kevin's tree? If not, perhaps Paolo or I should keep a tree and start doing some sanity testing on the subsystem in the future. As long as we don't have a SCSI maintainer, I'm going to pick them up for the block tree when they have receive some review. Doesn't mean that nobody should be doing sanity testing, of course. If anyone wants to take care of picking up and reviewing all SCSI patches, I'm also happy to pull from a separate tree. Kevin
Re: [Qemu-devel] [PATCH 0/4] scsi fixes
On 07/11/2011 03:42 PM, Kevin Wolf wrote: Am 11.07.2011 15:34, schrieb Stefan Hajnoczi: On Mon, Jul 11, 2011 at 2:02 PM, Hannes Reineckeh...@suse.de wrote: Hi all, these are some fixes I found during debugging my megasas HBA emulation. This time I've sent them as a separate patchset for inclusion. All of them have been acked, so please apply. Are SCSI patches going through Kevin's tree? If not, perhaps Paolo or I should keep a tree and start doing some sanity testing on the subsystem in the future. As long as we don't have a SCSI maintainer, I'm going to pick them up for the block tree when they have receive some review. Doesn't mean that nobody should be doing sanity testing, of course. If anyone wants to take care of picking up and reviewing all SCSI patches, I'm also happy to pull from a separate tree. Patches have already been reviewed and tested, in conjunction with my megasas HBA emulation patchset. This is just a repost as a separate patchset to get them in. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)