Re: [Qemu-devel] [PATCH RFC 5/5] xen: introduce xenpv-softmmu.mak

2014-01-24 Thread Wei Liu
On Fri, Jan 24, 2014 at 08:38:19AM +0100, Paolo Bonzini wrote:
 Il 23/01/2014 23:16, Wei Liu ha scritto:
 -echo CONFIG_XEN_PCI_PASSTHROUGH=y  $config_target_mak
 +if test $target_name != xenpv; then
 +echo CONFIG_XEN_I386=y  $config_target_mak
 +if test $xen_pci_passthrough = yes; then
 +echo CONFIG_XEN_PCI_PASSTHROUGH=y  $config_target_mak
 +fi
 
 You can add
 
 CONFIG_XEN_PCI_PASSTHROUGH=$(CONFIG_XEN)
 
 to i386-softmmu.mak and x86_64-softmmu.mak, and drop this setting
 from config-target.mak too.
 

I'm afraid not. CONFIG_XEN is prerequiste for CONFIG_XEN_PCI_PASSTHROUGH
but doens't imply the feature is enabled by the user.

Wei.

 Paolo



Re: [Qemu-devel] [PATCH RFC 5/5] xen: introduce xenpv-softmmu.mak

2014-01-23 Thread Paolo Bonzini

Il 23/01/2014 23:16, Wei Liu ha scritto:

-echo CONFIG_XEN_PCI_PASSTHROUGH=y  $config_target_mak
+if test $target_name != xenpv; then
+echo CONFIG_XEN_I386=y  $config_target_mak
+if test $xen_pci_passthrough = yes; then
+echo CONFIG_XEN_PCI_PASSTHROUGH=y  $config_target_mak
+fi


You can add

CONFIG_XEN_PCI_PASSTHROUGH=$(CONFIG_XEN)

to i386-softmmu.mak and x86_64-softmmu.mak, and drop this setting from 
config-target.mak too.


Paolo