Re: [Qemu-devel] [PATCH Risu v2 7/9] Add PPC64 in risu build system

2017-02-21 Thread Peter Maydell
On 21 February 2017 at 02:24,   wrote:
> On Sat, Feb 18, 2017 at 10:41:41PM +, Peter Maydell wrote:
>>
>> Does the BE ppc64 risu build work for you? I tried
>> installing the cross-compiler, but the build fails
>> because there's no risu_ppc64.c. (ppc64le works fine.)
>> If we don't support the big-endian variant yet maybe
>> we should drop it from the configure file.
>
> I want it to work to but I focused the efforts on LE only, never tested
> at all. I have a small patchset to send to you. I'll make an effort to fix BE 
> as well,
> it's worth it.

Up to you -- if you're not using BE yet then we can just as
easily disable it in configure for the moment, until you
have a need to get back to it.

thanks
-- PMM



Re: [Qemu-devel] [PATCH Risu v2 7/9] Add PPC64 in risu build system

2017-02-20 Thread joserz
On Sat, Feb 18, 2017 at 10:41:41PM +, Peter Maydell wrote:
> On 6 November 2016 at 17:15, Jose Ricardo Ziviani
>  wrote:
> > Recognizes PPC64 as a valid architecture and setup the environment
> > variables to compile code for that.
> >
> > Signed-off-by: Jose Ricardo Ziviani 
> > ---
> >  configure | 8 +++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 748b48a..f81bdb5 100755
> > --- a/configure
> > +++ b/configure
> > @@ -22,6 +22,12 @@ guess_arch() {
> >  ARCH="arm"
> >  elif check_define __aarch64__ ; then
> >  ARCH="aarch64"
> > +elif check_define __powerpc64__ ; then
> > +if check_define __BIG_ENDIAN__; then
> > +ARCH="ppc64"
> > +else
> > +ARCH="ppc64le"
> > +fi
> 
> Does the BE ppc64 risu build work for you? I tried
> installing the cross-compiler, but the build fails
> because there's no risu_ppc64.c. (ppc64le works fine.)
> If we don't support the big-endian variant yet maybe
> we should drop it from the configure file.

I want it to work to but I focused the efforts on LE only, never tested
at all. I have a small patchset to send to you. I'll make an effort to fix BE 
as well,
it's worth it.

Thanks Peter!

> 
> thanks
> -- PMM
> 




Re: [Qemu-devel] [PATCH Risu v2 7/9] Add PPC64 in risu build system

2017-02-18 Thread Peter Maydell
On 6 November 2016 at 17:15, Jose Ricardo Ziviani
 wrote:
> Recognizes PPC64 as a valid architecture and setup the environment
> variables to compile code for that.
>
> Signed-off-by: Jose Ricardo Ziviani 
> ---
>  configure | 8 +++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 748b48a..f81bdb5 100755
> --- a/configure
> +++ b/configure
> @@ -22,6 +22,12 @@ guess_arch() {
>  ARCH="arm"
>  elif check_define __aarch64__ ; then
>  ARCH="aarch64"
> +elif check_define __powerpc64__ ; then
> +if check_define __BIG_ENDIAN__; then
> +ARCH="ppc64"
> +else
> +ARCH="ppc64le"
> +fi

Does the BE ppc64 risu build work for you? I tried
installing the cross-compiler, but the build fails
because there's no risu_ppc64.c. (ppc64le works fine.)
If we don't support the big-endian variant yet maybe
we should drop it from the configure file.

thanks
-- PMM