Re: [Qemu-devel] [PATCH V6 6/6] pvpanic : update pvpanic document
> Add mmio support info in docs/specs/pvpanic.txt. >> >> Signed-off-by: Peng Hao >> --- >> docs/specs/pvpanic.txt | 13 - >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt >> index c7bbacc..5d8e9dc 100644 >> --- a/docs/specs/pvpanic.txt >> +++ b/docs/specs/pvpanic.txt >> @@ -1,7 +1,7 @@ >> PVPANIC DEVICE >> == >> >> -pvpanic device is a simulated ISA device, through which a guest panic >> +pvpanic device is a simulated device, through which a guest panic >> event is sent to qemu, and a QMP event is generated. This allows >> management apps (e.g. libvirt) to be notified and respond to the event. >> >> @@ -9,6 +9,10 @@ The management app has the option of waiting for >> GUEST_PANICKED events, >> and/or polling for guest-panicked RunState, to learn when the pvpanic >> device has fired a panic event. >> >> +When pvpanic device is implemented as a ISA device, it supports IOPORT >^the ^an >> +mode. If pvpanic device supports MMIO mode, it will be implemented as > >When the pvpanic device needs to use MMIO mode, ... > I will add "Some architectures do not support ioport, just like arm." >> +a SYSBUS device. >> + >> ISA Interface >> - >> >> @@ -19,6 +23,13 @@ Software should set only bits both itself and the device >> recognize. >> Currently, only bit 0 is recognized, setting it indicates a guest panic >> has happened. >> >> +SYSBUS Interface >> +-- >> + >> +It is basically the same as ISA interface except that it uses MMIO. > >The SYSBUS interface is similar to the ISA interface... > I will change it. >> Pvpanic exposes >> +a address space region 0x0906--0x09060001 in arm virt machine. >> +Currently only the first byte is used. >> + > >I would drop the above lines. They're not correct anyway. The region is >907-9070001 (inclusive). sorry,I wrote a wrong address span. > >> ACPI Interface >> -- >> >> -- >> 1.8.3.1 >> >> > >Thanks, >drew
Re: [Qemu-devel] [PATCH V6 6/6] pvpanic : update pvpanic document
On Mon, Nov 12, 2018 at 07:42:20PM +0800, Peng Hao wrote: > Add mmio support info in docs/specs/pvpanic.txt. > > Signed-off-by: Peng Hao > --- > docs/specs/pvpanic.txt | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt > index c7bbacc..5d8e9dc 100644 > --- a/docs/specs/pvpanic.txt > +++ b/docs/specs/pvpanic.txt > @@ -1,7 +1,7 @@ > PVPANIC DEVICE > == > > -pvpanic device is a simulated ISA device, through which a guest panic > +pvpanic device is a simulated device, through which a guest panic > event is sent to qemu, and a QMP event is generated. This allows > management apps (e.g. libvirt) to be notified and respond to the event. > > @@ -9,6 +9,10 @@ The management app has the option of waiting for > GUEST_PANICKED events, > and/or polling for guest-panicked RunState, to learn when the pvpanic > device has fired a panic event. > > +When pvpanic device is implemented as a ISA device, it supports IOPORT ^the ^an > +mode. If pvpanic device supports MMIO mode, it will be implemented as When the pvpanic device needs to use MMIO mode, ... > +a SYSBUS device. > + > ISA Interface > - > > @@ -19,6 +23,13 @@ Software should set only bits both itself and the device > recognize. > Currently, only bit 0 is recognized, setting it indicates a guest panic > has happened. > > +SYSBUS Interface > +-- > + > +It is basically the same as ISA interface except that it uses MMIO. The SYSBUS interface is similar to the ISA interface... > Pvpanic exposes > +a address space region 0x0906--0x09060001 in arm virt machine. > +Currently only the first byte is used. > + I would drop the above lines. They're not correct anyway. The region is 907-9070001 (inclusive). > ACPI Interface > -- > > -- > 1.8.3.1 > > Thanks, drew