Re: [Qemu-devel] [PATCH v1 0/9] QOM'ify hw/intc files

2016-05-05 Thread xiaoqiang zhao 


> 在 2016年5月5日，18:46，Peter Maydell  写道：
> 
>> On 5 May 2016 at 11:41, 赵小强  wrote:
>> At 2016-05-05 18:39:52, "Peter Maydell"  wrote:
 On 5 May 2016 at 11:28, xiaoqiang zhao  wrote:
 This patch set QOM'ify files under hw/intc directory. See each commit
 message for details.
 
 Changes in v1:
  use error_setg instead of error_report in realize function
>>> 
>>> How can you have changes in a v1? Was this supposed to be v2?
> 
>> Yes, should be v2 here. Sorry ! need a resend ?
> 
> No. Is only the last patch changed from the previous set ?
> 
> thanks
> -- PMM

Yes！

Re: [Qemu-devel] [PATCH v1 0/9] QOM'ify hw/intc files

2016-05-05 Thread Peter Maydell 
On 5 May 2016 at 11:41, 赵小强  wrote:
> At 2016-05-05 18:39:52, "Peter Maydell"  wrote:
>>On 5 May 2016 at 11:28, xiaoqiang zhao  wrote:
>>> This patch set QOM'ify files under hw/intc directory. See each commit
>>> message for details.
>>>
>>> Changes in v1:
>>>   use error_setg instead of error_report in realize function
>>
>>How can you have changes in a v1? Was this supposed to be v2?

> Yes, should be v2 here. Sorry ! need a resend ?

No. Is only the last patch changed from the previous set ?

thanks
-- PMM

Re: [Qemu-devel] [PATCH v1 0/9] QOM'ify hw/intc files

2016-05-05 Thread 赵小强 










At 2016-05-05 18:39:52, "Peter Maydell"  wrote:
>On 5 May 2016 at 11:28, xiaoqiang zhao  wrote:
>> This patch set QOM'ify files under hw/intc directory. See each commit
>> message for details.
>>
>> Changes in v1:
>>   use error_setg instead of error_report in realize function
>
>How can you have changes in a v1? Was this supposed to be v2?
>
>thanks
>-- PMM


Yes, should be v2 here. Sorry ! need a resend ?

Re: [Qemu-devel] [PATCH v1 0/9] QOM'ify hw/intc files

2016-05-05 Thread Peter Maydell 
On 5 May 2016 at 11:28, xiaoqiang zhao  wrote:
> This patch set QOM'ify files under hw/intc directory. See each commit
> message for details.
>
> Changes in v1:
>   use error_setg instead of error_report in realize function

How can you have changes in a v1? Was this supposed to be v2?

thanks
-- PMM