Re: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing
Quoting Thomas Huth (2017-05-23 02:25:30) > On 22.05.2017 17:58, no-re...@patchew.org wrote: > > This series failed automatic build test. Please find the testing commands > > and > > their output below. If you have docker installed, you can probably > > reproduce it > > locally. > [...] > >LEX convert-dtsv0-lexer.lex.c > >DEP /tmp/qemu-test/src/dtc/fdtdump.c > > make[1]: flex: Command not found > >BISON dtc-parser.tab.c > > make[1]: bison: Command not found > >DEP /tmp/qemu-test/src/dtc/srcpos.c > >LEX dtc-lexer.lex.c > > make[1]: flex: Command not found > >DEP /tmp/qemu-test/src/dtc/treesource.c > >DEP /tmp/qemu-test/src/dtc/livetree.c > >DEP /tmp/qemu-test/src/dtc/fstree.c > >DEP /tmp/qemu-test/src/dtc/flattree.c > >DEP /tmp/qemu-test/src/dtc/dtc.c > >DEP /tmp/qemu-test/src/dtc/data.c > >DEP /tmp/qemu-test/src/dtc/checks.c > > CHK version_gen.h > >BISON dtc-parser.tab.c > > make[1]: bison: Command not found > >LEX convert-dtsv0-lexer.lex.c > > UPD version_gen.h > > make[1]: flex: Command not found > >LEX dtc-lexer.lex.c > > make[1]: flex: Command not found > >DEP /tmp/qemu-test/src/dtc/util.c > >LEX convert-dtsv0-lexer.lex.c > >BISON dtc-parser.tab.c > > make[1]: flex: Command not found > > make[1]: bison: Command not found > >LEX dtc-lexer.lex.c > > make[1]: flex: Command not found > > Looks like flex and bison are missing in the docker image? Could someone > please add it? > > [...] > > CC replay/replay-internal.o > > /tmp/qemu-test/src/replay/replay-internal.c: In function ‘replay_put_array’: > > /tmp/qemu-test/src/replay/replay-internal.c:65: warning: ignoring return > > value of ‘fwrite’, declared with attribute warn_unused_result > > I guess that should be fixed? > > [...] > > CC slirp/tcp_input.o > > CC slirp/tcp_output.o > > CC slirp/tcp_subr.o > > CC slirp/tcp_timer.o > > /tmp/qemu-test/src/slirp/tcp_input.c: In function ‘tcp_input’: > > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_p’ may be > > used uninitialized in this function > > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_len’ may be > > used uninitialized in this function > > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_tos’ may be > > used uninitialized in this function > > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_id’ may be > > used uninitialized in this function > > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_off’ may be > > used uninitialized in this function > > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_ttl’ may be > > used uninitialized in this function > > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_sum’ may be > > used uninitialized in this function > > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_src.s_addr’ > > may be used uninitialized in this function > > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_dst.s_addr’ > > may be used uninitialized in this function > > /tmp/qemu-test/src/slirp/tcp_input.c:220: warning: ‘save_ip6.ip_nh’ may be > > used uninitialized in this function > > I've never seen these warnings in tcp_input.c before ... and they also > look like false positives too me ... is that GCC in the docker image too > sensitive? > > [...] > > CC aarch64-softmmu/hw/timer/exynos4210_rtc.o > > /tmp/qemu-test/src/hw/i386/pc_piix.c: In function > > ‘igd_passthrough_isa_bridge_create’: > > /tmp/qemu-test/src/hw/i386/pc_piix.c:1067: warning: ‘pch_rev_id’ may be > > used uninitialized in this function > > dito > > > CC aarch64-softmmu/hw/usb/tusb6010.o > > /tmp/qemu-test/src/hw/i386/acpi-build.c: In function > > ‘build_append_pci_bus_devices’: > > /tmp/qemu-test/src/hw/i386/acpi-build.c:525: warning: ‘notify_method’ may > > be used uninitialized in this function > > dito > > [...] > > /tmp/qemu-test/src/tests/ide-test.c: In function ‘cdrom_pio_impl’: > > /tmp/qemu-test/src/tests/ide-test.c:803: warning: ignoring return value of > > ‘fwrite’, declared with attribute warn_unused_result > > /tmp/qemu-test/src/tests/ide-test.c: In function ‘test_cdrom_dma’: > > /tmp/qemu-test/src/tests/ide-test.c:899: warning: ignoring return value of > > ‘fwrite’, declared with attribute warn_unused_result > > Needs a patch, I guess? > > > GTESTER tests/test-vmstate > > Failed to load simple/primitive:b_1 > > Failed to load simple/primitive:i64_2 > > Failed to load simple/primitive:i32_1 > > Failed to load simple/primitive:i32_1 > > Failed to load test/with_tmp:a > > Failed to load test/tmp_child_parent:f > > Failed to load test/tmp_child:parent > > Failed to load test/with_tmp:tmp > > Failed to load test/tmp_child:diff > > Failed to load test/with_tmp:tmp > > Failed to load test/tmp_child:diff > > Failed to load test/with_tmp:tmp > >
Re: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing
On 05/23/2017 03:25 AM, Thomas Huth wrote: > On 22.05.2017 17:58, no-re...@patchew.org wrote: >> This series failed automatic build test. Please find the testing commands and >> their output below. If you have docker installed, you can probably reproduce >> it >> locally. > [...] >> LEX convert-dtsv0-lexer.lex.c >> DEP /tmp/qemu-test/src/dtc/fdtdump.c >> make[1]: flex: Command not found >> BISON dtc-parser.tab.c >> make[1]: bison: Command not found >> DEP /tmp/qemu-test/src/dtc/srcpos.c >> LEX dtc-lexer.lex.c >> make[1]: flex: Command not found >> DEP /tmp/qemu-test/src/dtc/treesource.c >> DEP /tmp/qemu-test/src/dtc/livetree.c >> DEP /tmp/qemu-test/src/dtc/fstree.c >> DEP /tmp/qemu-test/src/dtc/flattree.c >> DEP /tmp/qemu-test/src/dtc/dtc.c >> DEP /tmp/qemu-test/src/dtc/data.c >> DEP /tmp/qemu-test/src/dtc/checks.c >> CHK version_gen.h >> BISON dtc-parser.tab.c >> make[1]: bison: Command not found >> LEX convert-dtsv0-lexer.lex.c >> UPD version_gen.h >> make[1]: flex: Command not found >> LEX dtc-lexer.lex.c >> make[1]: flex: Command not found >> DEP /tmp/qemu-test/src/dtc/util.c >> LEX convert-dtsv0-lexer.lex.c >> BISON dtc-parser.tab.c >> make[1]: flex: Command not found >> make[1]: bison: Command not found >> LEX dtc-lexer.lex.c >> make[1]: flex: Command not found > > Looks like flex and bison are missing in the docker image? Could someone > please add it? > > [...] >> CC replay/replay-internal.o >> /tmp/qemu-test/src/replay/replay-internal.c: In function ‘replay_put_array’: >> /tmp/qemu-test/src/replay/replay-internal.c:65: warning: ignoring return >> value of ‘fwrite’, declared with attribute warn_unused_result > > I guess that should be fixed? > > [...] >> CC slirp/tcp_input.o >> CC slirp/tcp_output.o >> CC slirp/tcp_subr.o >> CC slirp/tcp_timer.o >> /tmp/qemu-test/src/slirp/tcp_input.c: In function ‘tcp_input’: >> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_p’ may be >> used uninitialized in this function >> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_len’ may be >> used uninitialized in this function >> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_tos’ may be >> used uninitialized in this function >> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_id’ may be >> used uninitialized in this function >> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_off’ may be >> used uninitialized in this function >> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_ttl’ may be >> used uninitialized in this function >> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_sum’ may be >> used uninitialized in this function >> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_src.s_addr’ >> may be used uninitialized in this function >> /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_dst.s_addr’ >> may be used uninitialized in this function >> /tmp/qemu-test/src/slirp/tcp_input.c:220: warning: ‘save_ip6.ip_nh’ may be >> used uninitialized in this function > > I've never seen these warnings in tcp_input.c before ... and they also > look like false positives too me ... is that GCC in the docker image too > sensitive? > > [...] >> CC aarch64-softmmu/hw/timer/exynos4210_rtc.o >> /tmp/qemu-test/src/hw/i386/pc_piix.c: In function >> ‘igd_passthrough_isa_bridge_create’: >> /tmp/qemu-test/src/hw/i386/pc_piix.c:1067: warning: ‘pch_rev_id’ may be used >> uninitialized in this function > > dito > >> CC aarch64-softmmu/hw/usb/tusb6010.o >> /tmp/qemu-test/src/hw/i386/acpi-build.c: In function >> ‘build_append_pci_bus_devices’: >> /tmp/qemu-test/src/hw/i386/acpi-build.c:525: warning: ‘notify_method’ may be >> used uninitialized in this function > > dito > > [...] >> /tmp/qemu-test/src/tests/ide-test.c: In function ‘cdrom_pio_impl’: >> /tmp/qemu-test/src/tests/ide-test.c:803: warning: ignoring return value of >> ‘fwrite’, declared with attribute warn_unused_result >> /tmp/qemu-test/src/tests/ide-test.c: In function ‘test_cdrom_dma’: >> /tmp/qemu-test/src/tests/ide-test.c:899: warning: ignoring return value of >> ‘fwrite’, declared with attribute warn_unused_result > > Needs a patch, I guess? > Huh, I've never seen these come up locally, I'll send a patch (if only to quiet patchew.) >> GTESTER tests/test-vmstate >> Failed to load simple/primitive:b_1 >> Failed to load simple/primitive:i64_2 >> Failed to load simple/primitive:i32_1 >> Failed to load simple/primitive:i32_1 >> Failed to load test/with_tmp:a >> Failed to load test/tmp_child_parent:f >> Failed to load test/tmp_child:parent >> Failed to load test/with_tmp:tmp >> Failed to load test/tmp_child:diff >> Failed to load test/with_tmp:tmp >> Failed to load test/tmp_child:diff >> Failed to load test/with_tmp:tmp > > That works for me when I
Re: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing
Applied to -trivial, thanks! /mjt
Re: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing
Thomas Huth, on mar. 23 mai 2017 09:25:30 +0200, wrote: > > /tmp/qemu-test/src/slirp/tcp_input.c: In function ‘tcp_input’: > > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_p’ may be > > used uninitialized in this function > > I've never seen these warnings in tcp_input.c before ... and they also > look like false positives too me ... They are. It's the classical false-positive: int foo; if (blah) foo = 1; ... if (blah) f(foo); where gcc doesn't realize it's the same condition between the initialization and the use. If that poses problem, we can force a dumb initialization... Samuel
Re: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing
On 22.05.2017 17:58, no-re...@patchew.org wrote: > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. [...] >LEX convert-dtsv0-lexer.lex.c >DEP /tmp/qemu-test/src/dtc/fdtdump.c > make[1]: flex: Command not found >BISON dtc-parser.tab.c > make[1]: bison: Command not found >DEP /tmp/qemu-test/src/dtc/srcpos.c >LEX dtc-lexer.lex.c > make[1]: flex: Command not found >DEP /tmp/qemu-test/src/dtc/treesource.c >DEP /tmp/qemu-test/src/dtc/livetree.c >DEP /tmp/qemu-test/src/dtc/fstree.c >DEP /tmp/qemu-test/src/dtc/flattree.c >DEP /tmp/qemu-test/src/dtc/dtc.c >DEP /tmp/qemu-test/src/dtc/data.c >DEP /tmp/qemu-test/src/dtc/checks.c > CHK version_gen.h >BISON dtc-parser.tab.c > make[1]: bison: Command not found >LEX convert-dtsv0-lexer.lex.c > UPD version_gen.h > make[1]: flex: Command not found >LEX dtc-lexer.lex.c > make[1]: flex: Command not found >DEP /tmp/qemu-test/src/dtc/util.c >LEX convert-dtsv0-lexer.lex.c >BISON dtc-parser.tab.c > make[1]: flex: Command not found > make[1]: bison: Command not found >LEX dtc-lexer.lex.c > make[1]: flex: Command not found Looks like flex and bison are missing in the docker image? Could someone please add it? [...] > CC replay/replay-internal.o > /tmp/qemu-test/src/replay/replay-internal.c: In function ‘replay_put_array’: > /tmp/qemu-test/src/replay/replay-internal.c:65: warning: ignoring return > value of ‘fwrite’, declared with attribute warn_unused_result I guess that should be fixed? [...] > CC slirp/tcp_input.o > CC slirp/tcp_output.o > CC slirp/tcp_subr.o > CC slirp/tcp_timer.o > /tmp/qemu-test/src/slirp/tcp_input.c: In function ‘tcp_input’: > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_p’ may be used > uninitialized in this function > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_len’ may be > used uninitialized in this function > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_tos’ may be > used uninitialized in this function > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_id’ may be > used uninitialized in this function > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_off’ may be > used uninitialized in this function > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_ttl’ may be > used uninitialized in this function > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_sum’ may be > used uninitialized in this function > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_src.s_addr’ > may be used uninitialized in this function > /tmp/qemu-test/src/slirp/tcp_input.c:219: warning: ‘save_ip.ip_dst.s_addr’ > may be used uninitialized in this function > /tmp/qemu-test/src/slirp/tcp_input.c:220: warning: ‘save_ip6.ip_nh’ may be > used uninitialized in this function I've never seen these warnings in tcp_input.c before ... and they also look like false positives too me ... is that GCC in the docker image too sensitive? [...] > CC aarch64-softmmu/hw/timer/exynos4210_rtc.o > /tmp/qemu-test/src/hw/i386/pc_piix.c: In function > ‘igd_passthrough_isa_bridge_create’: > /tmp/qemu-test/src/hw/i386/pc_piix.c:1067: warning: ‘pch_rev_id’ may be used > uninitialized in this function dito > CC aarch64-softmmu/hw/usb/tusb6010.o > /tmp/qemu-test/src/hw/i386/acpi-build.c: In function > ‘build_append_pci_bus_devices’: > /tmp/qemu-test/src/hw/i386/acpi-build.c:525: warning: ‘notify_method’ may be > used uninitialized in this function dito [...] > /tmp/qemu-test/src/tests/ide-test.c: In function ‘cdrom_pio_impl’: > /tmp/qemu-test/src/tests/ide-test.c:803: warning: ignoring return value of > ‘fwrite’, declared with attribute warn_unused_result > /tmp/qemu-test/src/tests/ide-test.c: In function ‘test_cdrom_dma’: > /tmp/qemu-test/src/tests/ide-test.c:899: warning: ignoring return value of > ‘fwrite’, declared with attribute warn_unused_result Needs a patch, I guess? > GTESTER tests/test-vmstate > Failed to load simple/primitive:b_1 > Failed to load simple/primitive:i64_2 > Failed to load simple/primitive:i32_1 > Failed to load simple/primitive:i32_1 > Failed to load test/with_tmp:a > Failed to load test/tmp_child_parent:f > Failed to load test/tmp_child:parent > Failed to load test/with_tmp:tmp > Failed to load test/tmp_child:diff > Failed to load test/with_tmp:tmp > Failed to load test/tmp_child:diff > Failed to load test/with_tmp:tmp That works for me when I run "make check" locally ... could my patch have broken this, or is there something else wrong in the repository or docker image? [...] > GTESTER tests/test-qga > GTESTER tests/test-timed-average > GTESTER tests/test-io-task > GTESTER
Re: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing Message-id: 1495467654-30911-1-git-send-email-th...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 export J=8 time make docker-test-quick@centos6 time make docker-test-mingw@fedora time make docker-test-build@min-glib === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1495467654-30911-1-git-send-email-th...@redhat.com -> patchew/1495467654-30911-1-git-send-email-th...@redhat.com - [tag update] patchew/20170519180342.19618-1-berra...@redhat.com -> patchew/20170519180342.19618-1-berra...@redhat.com Switched to a new branch 'test' a5ee64e tests/libqtest: Print error instead of aborting when env variable is missing === OUTPUT BEGIN === Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' Cloning into '/var/tmp/patchew-tester-tmp-hvxqeu2m/src/dtc'... Submodule path 'dtc': checked out '558cd81bdd432769b59bff01240c44f82cfb1a9d' BUILD centos6 make[1]: Entering directory '/var/tmp/patchew-tester-tmp-hvxqeu2m/src' ARCHIVE qemu.tgz ARCHIVE dtc.tgz COPYRUNNER RUN test-quick in qemu:centos6 Packages installed: SDL-devel-1.2.14-7.el6_7.1.x86_64 ccache-3.1.6-2.el6.x86_64 epel-release-6-8.noarch gcc-4.4.7-17.el6.x86_64 git-1.7.1-4.el6_7.1.x86_64 glib2-devel-2.28.8-5.el6.x86_64 libfdt-devel-1.4.0-1.el6.x86_64 make-3.81-23.el6.x86_64 package g++ is not installed pixman-devel-0.32.8-1.el6.x86_64 tar-1.23-15.el6_8.x86_64 zlib-devel-1.2.3-29.el6.x86_64 Environment variables: PACKAGES=libfdt-devel ccache tar git make gcc g++ zlib-devel glib2-devel SDL-devel pixman-devel epel-release HOSTNAME=4f13bab236d4 TERM=xterm MAKEFLAGS= -j8 HISTSIZE=1000 J=8 USER=root CCACHE_DIR=/var/tmp/ccache EXTRA_CONFIGURE_OPTS= V= SHOW_ENV=1 MAIL=/var/spool/mail/root PATH=/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD=/ LANG=en_US.UTF-8 TARGET_LIST= HISTCONTROL=ignoredups SHLVL=1 HOME=/root TEST_DIR=/tmp/qemu-test LOGNAME=root LESSOPEN=||/usr/bin/lesspipe.sh %s FEATURES= dtc DEBUG= G_BROKEN_FILENAMES=1 CCACHE_HASHDIR= _=/usr/bin/env Configure options: --enable-werror --target-list=x86_64-softmmu,aarch64-softmmu --prefix=/var/tmp/qemu-build/install No C++ compiler available; disabling C++ specific optional code Install prefix/var/tmp/qemu-build/install BIOS directory/var/tmp/qemu-build/install/share/qemu binary directory /var/tmp/qemu-build/install/bin library directory /var/tmp/qemu-build/install/lib module directory /var/tmp/qemu-build/install/lib/qemu libexec directory /var/tmp/qemu-build/install/libexec include directory /var/tmp/qemu-build/install/include config directory /var/tmp/qemu-build/install/etc local state directory /var/tmp/qemu-build/install/var Manual directory /var/tmp/qemu-build/install/share/man ELF interp prefix /usr/gnemul/qemu-%M Source path /tmp/qemu-test/src C compilercc Host C compiler cc C++ compiler Objective-C compiler cc ARFLAGS rv CFLAGS-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g QEMU_CFLAGS -I/usr/include/pixman-1 -I$(SRC_PATH)/dtc/libfdt -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-all LDFLAGS -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -pie -m64 -g make make install install pythonpython -B smbd /usr/sbin/smbd module supportno host CPU x86_64 host big endian no target list x86_64-softmmu aarch64-softmmu tcg debug enabled no gprof enabled no sparse enabledno strip binariesyes profiler no static build no pixmansystem SDL support yes (1.2.14) GTK support no GTK GL supportno VTE support no TLS priority NORMAL GNUTLS supportno GNUTLS rndno libgcrypt no libgcrypt kdf no nettleno nettle kdfno libtasn1 no curses supportno virgl support no curl support no mingw32 support no Audio drivers oss Block whitelist (rw) Block whitelist (ro) VirtFS supportno VNC support yes VNC SASL support
