Re: [Qemu-devel] [PATCH v2 0/6] bdrv_open() error return fixes

[Stefan Hajnoczi]

On Fri, Jan 25, 2013 at 05:07:26PM +0100, Kevin Wolf wrote:
 Kevin Wolf (6):
   bochs: Fix bdrv_open() error handling
   cloop: Fix bdrv_open() error handling
   vpc: Fix bdrv_open() error handling
   dmg: Fix bdrv_open() error handling
   dmg: Use g_free instead of free
   parallels: Fix bdrv_open() error handling
 
  block/bochs.c |   22 +---
  block/cloop.c |   29 +++
  block/dmg.c   |  153 
  block/parallels.c |   23 +---
  block/vpc.c   |   42 ++
  5 files changed, 185 insertions(+), 84 deletions(-)
 
 -- 
 1.7.6.5
 
 

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Ignoring coding style violations in block/dmg.c from existing code.

Stefan

Re: [Qemu-devel] [PATCH v2 0/6] bdrv_open() error return fixes

[Anthony Liguori]

Hi,

Thank you for submitting your patch series.  checkpatch.pl has
detected that one or more of the patches in this series violate
the QEMU coding style.

If you believe this message was sent in error, please ignore it
or respond here with an explanation.

Otherwise, please correct the coding style issues and resubmit a
new version of the patch.

For more information about QEMU coding style, see:

http://git.qemu.org/?p=qemu.git;a=blob_plain;f=CODING_STYLE;hb=HEAD

Here is the output from checkpatch.pl:

Subject: parallels: Fix bdrv_open() error handling
Subject: dmg: Use g_free instead of free
Subject: dmg: Fix bdrv_open() error handling
ERROR: space required after that ',' (ctx:VxV)
#68: FILE: block/dmg.c:91:
+uint64_t info_begin,info_end,last_in_offset,last_out_offset;
^

ERROR: space required after that ',' (ctx:VxV)
#68: FILE: block/dmg.c:91:
+uint64_t info_begin,info_end,last_in_offset,last_out_offset;
 ^

ERROR: space required after that ',' (ctx:VxV)
#68: FILE: block/dmg.c:91:
+uint64_t info_begin,info_end,last_in_offset,last_out_offset;
^

ERROR: space required before the open parenthesis '('
#203: FILE: block/dmg.c:225:
+if(inflateInit(s-zstream) != Z_OK) {

total: 4 errors, 0 warnings, 199 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Subject: vpc: Fix bdrv_open() error handling
Subject: cloop: Fix bdrv_open() error handling
Subject: bochs: Fix bdrv_open() error handling


Regards,

Anthony Liguori

Re: [Qemu-devel] [PATCH v2 0/6] bdrv_open() error return fixes

[Markus Armbruster]

You addressed all my comments.

Reviewed-by: Markus Armbruster arm...@redhat.com