Re: [Qemu-devel] [PATCH v3 05/22] libqtest: Add a layer of abstraciton to send/recv
On Thu, 2019-09-19 at 13:18 +0200, Paolo Bonzini wrote: > I think you can pass "s" to the tx handler as well, and remove the > send_opaque and recv_opaque fields? Qtest also uses this function to communicate over qmp (different fd). I can probably make the tx handler a wrapper which accepts "s", and passes s->fd to the real socket_send.
Re: [Qemu-devel] [PATCH v3 05/22] libqtest: Add a layer of abstraciton to send/recv
On 19/09/19 01:19, Oleinik, Alexander wrote: > +static GString *qtest_client_inproc_recv_line(void *); This is not defined as of this patch, please move it to patch 14. > > +qtest_client_set_rx_handler(s, qtest_client_socket_recv_line, s); > +qtest_client_set_tx_handler(s, qtest_client_socket_send, &(s->fd)); > + I think you can pass "s" to the tx handler as well, and remove the send_opaque and recv_opaque fields? Paolo
Re: [Qemu-devel] [PATCH v3 05/22] libqtest: Add a layer of abstraciton to send/recv
On Wed, Sep 18, 2019 at 11:19:32PM +, Oleinik, Alexander wrote: > This makes it simple to swap the transport functions for qtest commands > to and from the qtest client. For example, now it is possible to > directly pass qtest commands to a server handler that exists within the > same process, without the standard way of writing to a file descriptor. > > Signed-off-by: Alexander Oleinik > --- > tests/libqtest.c | 64 +++- > tests/libqtest.h | 1 - > 2 files changed, 53 insertions(+), 12 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature
