Re: [Qemu-devel] [PULL 00/18] Block layer patches for 2.10.0-rc2

[Peter Maydell]

On 8 August 2017 at 14:58, Kevin Wolf  wrote:
> The following changes since commit b4174c4b08a719e7df7e4f35c29f44b7c2517237:
>
>   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging 
> (2017-08-08 10:01:49 +0100)
>
> are available in the git repository at:
>
>   git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to 113fe792fd4931dd0538f03859278b8719ee4fa2:
>
>   block/nfs: fix mutex assertion in nfs_file_close() (2017-08-08 15:19:16 
> +0200)
>
> 
> Block layer patches for 2.10.0-rc2
>
> 

Applied, thanks.

-- PMM

Re: [Qemu-devel] [PULL 00/18] Block layer patches

[John Snow]

On 09/29/2016 02:17 PM, Paolo Bonzini wrote:



On 29/09/2016 19:02, John Snow wrote:



On 09/29/2016 06:25 AM, Kevin Wolf wrote:

John, can you have a look at the IDE code and check whether we can get
rid of the deep recursion? It seems that the test issues a large request
that is then split into many small requests. But it should be possible
to do this iteratively rather than recursively.


http://wiki.qemu.org/Features/IDE

"Rewrite ide_atapi_cmd_reply_end to be fully non-recursive; and ideally
less confusing."

Guess I have to float this one to the top.


Would it be enough to hide the call to s->bus->dma->ops->start_transfer
behind a bottom half?

Paolo



Probably the simplest way, even if not the prettiest.

Re: [Qemu-devel] [PULL 00/18] Block layer patches

[John Snow]

On 09/29/2016 01:18 PM, Peter Maydell wrote:

On 29 September 2016 at 03:25, Kevin Wolf  wrote:

The series contains a patch that reduces the coroutine stack size, so I
guess it's not quite infinite, but pretty deep recursion anyway. I will
drop that final patch that reduces the stack size and hope that the rest
will pass your testing (I tried some more to reproduce it, but I still
didn't manage to).


Ah, I see. I suspect the clang build (since it has the sanitizer
enabled) is a worst-case for stack usage.

Is it possible for a guest to issue a sufficiently large
request that it blows the stack, or is that capped
somehow?

thanks
-- PMM



If the qtest can blow the stack, so can a guest. In practice it does not 
happen that guests send requests so large, but mum's the word on a 
naughty guest.


--js

Re: [Qemu-devel] [PULL 00/18] Block layer patches

[Paolo Bonzini]

On 29/09/2016 19:02, John Snow wrote:
> 
> 
> On 09/29/2016 06:25 AM, Kevin Wolf wrote:
>> John, can you have a look at the IDE code and check whether we can get
>> rid of the deep recursion? It seems that the test issues a large request
>> that is then split into many small requests. But it should be possible
>> to do this iteratively rather than recursively.
> 
> http://wiki.qemu.org/Features/IDE
> 
> "Rewrite ide_atapi_cmd_reply_end to be fully non-recursive; and ideally
> less confusing."
> 
> Guess I have to float this one to the top.

Would it be enough to hide the call to s->bus->dma->ops->start_transfer
behind a bottom half?

Paolo

Re: [Qemu-devel] [PULL 00/18] Block layer patches

[Peter Maydell]

On 29 September 2016 at 03:25, Kevin Wolf  wrote:
> The series contains a patch that reduces the coroutine stack size, so I
> guess it's not quite infinite, but pretty deep recursion anyway. I will
> drop that final patch that reduces the stack size and hope that the rest
> will pass your testing (I tried some more to reproduce it, but I still
> didn't manage to).

Ah, I see. I suspect the clang build (since it has the sanitizer
enabled) is a worst-case for stack usage.

Is it possible for a guest to issue a sufficiently large
request that it blows the stack, or is that capped
somehow?

thanks
-- PMM

Re: [Qemu-devel] [PULL 00/18] Block layer patches

[John Snow]

On 09/29/2016 06:25 AM, Kevin Wolf wrote:

John, can you have a look at the IDE code and check whether we can get
rid of the deep recursion? It seems that the test issues a large request
that is then split into many small requests. But it should be possible
to do this iteratively rather than recursively.


http://wiki.qemu.org/Features/IDE

"Rewrite ide_atapi_cmd_reply_end to be fully non-recursive; and ideally 
less confusing."


Guess I have to float this one to the top.

--js

Re: [Qemu-devel] [PULL 00/18] Block layer patches

[Kevin Wolf]

Am 28.09.2016 um 21:03 hat Peter Maydell geschrieben:
> On 28 September 2016 at 02:37, Kevin Wolf  wrote:
> > Am 27.09.2016 um 21:42 hat Peter Maydell geschrieben:
> >> On 27 September 2016 at 06:53, Kevin Wolf  wrote:
> >> > The following changes since commit 
> >> > 7cfdc02dae0d2ff58c897496cfdbbafc0eda0f3f:
> >> >
> >> >   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into 
> >> > staging (2016-09-26 19:47:00 +0100)
> >> >
> >> > are available in the git repository at:
> >> >
> >> >
> >> >   git://repo.or.cz/qemu/kevin.git tags/for-upstream
> >> >
> >> > for you to fetch changes up to 3b856cebe5e93547852c156ca2119d075e62aed7:
> >> >
> >> >   coroutine: reduce stack size to 60kB (2016-09-27 14:05:21 +0200)
> >> >
> >> > 
> >> > Block layer patches
> >> >
> >> > 
> >>
> >> I see 'make check' failures on x86-64 host, clang Linux:
> >>
> >>   /i386/ahci/migrate/ncq/simple:   OK
> >>   /i386/ahci/migrate/ncq/halted:   OK
> >>   /i386/ahci/cdrom/dma/single: OK
> >>   /i386/ahci/cdrom/dma/multi:  OK
> >>   /i386/ahci/cdrom/pio/single:
> >> Broken pipe
> >> FAIL
> >> GTester: last random seed: R02Sa8f729848b07c3b3e5ee67368f9d0350
> >> (pid=10590)
> >>   /i386/ahci/cdrom/pio/multi:
> >> Broken pipe
> >> FAIL
> >> GTester: last random seed: R02Se85704e04bbd382223983c878723b811
> >> (pid=10598)
> >> FAIL: tests/ahci-test
> >> TEST: tests/hd-geo-test... (pid=10601)
> >>   /i386/hd-geo/ide/none:   OK
> >
> > I asked on IRC, but as you don't seem to be around at the moment, I'll
> > keep things on the list instead.
> 
> I got a gdb backtrace:
> 
> Thread 1 "qemu-system-i38" received signal SIGSEGV, Segmentation fault.
> 0x561dea15 in address_space_translate (as=0x5a46bfc0,
> addr=1106048, xlat=0x77e0d050, plen=0x77e0d058,
> is_write=false) at /home/petmay01/linaro/qemu-for-merges/exec.c:423
> 423 {
> 
> 
> Backtrace suggests we've run out of stack due to some infinite
> recursion:

Thanks, Peter, this is useful.

The series contains a patch that reduces the coroutine stack size, so I
guess it's not quite infinite, but pretty deep recursion anyway. I will
drop that final patch that reduces the stack size and hope that the rest
will pass your testing (I tried some more to reproduce it, but I still
didn't manage to).

John, can you have a look at the IDE code and check whether we can get
rid of the deep recursion? It seems that the test issues a large request
that is then split into many small requests. But it should be possible
to do this iteratively rather than recursively.

Kevin

> #0  0x561dea15 in address_space_translate (as=0x5a46bfc0,
> addr=1106048, xlat=0x77e0d050, plen=0x77e0d058,
> is_write=false) at /home/petmay01/linaro/qemu-for-merges/exec.c:423
> #1  0x561edeab in address_space_map (as=,
> addr=1106048, plen=, is_write=false)
> at /home/petmay01/linaro/qemu-for-merges/exec.c:2909
> #2  0x56840b9b in ahci_populate_sglist (as=0x5a46bfc0,
> addr=1106048, dir=DMA_DIRECTION_TO_DEVICE, len=)
> at /home/petmay01/linaro/qemu-for-merges/include/sysemu/dma.h:135
> #3  0x56840b9b in ahci_populate_sglist (ad=,
> sglist=, cmd=, limit=,
> offset=1592) at
> /home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:863
> #4  0x56844de4 in ahci_dma_prepare_buf (dma=0x5a475b48,
> limit=)
> at /home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1366
> #5  0x5684354c in ahci_start_transfer (dma=) at
> /home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1295
> #6  0x568250cb in ide_atapi_cmd_reply_end (s=)
> at /home/petmay01/linaro/qemu-for-merges/hw/ide/atapi.c:324
> #7  0x56843662 in ahci_start_transfer (dma=) at
> /home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1318
> #8  0x568250cb in ide_atapi_cmd_reply_end (s=)
> at /home/petmay01/linaro/qemu-for-merges/hw/ide/atapi.c:324
> #9  0x56843662 in ahci_start_transfer (dma=) at
> /home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1318
> #10 0x568250cb in ide_atapi_cmd_reply_end (s=)
> at /home/petmay01/linaro/qemu-for-merges/hw/ide/atapi.c:324
> #11 0x56843662 in ahci_start_transfer (dma=) at
> /home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1318
> #12 0x568250cb in ide_atapi_cmd_reply_end (s=)
> at /home/petmay01/linaro/qemu-for-merges/hw/ide/atapi.c:324
> #13 0x56843662 in ahci_start_transfer (dma=) at
> /home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1318
> #14 0x568250cb in ide_atapi_cmd_reply_end (s=)
> at /home/petmay01/linaro/qemu-for-merges/hw/ide/atapi.c:324
> #15 0x56843662 in ahci_start_transfer (dma=) at

Re: [Qemu-devel] [PULL 00/18] Block layer patches

[Peter Maydell]

On 28 September 2016 at 02:37, Kevin Wolf  wrote:
> Am 27.09.2016 um 21:42 hat Peter Maydell geschrieben:
>> On 27 September 2016 at 06:53, Kevin Wolf  wrote:
>> > The following changes since commit 
>> > 7cfdc02dae0d2ff58c897496cfdbbafc0eda0f3f:
>> >
>> >   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into 
>> > staging (2016-09-26 19:47:00 +0100)
>> >
>> > are available in the git repository at:
>> >
>> >
>> >   git://repo.or.cz/qemu/kevin.git tags/for-upstream
>> >
>> > for you to fetch changes up to 3b856cebe5e93547852c156ca2119d075e62aed7:
>> >
>> >   coroutine: reduce stack size to 60kB (2016-09-27 14:05:21 +0200)
>> >
>> > 
>> > Block layer patches
>> >
>> > 
>>
>> I see 'make check' failures on x86-64 host, clang Linux:
>>
>>   /i386/ahci/migrate/ncq/simple:   OK
>>   /i386/ahci/migrate/ncq/halted:   OK
>>   /i386/ahci/cdrom/dma/single: OK
>>   /i386/ahci/cdrom/dma/multi:  OK
>>   /i386/ahci/cdrom/pio/single:
>> Broken pipe
>> FAIL
>> GTester: last random seed: R02Sa8f729848b07c3b3e5ee67368f9d0350
>> (pid=10590)
>>   /i386/ahci/cdrom/pio/multi:
>> Broken pipe
>> FAIL
>> GTester: last random seed: R02Se85704e04bbd382223983c878723b811
>> (pid=10598)
>> FAIL: tests/ahci-test
>> TEST: tests/hd-geo-test... (pid=10601)
>>   /i386/hd-geo/ide/none:   OK
>
> I asked on IRC, but as you don't seem to be around at the moment, I'll
> keep things on the list instead.

I got a gdb backtrace:

Thread 1 "qemu-system-i38" received signal SIGSEGV, Segmentation fault.
0x561dea15 in address_space_translate (as=0x5a46bfc0,
addr=1106048, xlat=0x77e0d050, plen=0x77e0d058,
is_write=false) at /home/petmay01/linaro/qemu-for-merges/exec.c:423
423 {


Backtrace suggests we've run out of stack due to some infinite
recursion:

#0  0x561dea15 in address_space_translate (as=0x5a46bfc0,
addr=1106048, xlat=0x77e0d050, plen=0x77e0d058,
is_write=false) at /home/petmay01/linaro/qemu-for-merges/exec.c:423
#1  0x561edeab in address_space_map (as=,
addr=1106048, plen=, is_write=false)
at /home/petmay01/linaro/qemu-for-merges/exec.c:2909
#2  0x56840b9b in ahci_populate_sglist (as=0x5a46bfc0,
addr=1106048, dir=DMA_DIRECTION_TO_DEVICE, len=)
at /home/petmay01/linaro/qemu-for-merges/include/sysemu/dma.h:135
#3  0x56840b9b in ahci_populate_sglist (ad=,
sglist=, cmd=, limit=,
offset=1592) at
/home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:863
#4  0x56844de4 in ahci_dma_prepare_buf (dma=0x5a475b48,
limit=)
at /home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1366
#5  0x5684354c in ahci_start_transfer (dma=) at
/home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1295
#6  0x568250cb in ide_atapi_cmd_reply_end (s=)
at /home/petmay01/linaro/qemu-for-merges/hw/ide/atapi.c:324
#7  0x56843662 in ahci_start_transfer (dma=) at
/home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1318
#8  0x568250cb in ide_atapi_cmd_reply_end (s=)
at /home/petmay01/linaro/qemu-for-merges/hw/ide/atapi.c:324
#9  0x56843662 in ahci_start_transfer (dma=) at
/home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1318
#10 0x568250cb in ide_atapi_cmd_reply_end (s=)
at /home/petmay01/linaro/qemu-for-merges/hw/ide/atapi.c:324
#11 0x56843662 in ahci_start_transfer (dma=) at
/home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1318
#12 0x568250cb in ide_atapi_cmd_reply_end (s=)
at /home/petmay01/linaro/qemu-for-merges/hw/ide/atapi.c:324
#13 0x56843662 in ahci_start_transfer (dma=) at
/home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1318
#14 0x568250cb in ide_atapi_cmd_reply_end (s=)
at /home/petmay01/linaro/qemu-for-merges/hw/ide/atapi.c:324
#15 0x56843662 in ahci_start_transfer (dma=) at
/home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1318
#16 0x568250cb in ide_atapi_cmd_reply_end (s=)
at /home/petmay01/linaro/qemu-for-merges/hw/ide/atapi.c:324
#17 0x56843662 in ahci_start_transfer (dma=) at
/home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1318
#18 0x568250cb in ide_atapi_cmd_reply_end (s=)
at /home/petmay01/linaro/qemu-for-merges/hw/ide/atapi.c:324
#19 0x56843662 in ahci_start_transfer (dma=) at
/home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1318
#20 0x568250cb in ide_atapi_cmd_reply_end (s=)
at /home/petmay01/linaro/qemu-for-merges/hw/ide/atapi.c:324
#21 0x56843662 in ahci_start_transfer (dma=) at
/home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:1318
#22 0x568250cb in ide_atapi_cmd_reply_end (s=)
at 

Re: [Qemu-devel] [PULL 00/18] Block layer patches

[Peter Maydell]

On 28 September 2016 at 02:37, Kevin Wolf  wrote:
> [what clang config?]

This is with Ubuntu Xenial's clang. configure args are

'--cc=clang' '--cxx=clang++' '--enable-gtk'
'--extra-cflags=-fsanitize=undefined -Werror'

and the build is just 'make all -j8 && make check' in the build
directory.

thanks
-- PMM

Re: [Qemu-devel] [PULL 00/18] Block layer patches

[Kevin Wolf]

Am 27.09.2016 um 21:42 hat Peter Maydell geschrieben:
> On 27 September 2016 at 06:53, Kevin Wolf  wrote:
> > The following changes since commit 7cfdc02dae0d2ff58c897496cfdbbafc0eda0f3f:
> >
> >   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging 
> > (2016-09-26 19:47:00 +0100)
> >
> > are available in the git repository at:
> >
> >
> >   git://repo.or.cz/qemu/kevin.git tags/for-upstream
> >
> > for you to fetch changes up to 3b856cebe5e93547852c156ca2119d075e62aed7:
> >
> >   coroutine: reduce stack size to 60kB (2016-09-27 14:05:21 +0200)
> >
> > 
> > Block layer patches
> >
> > 
> 
> I see 'make check' failures on x86-64 host, clang Linux:
> 
>   /i386/ahci/migrate/ncq/simple:   OK
>   /i386/ahci/migrate/ncq/halted:   OK
>   /i386/ahci/cdrom/dma/single: OK
>   /i386/ahci/cdrom/dma/multi:  OK
>   /i386/ahci/cdrom/pio/single:
> Broken pipe
> FAIL
> GTester: last random seed: R02Sa8f729848b07c3b3e5ee67368f9d0350
> (pid=10590)
>   /i386/ahci/cdrom/pio/multi:
> Broken pipe
> FAIL
> GTester: last random seed: R02Se85704e04bbd382223983c878723b811
> (pid=10598)
> FAIL: tests/ahci-test
> TEST: tests/hd-geo-test... (pid=10601)
>   /i386/hd-geo/ide/none:   OK

I asked on IRC, but as you don't seem to be around at the moment, I'll
keep things on the list instead.

Can you tell me the exact 'configure' and 'make check' command lines
you're using? I always run the tests with clang/Linux on x86_64 before
sending a pull request, and I repeated it now, but the tests pass for
me.

This is what I'm doing (yesterday I built all targets, today only
i386-softmmu because that seems to be what fails for you):

$ clang --version
clang version 3.4.2 (tags/RELEASE_34/dot2-final)
Target: x86_64-redhat-linux-gnu
Thread model: posix
$ ../qemu/configure --cc=clang --host-cc=clang --cxx=clang++ 
--target-list=i386-softmmu
$ make -j4
$ make check

Kevin

Re: [Qemu-devel] [PULL 00/18] Block layer patches

[Peter Maydell]

On 27 September 2016 at 06:53, Kevin Wolf  wrote:
> The following changes since commit 7cfdc02dae0d2ff58c897496cfdbbafc0eda0f3f:
>
>   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging 
> (2016-09-26 19:47:00 +0100)
>
> are available in the git repository at:
>
>
>   git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to 3b856cebe5e93547852c156ca2119d075e62aed7:
>
>   coroutine: reduce stack size to 60kB (2016-09-27 14:05:21 +0200)
>
> 
> Block layer patches
>
> 

I see 'make check' failures on x86-64 host, clang Linux:

  /i386/ahci/migrate/ncq/simple:   OK
  /i386/ahci/migrate/ncq/halted:   OK
  /i386/ahci/cdrom/dma/single: OK
  /i386/ahci/cdrom/dma/multi:  OK
  /i386/ahci/cdrom/pio/single:
Broken pipe
FAIL
GTester: last random seed: R02Sa8f729848b07c3b3e5ee67368f9d0350
(pid=10590)
  /i386/ahci/cdrom/pio/multi:
Broken pipe
FAIL
GTester: last random seed: R02Se85704e04bbd382223983c878723b811
(pid=10598)
FAIL: tests/ahci-test
TEST: tests/hd-geo-test... (pid=10601)
  /i386/hd-geo/ide/none:   OK


thanks
-- PMM

Re: [Qemu-devel] [PULL 00/18] Block layer patches

[Max Reitz]

On 15.09.2016 18:10, Peter Maydell wrote:
> On 14 September 2016 at 17:40, Max Reitz  wrote:
>> The following changes since commit 507e4ddc3abf67391bcbc9624fd60b969c159b78:
>>
>>   Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into 
>> staging (2016-09-13 17:55:35 +0100)
>>
>> are available in the git repository at:
>>
>>   git://github.com/XanClic/qemu.git tags/pull-block-2016-09-14
>>
>> for you to fetch changes up to 262a8020cf666ae7108040683038cc46be4c48d2:
>>
>>   iotest 055: refactor and speed up (2016-09-14 17:56:42 +0200)
>>
>> 
>> Block patches for 2.8
>>
>> 
> 
> Compile failure on 32 bit:
>   CCutil/qemu-option.o
> /home/petmay01/qemu/util/hbitmap.c: In function 'hbitmap_serialization_size':
> /home/petmay01/qemu/util/hbitmap.c:439:5: error: passing argument 5 of
> 'serialization_chunk' from incompatible pointer type [-Werror]
>  serialization_chunk(hb, start, count, , _count);
>  ^
> /home/petmay01/qemu/util/hbitmap.c:410:13: note: expected 'size_t *'
> but argument is of type 'uint64_t *'
>  static void serialization_chunk(const HBitmap *hb,
>  ^
> /home/petmay01/qemu/util/hbitmap.c: In function 'hbitmap_serialize_part':
> /home/petmay01/qemu/util/hbitmap.c:453:5: error: passing argument 5 of
> 'serialization_chunk' from incompatible pointer type [-Werror]
>  serialization_chunk(hb, start, count, , _count);
>  ^
> /home/petmay01/qemu/util/hbitmap.c:410:13: note: expected 'size_t *'
> but argument is of type 'uint64_t *'
>  static void serialization_chunk(const HBitmap *hb,
>  ^
> /home/petmay01/qemu/util/hbitmap.c: In function 'hbitmap_deserialize_part':
> /home/petmay01/qemu/util/hbitmap.c:476:5: error: passing argument 5 of
> 'serialization_chunk' from incompatible pointer type [-Werror]
>  serialization_chunk(hb, start, count, , _count);
>  ^
> /home/petmay01/qemu/util/hbitmap.c:410:13: note: expected 'size_t *'
> but argument is of type 'uint64_t *'
>  static void serialization_chunk(const HBitmap *hb,
>  ^
> /home/petmay01/qemu/util/hbitmap.c: In function 'hbitmap_deserialize_zeroes':
> /home/petmay01/qemu/util/hbitmap.c:505:5: error: passing argument 5 of
> 'serialization_chunk' from incompatible pointer type [-Werror]
>  serialization_chunk(hb, start, count, , _count);
>  ^
> /home/petmay01/qemu/util/hbitmap.c:410:13: note: expected 'size_t *'
> but argument is of type 'uint64_t *'
>  static void serialization_chunk(const HBitmap *hb,
>  ^
> cc1: all warnings being treated as errors
> 
> 
> Test failure on big-endian ppc64be:
> 
>   /hbitmap/serialize/granularity:  OK
>   /hbitmap/serialize/basic:**
> ERROR:/home/pm215/qemu/tests/test-hbitmap.c:774:hbitmap_test_serialize_range:
> assertion failed: (is_set)
> FAIL
> GTester: last random seed: R02Se8652df9788b7a1ec926da1717ff2d26
> (pid=34146)
>   /hbitmap/serialize/part: **
> ERROR:/home/pm215/qemu/tests/test-hbitmap.c:843:test_hbitmap_serialize_part:
> assertion failed (should_set == test_bit(j, (unsigned long *)buf)): (1
> == 0)
> FAIL
> GTester: last random seed: R02S3e07d1d6dcda6b90721e062eca26e6b9
> (pid=34147)
>   /hbitmap/serialize/zeroes:   OK
> FAIL: tests/test-hbitmap

Thank you! That looks interesting. I'll drop the series in question from
my queue and send a v2.

Max



signature.asc
Description: OpenPGP digital signature

Re: [Qemu-devel] [PULL 00/18] Block layer patches

[Peter Maydell]

On 14 September 2016 at 17:40, Max Reitz  wrote:
> The following changes since commit 507e4ddc3abf67391bcbc9624fd60b969c159b78:
>
>   Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into 
> staging (2016-09-13 17:55:35 +0100)
>
> are available in the git repository at:
>
>   git://github.com/XanClic/qemu.git tags/pull-block-2016-09-14
>
> for you to fetch changes up to 262a8020cf666ae7108040683038cc46be4c48d2:
>
>   iotest 055: refactor and speed up (2016-09-14 17:56:42 +0200)
>
> 
> Block patches for 2.8
>
> 

Compile failure on 32 bit:
  CCutil/qemu-option.o
/home/petmay01/qemu/util/hbitmap.c: In function 'hbitmap_serialization_size':
/home/petmay01/qemu/util/hbitmap.c:439:5: error: passing argument 5 of
'serialization_chunk' from incompatible pointer type [-Werror]
 serialization_chunk(hb, start, count, , _count);
 ^
/home/petmay01/qemu/util/hbitmap.c:410:13: note: expected 'size_t *'
but argument is of type 'uint64_t *'
 static void serialization_chunk(const HBitmap *hb,
 ^
/home/petmay01/qemu/util/hbitmap.c: In function 'hbitmap_serialize_part':
/home/petmay01/qemu/util/hbitmap.c:453:5: error: passing argument 5 of
'serialization_chunk' from incompatible pointer type [-Werror]
 serialization_chunk(hb, start, count, , _count);
 ^
/home/petmay01/qemu/util/hbitmap.c:410:13: note: expected 'size_t *'
but argument is of type 'uint64_t *'
 static void serialization_chunk(const HBitmap *hb,
 ^
/home/petmay01/qemu/util/hbitmap.c: In function 'hbitmap_deserialize_part':
/home/petmay01/qemu/util/hbitmap.c:476:5: error: passing argument 5 of
'serialization_chunk' from incompatible pointer type [-Werror]
 serialization_chunk(hb, start, count, , _count);
 ^
/home/petmay01/qemu/util/hbitmap.c:410:13: note: expected 'size_t *'
but argument is of type 'uint64_t *'
 static void serialization_chunk(const HBitmap *hb,
 ^
/home/petmay01/qemu/util/hbitmap.c: In function 'hbitmap_deserialize_zeroes':
/home/petmay01/qemu/util/hbitmap.c:505:5: error: passing argument 5 of
'serialization_chunk' from incompatible pointer type [-Werror]
 serialization_chunk(hb, start, count, , _count);
 ^
/home/petmay01/qemu/util/hbitmap.c:410:13: note: expected 'size_t *'
but argument is of type 'uint64_t *'
 static void serialization_chunk(const HBitmap *hb,
 ^
cc1: all warnings being treated as errors


Test failure on big-endian ppc64be:

  /hbitmap/serialize/granularity:  OK
  /hbitmap/serialize/basic:**
ERROR:/home/pm215/qemu/tests/test-hbitmap.c:774:hbitmap_test_serialize_range:
assertion failed: (is_set)
FAIL
GTester: last random seed: R02Se8652df9788b7a1ec926da1717ff2d26
(pid=34146)
  /hbitmap/serialize/part: **
ERROR:/home/pm215/qemu/tests/test-hbitmap.c:843:test_hbitmap_serialize_part:
assertion failed (should_set == test_bit(j, (unsigned long *)buf)): (1
== 0)
FAIL
GTester: last random seed: R02S3e07d1d6dcda6b90721e062eca26e6b9
(pid=34147)
  /hbitmap/serialize/zeroes:   OK
FAIL: tests/test-hbitmap

thanks
-- PMM