Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features
On 25/09/2016 02:49, Michael S. Tsirkin wrote: > > Not quite, there's no reason for the ops to be inside AMDVIState rather > > than a (static) global. > > I guess but it's a logic refactoring, not merely a style one. > I feel we can do it on top, tool shouldn't require this. We can do it on top, but the tool is correct in requiring it. Paolo
Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features
On Sat, Sep 24, 2016 at 06:10:37PM +0200, Paolo Bonzini wrote: > > > On 24/09/2016 00:05, Michael S. Tsirkin wrote: > >> e events... > >> > Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU... > >> > ERROR: struct MemoryRegionIOMMUOps should normally be const > >> > #1527: FILE: hw/i386/amd_iommu.h:280: > >> > +MemoryRegionIOMMUOps iommu_ops; > > > > False positive. > > Not quite, there's no reason for the ops to be inside AMDVIState rather > than a (static) global. > > Paolo I guess but it's a logic refactoring, not merely a style one. I feel we can do it on top, tool shouldn't require this.
Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features
On 24/09/2016 00:05, Michael S. Tsirkin wrote: >> e events... >> > Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU... >> > ERROR: struct MemoryRegionIOMMUOps should normally be const >> > #1527: FILE: hw/i386/amd_iommu.h:280: >> > +MemoryRegionIOMMUOps iommu_ops; > > False positive. Not quite, there's no reason for the ops to be inside AMDVIState rather than a (static) global. Paolo
Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features
On Fri, Sep 23, 2016 at 01:35:11PM -0700, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Hi, > > Your series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Type: series > Message-id: 1474658051-18617-1-git-send-email-...@redhat.com > Subject: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features > > === TEST SCRIPT BEGIN === > #!/bin/bash > set -e > git submodule update --init dtc > make J=8 docker-test-quick@centos6 > make J=8 docker-test-mingw@fedora > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] patchew/1474658051-18617-1-git-send-email-...@redhat.com > -> patchew/1474658051-18617-1-git-send-email-...@redhat.com > Switched to a new branch 'test' > cacc4b0 hw/i386: AMD IOMMU IVRS table > 9dd76e8 hw/i386: Introduce AMD IOMMU > 51d6513 hw/i386/trace-events: Add AMD IOMMU trace events > 2897b28 hw/pci: Prepare for AMD IOMMU > 9ed4ac9 virtio: handle virtqueue_get_head() errors > eba15c9 virtio: handle virtqueue_num_heads() errors > 3c5513c virtio: handle virtqueue_read_next_desc() errors > 3e2dd44 virtio: use unsigned int for virtqueue_get_avail_bytes() index > b63060b virtio: handle virtqueue_get_avail_bytes() errors > a7e238f virtio: handle virtqueue_map_desc() errors > b1ee7b9 virtio: migrate vdev->broken flag > 5ae212e virtio: stop virtqueue processing if device is broken > 7add352 virtio: fix stray tab character > a8b4e23 target-i386: turn off CPU.l3-cache only for 2.7 and older machine > types > eb0f9de pc: clean up COMPAT macro chaining > f2df3c1 virtio: add check for descriptor's mapped address > f2997b7 tests: add /vhost-user/flags-mismatch test > b612c50 tests: add a simple /vhost-user/multiqueue test > c38be03 tests: add /vhost-user/connect-fail test > > === OUTPUT BEGIN === > Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' > Cloning into 'dtc'... > Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf' > BUILD centos6 > ARCHIVE qemu.tgz > ARCHIVE dtc.tgz > COPY RUNNER > RUN test-quick in centos6 > Configure options: > --enable-werror --target-list=x86_64-softmmu,aarch64-softmmu > --prefix=/tmp/qemu-test/src/tests/docker/install > No C++ compiler available; disabling C++ specific optional code > Install prefix/tmp/qemu-test/src/tests/docker/install > BIOS directory/tmp/qemu-test/src/tests/docker/install/share/qemu > binary directory /tmp/qemu-test/src/tests/docker/install/bin > library directory /tmp/qemu-test/src/tests/docker/install/lib > module directory /tmp/qemu-test/src/tests/docker/install/lib/qemu > libexec directory /tmp/qemu-test/src/tests/docker/install/libexec > include directory /tmp/qemu-test/src/tests/docker/install/include > config directory /tmp/qemu-test/src/tests/docker/install/etc > local state directory /tmp/qemu-test/src/tests/docker/install/var > Manual directory /tmp/qemu-test/src/tests/docker/install/share/man > ELF interp prefix /usr/gnemul/qemu-%M > Source path /tmp/qemu-test/src > C compilercc > Host C compiler cc > C++ compiler > Objective-C compiler cc > ARFLAGS rv > CFLAGS-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -pthread > -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -g > QEMU_CFLAGS -I/usr/include/pixman-1-fPIE -DPIE -m64 -D_GNU_SOURCE > -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes > -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes > -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels > -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security > -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration > -Wold-style-definition -Wtype-limits -fstack-protector-all > LDFLAGS -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -pie -m64 -g > make make > install install > pythonpython -B > smbd /usr/sbin/smbd > module supportno > host CPU x86_64 > host big endian no > target list x86_64-softmmu aarch64-softmmu > tcg debug enabled no > gprof enabled no > sparse enabledno > strip binariesyes > profiler no > static build no > pixmansystem > SDL support yes (1.2.14) > GTK support no > GTK GL supportno > VTE support no > TLS priority NORMAL > GNUTLS supportno > GNUTLS rndno > libgcrypt no > libgcrypt kdf no > nettleno > nettle kdfno > libtasn1 no > curses supportno > virgl support no > curl support no > mingw32 support no > Audio drivers oss > Block whitelist (rw) > Block whitelist (ro) > VirtFS supportno > VNC support yes > VNC SASL support no > VNC JPEG support no > VNC PNG support no > xen
Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features
On Fri, Sep 23, 2016 at 01:35:32PM -0700, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 1474658051-18617-1-git-send-email-...@redhat.com > Subject: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > # Useful git options > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > cacc4b0 hw/i386: AMD IOMMU IVRS table > 9dd76e8 hw/i386: Introduce AMD IOMMU > 51d6513 hw/i386/trace-events: Add AMD IOMMU trace events > 2897b28 hw/pci: Prepare for AMD IOMMU > 9ed4ac9 virtio: handle virtqueue_get_head() errors > eba15c9 virtio: handle virtqueue_num_heads() errors > 3c5513c virtio: handle virtqueue_read_next_desc() errors > 3e2dd44 virtio: use unsigned int for virtqueue_get_avail_bytes() index > b63060b virtio: handle virtqueue_get_avail_bytes() errors > a7e238f virtio: handle virtqueue_map_desc() errors > b1ee7b9 virtio: migrate vdev->broken flag > 5ae212e virtio: stop virtqueue processing if device is broken > 7add352 virtio: fix stray tab character > a8b4e23 target-i386: turn off CPU.l3-cache only for 2.7 and older machine > types > eb0f9de pc: clean up COMPAT macro chaining > f2df3c1 virtio: add check for descriptor's mapped address > f2997b7 tests: add /vhost-user/flags-mismatch test > b612c50 tests: add a simple /vhost-user/multiqueue test > c38be03 tests: add /vhost-user/connect-fail test > > === OUTPUT BEGIN === > Checking PATCH 1/19: tests: add /vhost-user/connect-fail test... > Checking PATCH 2/19: tests: add a simple /vhost-user/multiqueue test... > WARNING: line over 80 characters > #192: FILE: tests/vhost-user-test.c:824: > +cmd = g_strdup_printf(QEMU_CMD_MEM QEMU_CMD_CHR QEMU_CMD_NETDEV > ",queues=%d " > > total: 0 errors, 1 warnings, 198 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > Checking PATCH 3/19: tests: add /vhost-user/flags-mismatch test... > Checking PATCH 4/19: virtio: add check for descriptor's mapped address... > Checking PATCH 5/19: pc: clean up COMPAT macro chaining... > Checking PATCH 6/19: target-i386: turn off CPU.l3-cache only for 2.7 and > older machine types... > Checking PATCH 7/19: virtio: fix stray tab character... > Checking PATCH 8/19: virtio: stop virtqueue processing if device is broken... > Checking PATCH 9/19: virtio: migrate vdev->broken flag... > Checking PATCH 10/19: virtio: handle virtqueue_map_desc() errors... > Checking PATCH 11/19: virtio: handle virtqueue_get_avail_bytes() errors... > Checking PATCH 12/19: virtio: use unsigned int for > virtqueue_get_avail_bytes() index... > Checking PATCH 13/19: virtio: handle virtqueue_read_next_desc() errors... > Checking PATCH 14/19: virtio: handle virtqueue_num_heads() errors... > Checking PATCH 15/19: virtio: handle virtqueue_get_head() errors... > Checking PATCH 16/19: hw/pci: Prepare for AMD IOMMU... > Checking PATCH 17/19: hw/i386/trace-events: Add AMD IOMMU trace events... > Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU... > ERROR: struct MemoryRegionIOMMUOps should normally be const > #1527: FILE: hw/i386/amd_iommu.h:280: > +MemoryRegionIOMMUOps iommu_ops; False positive. > > total: 1 errors, 0 warnings, 1495 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 19/19: hw/i386: AMD IOMMU IVRS table... > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-de...@freelists.org
Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1474658051-18617-1-git-send-email-...@redhat.com Subject: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc make J=8 docker-test-quick@centos6 make J=8 docker-test-mingw@fedora === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1474658051-18617-1-git-send-email-...@redhat.com -> patchew/1474658051-18617-1-git-send-email-...@redhat.com Switched to a new branch 'test' cacc4b0 hw/i386: AMD IOMMU IVRS table 9dd76e8 hw/i386: Introduce AMD IOMMU 51d6513 hw/i386/trace-events: Add AMD IOMMU trace events 2897b28 hw/pci: Prepare for AMD IOMMU 9ed4ac9 virtio: handle virtqueue_get_head() errors eba15c9 virtio: handle virtqueue_num_heads() errors 3c5513c virtio: handle virtqueue_read_next_desc() errors 3e2dd44 virtio: use unsigned int for virtqueue_get_avail_bytes() index b63060b virtio: handle virtqueue_get_avail_bytes() errors a7e238f virtio: handle virtqueue_map_desc() errors b1ee7b9 virtio: migrate vdev->broken flag 5ae212e virtio: stop virtqueue processing if device is broken 7add352 virtio: fix stray tab character a8b4e23 target-i386: turn off CPU.l3-cache only for 2.7 and older machine types eb0f9de pc: clean up COMPAT macro chaining f2df3c1 virtio: add check for descriptor's mapped address f2997b7 tests: add /vhost-user/flags-mismatch test b612c50 tests: add a simple /vhost-user/multiqueue test c38be03 tests: add /vhost-user/connect-fail test === OUTPUT BEGIN === Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' Cloning into 'dtc'... Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf' BUILD centos6 ARCHIVE qemu.tgz ARCHIVE dtc.tgz COPY RUNNER RUN test-quick in centos6 Configure options: --enable-werror --target-list=x86_64-softmmu,aarch64-softmmu --prefix=/tmp/qemu-test/src/tests/docker/install No C++ compiler available; disabling C++ specific optional code Install prefix/tmp/qemu-test/src/tests/docker/install BIOS directory/tmp/qemu-test/src/tests/docker/install/share/qemu binary directory /tmp/qemu-test/src/tests/docker/install/bin library directory /tmp/qemu-test/src/tests/docker/install/lib module directory /tmp/qemu-test/src/tests/docker/install/lib/qemu libexec directory /tmp/qemu-test/src/tests/docker/install/libexec include directory /tmp/qemu-test/src/tests/docker/install/include config directory /tmp/qemu-test/src/tests/docker/install/etc local state directory /tmp/qemu-test/src/tests/docker/install/var Manual directory /tmp/qemu-test/src/tests/docker/install/share/man ELF interp prefix /usr/gnemul/qemu-%M Source path /tmp/qemu-test/src C compilercc Host C compiler cc C++ compiler Objective-C compiler cc ARFLAGS rv CFLAGS-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -g QEMU_CFLAGS -I/usr/include/pixman-1-fPIE -DPIE -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-all LDFLAGS -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -pie -m64 -g make make install install pythonpython -B smbd /usr/sbin/smbd module supportno host CPU x86_64 host big endian no target list x86_64-softmmu aarch64-softmmu tcg debug enabled no gprof enabled no sparse enabledno strip binariesyes profiler no static build no pixmansystem SDL support yes (1.2.14) GTK support no GTK GL supportno VTE support no TLS priority NORMAL GNUTLS supportno GNUTLS rndno libgcrypt no libgcrypt kdf no nettleno nettle kdfno libtasn1 no curses supportno virgl support no curl support no mingw32 support no Audio drivers oss Block whitelist (rw) Block whitelist (ro) VirtFS supportno VNC support yes VNC SASL support no VNC JPEG support no VNC PNG support no xen support no brlapi supportno bluez supportno Documentation no PIE yes vde support no netmap supportno Linux AIO support no ATTR/XATTR support yes Install blobs yes KVM support yes RDMA support no TCG interpreter no fdt support yes preadv supportyes fdatasync yes madvise
Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1474658051-18617-1-git-send-email-...@redhat.com Subject: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' cacc4b0 hw/i386: AMD IOMMU IVRS table 9dd76e8 hw/i386: Introduce AMD IOMMU 51d6513 hw/i386/trace-events: Add AMD IOMMU trace events 2897b28 hw/pci: Prepare for AMD IOMMU 9ed4ac9 virtio: handle virtqueue_get_head() errors eba15c9 virtio: handle virtqueue_num_heads() errors 3c5513c virtio: handle virtqueue_read_next_desc() errors 3e2dd44 virtio: use unsigned int for virtqueue_get_avail_bytes() index b63060b virtio: handle virtqueue_get_avail_bytes() errors a7e238f virtio: handle virtqueue_map_desc() errors b1ee7b9 virtio: migrate vdev->broken flag 5ae212e virtio: stop virtqueue processing if device is broken 7add352 virtio: fix stray tab character a8b4e23 target-i386: turn off CPU.l3-cache only for 2.7 and older machine types eb0f9de pc: clean up COMPAT macro chaining f2df3c1 virtio: add check for descriptor's mapped address f2997b7 tests: add /vhost-user/flags-mismatch test b612c50 tests: add a simple /vhost-user/multiqueue test c38be03 tests: add /vhost-user/connect-fail test === OUTPUT BEGIN === Checking PATCH 1/19: tests: add /vhost-user/connect-fail test... Checking PATCH 2/19: tests: add a simple /vhost-user/multiqueue test... WARNING: line over 80 characters #192: FILE: tests/vhost-user-test.c:824: +cmd = g_strdup_printf(QEMU_CMD_MEM QEMU_CMD_CHR QEMU_CMD_NETDEV ",queues=%d " total: 0 errors, 1 warnings, 198 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/19: tests: add /vhost-user/flags-mismatch test... Checking PATCH 4/19: virtio: add check for descriptor's mapped address... Checking PATCH 5/19: pc: clean up COMPAT macro chaining... Checking PATCH 6/19: target-i386: turn off CPU.l3-cache only for 2.7 and older machine types... Checking PATCH 7/19: virtio: fix stray tab character... Checking PATCH 8/19: virtio: stop virtqueue processing if device is broken... Checking PATCH 9/19: virtio: migrate vdev->broken flag... Checking PATCH 10/19: virtio: handle virtqueue_map_desc() errors... Checking PATCH 11/19: virtio: handle virtqueue_get_avail_bytes() errors... Checking PATCH 12/19: virtio: use unsigned int for virtqueue_get_avail_bytes() index... Checking PATCH 13/19: virtio: handle virtqueue_read_next_desc() errors... Checking PATCH 14/19: virtio: handle virtqueue_num_heads() errors... Checking PATCH 15/19: virtio: handle virtqueue_get_head() errors... Checking PATCH 16/19: hw/pci: Prepare for AMD IOMMU... Checking PATCH 17/19: hw/i386/trace-events: Add AMD IOMMU trace events... Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU... ERROR: struct MemoryRegionIOMMUOps should normally be const #1527: FILE: hw/i386/amd_iommu.h:280: +MemoryRegionIOMMUOps iommu_ops; total: 1 errors, 0 warnings, 1495 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 19/19: hw/i386: AMD IOMMU IVRS table... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org
