Re: [Qemu-devel] [PULL 00/31] ppc patch queue 2013-01-07

2013-01-12 Thread Blue Swirl
On Mon, Jan 7, 2013 at 4:40 PM, Alexander Graf ag...@suse.de wrote:

 On 07.01.2013, at 17:21, Andreas Färber wrote:

 Am 07.01.2013 16:38, schrieb Alexander Graf:
 Hi Blue / Aurelien,

 This is my current patch queue for ppc.  Please pull.

 Breaks on x86_64:

  CCppc-softmmu/hw/ppc/e500.o
 /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c: In function
 ‘ppce500_load_device_tree’:
 /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: implicit
 declaration of function ‘kvmppc_get_hasidle’
 [-Werror=implicit-function-declaration]
 /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: nested extern
 declaration of ‘kvmppc_get_hasidle’ [-Werror=nested-externs]
 cc1: all warnings being treated as errors
 make[1]: *** [hw/ppc/e500.o] Fehler 1
 make: *** [subdir-ppc-softmmu] Fehler 2

 Lacking a static inline version of kvmppc_get_hasidle() in kvm_ppc.h.

 Sigh. I wonder why our buildbots didn't fetch this one.

 Fixed it up manually in both ppc-next and ppc-for-upstream, so the pull 
 request is still valid.

Thanks, pulled.



 Alex




Re: [Qemu-devel] [PULL 00/31] ppc patch queue 2013-01-07

2013-01-08 Thread Stefan Hajnoczi
On Mon, Jan 07, 2013 at 05:40:24PM +0100, Alexander Graf wrote:
 
 On 07.01.2013, at 17:21, Andreas Färber wrote:
 
  Am 07.01.2013 16:38, schrieb Alexander Graf:
  Hi Blue / Aurelien,
  
  This is my current patch queue for ppc.  Please pull.
  
  Breaks on x86_64:
  
   CCppc-softmmu/hw/ppc/e500.o
  /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c: In function
  ‘ppce500_load_device_tree’:
  /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: implicit
  declaration of function ‘kvmppc_get_hasidle’
  [-Werror=implicit-function-declaration]
  /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: nested extern
  declaration of ‘kvmppc_get_hasidle’ [-Werror=nested-externs]
  cc1: all warnings being treated as errors
  make[1]: *** [hw/ppc/e500.o] Fehler 1
  make: *** [subdir-ppc-softmmu] Fehler 2
  
  Lacking a static inline version of kvmppc_get_hasidle() in kvm_ppc.h.
 
 Sigh. I wonder why our buildbots didn't fetch this one.
 
 Fixed it up manually in both ppc-next and ppc-for-upstream, so the pull 
 request is still valid.

e500.o is only built when CONFIG_FDT is defined.

agraf: zypper search libfdt on qemu-ppc.opensuse.org turns up no
packages.  Any ideas where to get the packages from?

Stefan



Re: [Qemu-devel] [PULL 00/31] ppc patch queue 2013-01-07

2013-01-08 Thread Alexander Graf


Am 08.01.2013 um 09:54 schrieb Stefan Hajnoczi stefa...@redhat.com:

 On Mon, Jan 07, 2013 at 05:40:24PM +0100, Alexander Graf wrote:
 
 On 07.01.2013, at 17:21, Andreas Färber wrote:
 
 Am 07.01.2013 16:38, schrieb Alexander Graf:
 Hi Blue / Aurelien,
 
 This is my current patch queue for ppc.  Please pull.
 
 Breaks on x86_64:
 
 CCppc-softmmu/hw/ppc/e500.o
 /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c: In function
 ‘ppce500_load_device_tree’:
 /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: implicit
 declaration of function ‘kvmppc_get_hasidle’
 [-Werror=implicit-function-declaration]
 /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: nested extern
 declaration of ‘kvmppc_get_hasidle’ [-Werror=nested-externs]
 cc1: all warnings being treated as errors
 make[1]: *** [hw/ppc/e500.o] Fehler 1
 make: *** [subdir-ppc-softmmu] Fehler 2
 
 Lacking a static inline version of kvmppc_get_hasidle() in kvm_ppc.h.
 
 Sigh. I wonder why our buildbots didn't fetch this one.
 
 Fixed it up manually in both ppc-next and ppc-for-upstream, so the pull 
 request is still valid.
 
 e500.o is only built when CONFIG_FDT is defined.
 
 agraf: zypper search libfdt on qemu-ppc.opensuse.org turns up no
 packages.  Any ideas where to get the packages from?

I can install them on the ppc box, but the important build case would be 
against x86, no?

Alex

 
 Stefan



Re: [Qemu-devel] [PULL 00/31] ppc patch queue 2013-01-07

2013-01-08 Thread Richard Henderson
On 01/08/2013 12:54 AM, Stefan Hajnoczi wrote:
 agraf: zypper search libfdt on qemu-ppc.opensuse.org turns up no
 packages.  Any ideas where to get the packages from?

Fedora 17 ships them.  Either grab the packages from there, or
the rpm info points to 

URL : http://git.jdl.com/gitweb/?p=dtc.git;a=summary

as the upstream source.


r~



Re: [Qemu-devel] [PULL 00/31] ppc patch queue 2013-01-07

2013-01-07 Thread Andreas Färber
Am 07.01.2013 16:38, schrieb Alexander Graf:
 Hi Blue / Aurelien,
 
 This is my current patch queue for ppc.  Please pull.

Breaks on x86_64:

  CCppc-softmmu/hw/ppc/e500.o
/home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c: In function
‘ppce500_load_device_tree’:
/home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: implicit
declaration of function ‘kvmppc_get_hasidle’
[-Werror=implicit-function-declaration]
/home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: nested extern
declaration of ‘kvmppc_get_hasidle’ [-Werror=nested-externs]
cc1: all warnings being treated as errors
make[1]: *** [hw/ppc/e500.o] Fehler 1
make: *** [subdir-ppc-softmmu] Fehler 2

Lacking a static inline version of kvmppc_get_hasidle() in kvm_ppc.h.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



Re: [Qemu-devel] [PULL 00/31] ppc patch queue 2013-01-07

2013-01-07 Thread Alexander Graf

On 07.01.2013, at 17:21, Andreas Färber wrote:

 Am 07.01.2013 16:38, schrieb Alexander Graf:
 Hi Blue / Aurelien,
 
 This is my current patch queue for ppc.  Please pull.
 
 Breaks on x86_64:
 
  CCppc-softmmu/hw/ppc/e500.o
 /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c: In function
 ‘ppce500_load_device_tree’:
 /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: implicit
 declaration of function ‘kvmppc_get_hasidle’
 [-Werror=implicit-function-declaration]
 /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: nested extern
 declaration of ‘kvmppc_get_hasidle’ [-Werror=nested-externs]
 cc1: all warnings being treated as errors
 make[1]: *** [hw/ppc/e500.o] Fehler 1
 make: *** [subdir-ppc-softmmu] Fehler 2
 
 Lacking a static inline version of kvmppc_get_hasidle() in kvm_ppc.h.

Sigh. I wonder why our buildbots didn't fetch this one.

Fixed it up manually in both ppc-next and ppc-for-upstream, so the pull request 
is still valid.


Alex