Re: [Qemu-devel] [PULL 00/64] ppc-for-2.8 queue 20160907

[Paolo Bonzini]

On 14/09/2016 16:00, Alex Bennée wrote:
> For reference this has broken 32 bit x86 builds on CentOS6. I bisected
> the problem to:
> 
> commit 3654fa95bc29e72c2eef22f26eb621af1f86feec
> Author: Cédric Le Goater 
> Date:   Tue Aug 2 19:38:01 2016 +0200
> 
> hw/ppc: add a ppc_create_page_sizes_prop() helper routine
> 
> The exact same routine will be used in PowerNV.
> 
> Signed-off-by: Cédric Le Goater 
> Signed-off-by: David Gibson 
> 
> With:
> 
> 15:00 alex@centos6-x86/i686  [qemu.git/bisect:???] >make
>   CCppc-softmmu/hw/ppc/fdt.o
> In file included from /home/alex/lsrc/qemu.git/hw/ppc/fdt.c:14:
> /home/alex/lsrc/qemu.git/include/hw/ppc/fdt.h:15: error: redefinition of 
> typedef ‘CPUPPCState’
> /home/alex/lsrc/qemu.git/target-ppc/cpu-qom.h:41: note: previous 
> declaration of ‘CPUPPCState’ was here
> make[1]: *** [hw/ppc/fdt.o] Error 1
> make: *** [subdir-ppc-softmmu] Error 2
> 15:00 alex@centos6-x86/i686  [qemu.git/bisect:???] >

My pull request includes a fix.

Paolo

Re: [Qemu-devel] [PULL 00/64] ppc-for-2.8 queue 20160907

[Alex Bennée]

Peter Maydell  writes:

> On 7 September 2016 at 11:28, David Gibson  
> wrote:
>> The following changes since commit 2926375cffce464fde6b4dabaed1e133d549af39:
>>
>>   Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into 
>> staging (2016-09-06 17:18:17 +0100)
>>
>> are available in the git repository at:
>>
>>   git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20160907
>>
>> for you to fetch changes up to d2ab58ffc927c00e88f53f9b853b015a76fa1bd2:
>>
>>   tests: Check serial output of firmware boot of some machines (2016-09-07 
>> 12:40:13 +1000)
>>
>> 
>> ppc patch queue for 2016-Sep-7
>>
>> This is my first pull request for the newly opened qemu-2.8 tree.  It
>> contains a heap of things that were too late for 2.7 and have been
>> queued for a while.  In particular:
>> * A number of preliminary patches for the powernv machine type
>> * A substantial cleanup of exception handling which will be
>>   necessary to support running a TCG with hypervisor
>>   facilities
>> * A start on support for POWER9
>> * Some TCG implementations for new POWER9 instructions
>> * Some TCG and related cleanups in preparation for POWER9
>> * Some assorted TCG optimizations
>> * An implementation of the H_CHANGE_LOGICAL_LAN_MAC hypercall
>>   which allows the MAC address to be changed on the PAPR virtual
>>   NIC.
>> * Add some extra test cases for several machines (this isn't
>>   strictly in the ppc code, but is most value to ppc)
>>
>> NOTE: This pull request supersedes ppc-for-2.8-20160906, which had
>> some problems.  Changes:
>>   * Dropped BenH's lmw/stmw speedups, which break for
>> qemu-system-ppc64 on BE hosts
>>   * A small fix to Thomas' serial output test to avoid a warning on
>> the isapc machine type.
>>   * Some trivial checkpatch fixes
>>
>> Note that some of the patches in this series still have large numbers
>> of checkpatch warnings.  This is because they're moving existing code
>> that predates most of the checkpatch style conventions.
>>
>
> Applied, thanks.

For reference this has broken 32 bit x86 builds on CentOS6. I bisected
the problem to:

commit 3654fa95bc29e72c2eef22f26eb621af1f86feec
Author: Cédric Le Goater 
Date:   Tue Aug 2 19:38:01 2016 +0200

hw/ppc: add a ppc_create_page_sizes_prop() helper routine

The exact same routine will be used in PowerNV.

Signed-off-by: Cédric Le Goater 
Signed-off-by: David Gibson 

With:

15:00 alex@centos6-x86/i686  [qemu.git/bisect:???] >make
  CCppc-softmmu/hw/ppc/fdt.o
In file included from /home/alex/lsrc/qemu.git/hw/ppc/fdt.c:14:
/home/alex/lsrc/qemu.git/include/hw/ppc/fdt.h:15: error: redefinition of 
typedef ‘CPUPPCState’
/home/alex/lsrc/qemu.git/target-ppc/cpu-qom.h:41: note: previous 
declaration of ‘CPUPPCState’ was here
make[1]: *** [hw/ppc/fdt.o] Error 1
make: *** [subdir-ppc-softmmu] Error 2
15:00 alex@centos6-x86/i686  [qemu.git/bisect:???] >

--
Alex Bennée

Re: [Qemu-devel] [PULL 00/64] ppc-for-2.8 queue 20160907

[Peter Maydell]

On 7 September 2016 at 11:28, David Gibson  wrote:
> The following changes since commit 2926375cffce464fde6b4dabaed1e133d549af39:
>
>   Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging 
> (2016-09-06 17:18:17 +0100)
>
> are available in the git repository at:
>
>   git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20160907
>
> for you to fetch changes up to d2ab58ffc927c00e88f53f9b853b015a76fa1bd2:
>
>   tests: Check serial output of firmware boot of some machines (2016-09-07 
> 12:40:13 +1000)
>
> 
> ppc patch queue for 2016-Sep-7
>
> This is my first pull request for the newly opened qemu-2.8 tree.  It
> contains a heap of things that were too late for 2.7 and have been
> queued for a while.  In particular:
> * A number of preliminary patches for the powernv machine type
> * A substantial cleanup of exception handling which will be
>   necessary to support running a TCG with hypervisor
>   facilities
> * A start on support for POWER9
> * Some TCG implementations for new POWER9 instructions
> * Some TCG and related cleanups in preparation for POWER9
> * Some assorted TCG optimizations
> * An implementation of the H_CHANGE_LOGICAL_LAN_MAC hypercall
>   which allows the MAC address to be changed on the PAPR virtual
>   NIC.
> * Add some extra test cases for several machines (this isn't
>   strictly in the ppc code, but is most value to ppc)
>
> NOTE: This pull request supersedes ppc-for-2.8-20160906, which had
> some problems.  Changes:
>   * Dropped BenH's lmw/stmw speedups, which break for
> qemu-system-ppc64 on BE hosts
>   * A small fix to Thomas' serial output test to avoid a warning on
> the isapc machine type.
>   * Some trivial checkpatch fixes
>
> Note that some of the patches in this series still have large numbers
> of checkpatch warnings.  This is because they're moving existing code
> that predates most of the checkpatch style conventions.
>

Applied, thanks.

-- PMM

Re: [Qemu-devel] [PULL 00/64] ppc-for-2.8 queue 20160907

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 00/64] ppc-for-2.8 queue 20160907
Type: series
Message-id: 1473244183-31510-1-git-send-email-da...@gibson.dropbear.id.au

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] 
patchew/1473244183-31510-1-git-send-email-da...@gibson.dropbear.id.au -> 
patchew/1473244183-31510-1-git-send-email-da...@gibson.dropbear.id.au
Switched to a new branch 'test'
0993113 tests: Check serial output of firmware boot of some machines
2a0f4b3 tests: Resort check-qtest entries in Makefile.include
7763a71 spapr: implement H_CHANGE_LOGICAL_LAN_MAC h_call
a02f131 ppc: Improve a few more helper flags
3416ba2 ppc: Improve the exception helpers flags
459d354 ppc: Improve flags for helpers loading/writing the time facilities
4c1bf07 ppc: Don't generate dead code on unconditional branches
31cabe5 ppc: Stop dumping state on all exceptions in linux-user
85f5b4a ppc: Fix catching some segfaults in user mode
7ebad34 ppc: Fix macio ESCC legacy mapping
0f13a07 hw/ppc: add a ppc_create_page_sizes_prop() helper routine
33bcb68 hw/ppc: use error_report instead of fprintf
21c0c28 ppc: Rename #include'd .c files to .inc.c
1cc641d target-ppc: add extswsli[.] instruction
8a268ec target-ppc: add vsrv instruction
33788af target-ppc: add vslv instruction
1f2c5f5 target-ppc: add vcmpnez[b, h, w][.] instructions
a1f16c0 target-ppc: add vabsdu[b, h, w] instructions
2e07ac5 target-ppc: add dtstsfi[q] instructions
adbd532 target-ppc: implement branch-less divd[o][.]
fc4ccb8 target-ppc: implement branch-less divw[o][.]
080d4a2 ppc: load/store multiple and string insns don't do LE
861217b ppc: Use a helper to generate "LE unsupported" alignment interrupts
03fee41 ppc: Don't set access_type on all load/stores on hash64
e9aca2a ppc: Fix CFAR updates
b7d94da ppc: Speed up dcbz
9bc01f1 ppc: Handle unconditional (always/never) traps at translation time
05ce4d8 ppc: Make alignment exceptions suck less
5859133 ppc: Don't update NIP in dcbz and lscbx
f659f41 ppc: Don't update NIP if not taking alignment exceptions
5052bf5 ppc: Don't update NIP on conditional trap instructions
0cbc36c ppc: Don't update NIP BookE 2.06 tlbwe
c530c1c ppc: Don't update NIP in facility unavailable interrupts
24c42ee ppc: Don't update NIP in DCR access routines
8fcc2fb ppc: Fix source NIP on SLB related interrupts
3f8689a ppc: Make tlb_fill() use new exception helper
8d68e6d ppc: Don't update NIP in lmw/stmw/icbi
8cde0a2 ppc: Don't update NIP in lswi/lswx/stswi/stswx
019dd2e ppc: FP exceptions are always precise
2e6777f ppc: Don't update the NIP in floating point generated code
0ef26e1 ppc: Make float_check_status() pass the return address
ad6dcf9 ppc: Make float_invalid_op_excp() pass the return address
e1ea3f1 ppc: Rename fload_invalid_op_excp to float_invalid_op_excp
6c55b5b ppc: Move VSX ops out of translate.c
341b3ac ppc: Move VMX ops out of translate.c
e7e7ee2 ppc: Move DFP ops out of translate.c
30bf69f ppc: Move embedded spe ops out of translate.c
a831adc ppc: Move classic fp ops out of translate.c
2bdf95d ppc: Provide basic raise_exception_* functions
e399ebe target-ppc: introduce opc4 for Expanded Opcode
0baf7b3 target-ppc: add maddhd and maddhdu instruction
097ca99 target-ppc: add maddld instruction
0d6bece target-ppc: add setb instruction
8fa39ac target-ppc: add cmpeqb instruction
021e798 target-ppc: add cnttzw[.] instruction
b65f6b1 target-ppc: add cnttzd[.] instruction
996bc0d target-ppc: add modulo dword operations
f01ac41 target-ppc: add modulo word operations
b20a867 target-ppc: add cmprb instruction
cf46bbe target-ppc: adding addpcis instruction
feef19c target-ppc: Introduce POWER ISA 3.0 flag
0abdb7e target-ppc: Introduce Power9 family
dd3bc62 hw/ppc: include fdt helper routine in a common file
74ed4ce xics_kvm: drop extra checking of kernel_xics_fd

=== OUTPUT BEGIN ===
Checking PATCH 1/64: xics_kvm: drop extra checking of kernel_xics_fd...
Checking PATCH 2/64: hw/ppc: include fdt helper routine in a common file...
Checking PATCH 3/64: target-ppc: Introduce Power9 family...
Checking PATCH 4/64: target-ppc: Introduce POWER ISA 3.0 flag...
Checking PATCH 5/64: target-ppc: adding addpcis instruction...
Checking PATCH 6/64: target-ppc: add cmprb instruction...
Checking PATCH 7/64: target-ppc: add modulo word operations...
Checking PATCH 8/64: target-ppc: add