Re: [Qemu-devel] [PULL v2 46/49] qdev: Add enum property types to QAPI schema

2014-02-18 Thread Paolo Bonzini 

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Il 17/02/2014 23:30, Eric Blake ha scritto:
| Oops - we lost the ## header before add_client.  Sounds like a
| followup patch might be called for, unless you are okay tweaking
| the pull request.

Yeah, I can do that with qemu-trivial.

Paolo
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTAxRgAAoJEBvWZb6bTYby+0kP/jo/84UmFlN6zJssfed++kkm
tffNBa2Aom2oWiPiUv80J8sstiL7QRI44szHrnj9IVew8q/iSuIjHKQSvG9NvdE+
zEB1XKqcm4dlXOpVZ+Jq4w9g2K7BLmtoEJY75oZEE/u8731EI1IMVqmzGJ1dBYsh
/XDS9drIsHfZvDNcqTtRdY7ZhFP4QZo/UrDcX4vHx8ak6QcGWllfTn8sUGmkV3rS
p643v54WCwE+ZhTtfWEHwhTU7c0tUZzr+UxGXZ6bumJ7CXCdgeZltYkqxUc/qOlb
Fg9HEZiFaDxGDtI2IzJu4G2Y67j7twM8h/USSkx1lUqaQNQ2wC7nLDZ3GsnkY8XY
450DfVKfBAN7bAFf8jVT+h2D/AgfX1qYsKrozgOGppxQRmIhU0QlPFm/1/V9paCX
0Nje6oG+89XMUl3KKstyXzKiKGQSnETu2iyVMpeLcQyDUZWdst0c7yh4yME3giIH
sS8354qcdOs2VYE02z7ceRU7M3vwv6sfuGyrN15oeFI/x42CTCseH2B8Unvn815F
Da/hHNqNy58PTgVbMybz/sxYRBKBl8euTvQuxjLyg+2SvOJUtvK040lRuVk9YwTO
Q0RmnVU5bXkO8A27l34zccnekLAbIJVgJKLVzB9tpGdONNLsUuXXwgtfP2Kw+IVI
I0fyhNi64xs6LCER/QI6
=FzxL
-END PGP SIGNATURE-

Re: [Qemu-devel] [PULL v2 46/49] qdev: Add enum property types to QAPI schema

2014-02-17 Thread Eric Blake 
On 02/17/2014 03:24 PM, Andreas Färber wrote:
> From: Paolo Bonzini 
> 
> Reviewed-by: Igor Mammedov 
> Reviewed-by: Eric Blake 
> Signed-off-by: Paolo Bonzini 
> Signed-off-by: Andreas Färber 
> ---

> +++ b/qapi-schema.json
> @@ -28,7 +28,65 @@
>'data': [ 'GenericError', 'CommandNotFound', 'DeviceEncrypted',
>  'DeviceNotActive', 'DeviceNotFound', 'KVMMissingCap' ] }
>  
> +
> +##
> +# LostTickPolicy:

...

> +
>  ##
> +# BiosAtaTranslation:
> +#

...

> +
>  # @add_client

Oops - we lost the ## header before add_client.  Sounds like a followup
patch might be called for, unless you are okay tweaking the pull request.

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature