On 10/11/2017 02:24 PM, Peter Maydell wrote: > Coverity points out that we forgot the 'break' for > the SAU_CTRL write case (CID1381683). This has > no actual visible consequences because it happens > that the following case is effectively a no-op. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > hw/intc/armv7m_nvic.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c > index 201e90f..be46639 100644 > --- a/hw/intc/armv7m_nvic.c > +++ b/hw/intc/armv7m_nvic.c > @@ -1447,6 +1447,7 @@ static void nvic_writel(NVICState *s, uint32_t offset, > uint32_t value, > return; > } > cpu->env.sau.ctrl = value & 3; > + break; > case 0xdd4: /* SAU_TYPE */ > if (!arm_feature(&cpu->env, ARM_FEATURE_V8)) { > goto bad_offset; >