Re: [Qemu-devel] [RESEND PATCH] ioapic: fix build with DEBUG_IOAPIC

2012-03-18 Thread Jason Wang 

On 03/16/2012 06:32 PM, Andreas Färber wrote:

Am 16.03.2012 10:10, schrieb Jason Wang:

ioapic.c:198: error: format ‘%08x’ expects type ‘unsigned int’, but argument 3 
has type ‘uint64_t’

Signed-off-by: Jason Wangjasow...@redhat.com

PRIx64 is indeed needed here. However, this drops the 08 without mention
in the commit message - was it intended?


Not intended, my fault, thanks for pointing this.

Andreas


---
  hw/ioapic.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/ioapic.c b/hw/ioapic.c
index 3fee011..1ff31a1 100644
--- a/hw/ioapic.c
+++ b/hw/ioapic.c
@@ -195,7 +195,7 @@ ioapic_mem_write(void *opaque, target_phys_addr_t addr, 
uint64_t val,
  if (size != 4) {
  break;
  }
-DPRINTF(write: %08x = %08x\n, s-ioregsel, val);
+DPRINTF(write: %08x = % PRIx64 \n, s-ioregsel, val);
  switch (s-ioregsel) {
  case IOAPIC_REG_ID:
  s-id = (val  IOAPIC_ID_SHIFT)  IOAPIC_ID_MASK;

Re: [Qemu-devel] [RESEND PATCH] ioapic: fix build with DEBUG_IOAPIC

2012-03-16 Thread Andreas Färber 
Am 16.03.2012 10:10, schrieb Jason Wang:
 ioapic.c:198: error: format ‘%08x’ expects type ‘unsigned int’, but argument 
 3 has type ‘uint64_t’
 
 Signed-off-by: Jason Wang jasow...@redhat.com

PRIx64 is indeed needed here. However, this drops the 08 without mention
in the commit message - was it intended?

Andreas

 ---
  hw/ioapic.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/hw/ioapic.c b/hw/ioapic.c
 index 3fee011..1ff31a1 100644
 --- a/hw/ioapic.c
 +++ b/hw/ioapic.c
 @@ -195,7 +195,7 @@ ioapic_mem_write(void *opaque, target_phys_addr_t addr, 
 uint64_t val,
  if (size != 4) {
  break;
  }
 -DPRINTF(write: %08x = %08x\n, s-ioregsel, val);
 +DPRINTF(write: %08x = % PRIx64 \n, s-ioregsel, val);
  switch (s-ioregsel) {
  case IOAPIC_REG_ID:
  s-id = (val  IOAPIC_ID_SHIFT)  IOAPIC_ID_MASK;

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg