Re: [Qemu-devel] FYI: Need to a make clean due to recently pushed commit

2011-10-15 Thread Blue Swirl
On Mon, Oct 10, 2011 at 2:49 PM, Anthony Liguori  wrote:
> Due to:
>
>  commit e3193601c84558c303b1773379da76fce80c0a56
>  Author: Anthony Liguori 
>  Date:   Fri Sep 2 12:34:47 2011 -0500
>
>     qapi: use middle mode in QMP server
>
> It'll be necessary to do a make clean if you have a tree that has a build
> from before this commit.
>
> If you get compile errors about "qmp-commands-old.h" or "qmp-commands.h",
> this is most likely your problem.

This is most unfortunate, it will make bisection across that point
slower for all future generations, forever. What is the root cause,
reusing a file name which was previously generated, removed and then
at some point became non-generated? How can we avoid this in the
future, would it help for example to ban such behavior, requiring that
when removing or renaming files, the obsolete names must be added to
.gitignore or checkpatch.pl?



Re: [Qemu-devel] FYI: Need to a make clean due to recently pushed commit

2011-10-11 Thread Andreas Färber

Am 10.10.2011 16:49, schrieb Anthony Liguori:

Due to:

commit e3193601c84558c303b1773379da76fce80c0a56
Author: Anthony Liguori 
Date: Fri Sep 2 12:34:47 2011 -0500

qapi: use middle mode in QMP server

It'll be necessary to do a make clean if you have a tree that has a
build from before this commit.

If you get compile errors about "qmp-commands-old.h" or
"qmp-commands.h", this is most likely your problem.


`make clean` wasn't sufficient here, `make distclean` worked.

Andreas

--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746, AG Nürnberg