Re: ui: fix potential compile error.

2020-09-02 Thread Thomas Huth 
On 02/09/2020 10.17, Daniel P. Berrangé wrote:
> On Wed, Sep 02, 2020 at 07:23:13AM +0200, kra...@redhat.com wrote:
>>   Hi,
>>
>>> 1. CentOS7 with Python 2.7.5
>>
>>> Root cause is my argparse and python version. But change the invoking order 
>>> can adapt both new and old argparse.
>>
>> python2 is EOL and not supported any more.
>> please "yum install python3" (yes, centos7 has it, was added in 7.8).
> 
> Hmm, I'm surpised the build even got this far.  configure should be checking
> python version and refusing to run with python2 at all before even starting
> the build process.

There is a check for python >= in the configure script. 潘睿, did the
"configure" script allow you to run with Python 2.7 ?

 Thomas

Re: ui: fix potential compile error.

2020-09-02 Thread Daniel P . Berrangé 
On Wed, Sep 02, 2020 at 07:23:13AM +0200, kra...@redhat.com wrote:
>   Hi,
> 
> > 1. CentOS7 with Python 2.7.5
> 
> > Root cause is my argparse and python version. But change the invoking order 
> > can adapt both new and old argparse.
> 
> python2 is EOL and not supported any more.
> please "yum install python3" (yes, centos7 has it, was added in 7.8).

Hmm, I'm surpised the build even got this far.  configure should be checking
python version and refusing to run with python2 at all before even starting
the build process.

Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: ui: fix potential compile error.

2020-09-01 Thread kra...@redhat.com 
  Hi,

> 1. CentOS7 with Python 2.7.5

> Root cause is my argparse and python version. But change the invoking order 
> can adapt both new and old argparse.

python2 is EOL and not supported any more.
please "yum install python3" (yes, centos7 has it, was added in 7.8).

take care,
  Gerd

ui: fix potential compile error.

2020-09-01 Thread 潘睿 
We compiled the upstream qemu and result in this GEN code error:

‘’’
GEN ui/input-keymap-atset1-to-qcode.c
usage: keymap-gen [-h]
  {code-map,code-table,name-map,name-table,code-docs,name-docs}
  ...
keymap-gen: error: invalid choice: 'glib2' (choose from 'code-map', 
'code-table', 'name-map', 'name-table', 'code-docs', 'name-docs')
‘’’

My environment:

1. CentOS7 with Python 2.7.5

2. upstream's keycodemapdb

3. argparse 1.1

Root cause is my argparse and python version. But change the invoking order can 
adapt both new and old argparse.

Thanks.


0001-ui-fix-potential-compile-error.patch
Description: 0001-ui-fix-potential-compile-error.patch