Re: [Qgis-developer] update pull request
Hi, I do not know either what I good practice, but now that a new commit has been done on the branched 1_7_0 I have now idea how to propagate this in the pull request. I would have created a new personal repository forking the main one and started from zero, but since it is not possible to download a single branch, downloading all takes hours for me, so their might be another commit in the mean time... this way I will never catch up. So for the moment the easy way I found was to post a new patch here: http://trac.osgeo.org/qgis/attachment/ticket/3222/ (@Tim: it now uses relative paths) Patch on freshly branched 1_7_0 https://github.com/qgis/Quantum-GIS/commit/6c835b4cf5cd4a4be687e829bb57e3d51e7345f7 taking into accounts jef's comments at https://github.com/qgis/Quantum-GIS/pull/3 Would it be fine for you to work with this? I wish also to thank you for the hints you already gave me for improving my code. All the best, Mayeul Le vendredi 06 mai 2011 à 23:03 +0200, Mayeul Kauffmann a écrit : Hi Jürgen, Thanks a lot for the detailed answer!! Sorry to have bothered you; I agree standardizing indentation can be useful [in fact, it does not make merging more difficult but easier: if indentation is standardized before each commit, nobody will never ever have to merge indentation]. But it's to late for that in your case anyway, as you've already committed. I would have forked the new 1_7_0 again, applied my patch here, taken into account your comment, run the indentation tool, committed, pushed, and made another pull request. Then I would have deleted my other fork (is this good practice?) I will now work on your comments. Regards, Mayeul ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] update pull request
On Sat, May 07, 2011 at 12:40:18PM +0200, Mayeul Kauffmann wrote: I would have created a new personal repository forking the main one and started from zero, but since it is not possible to download a single branch, downloading all takes hours for me, so their might be another commit in the mean time... this way I will never catch up. There's no problem importing changes from upstream, git pull merges them in. Optionally the --rebase switch acts like if you created patches for your changes, updated the repository to upstream, and re-applied those patches. --strk; () Free GIS Flash consultant/developer /\ http://strk.keybit.net/services.html ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Re: something went terribly wrong with reprojected rasters in the last 72 hours
On Sat, 2011-05-07 at 12:31 +0700, Mathieu Pellerin wrote: Radim, Any chance you can apply this quick fix to a 1.7 build prior to final release? by the way the patch seems to work fine. cheers -- Giovanni -- ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Re: something went terribly wrong with reprojected rasters in the last 72 hours
I've committed Radims patch both to master and to the release branch: commit:a87cb60 Regards Tim On Sat, May 7, 2011 at 3:46 PM, Giovanni Manghi giovanni.man...@gmail.com wrote: On Sat, 2011-05-07 at 12:31 +0700, Mathieu Pellerin wrote: Radim, Any chance you can apply this quick fix to a 1.7 build prior to final release? by the way the patch seems to work fine. cheers -- Giovanni -- ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer -- Tim Sutton - QGIS Project Steering Committee Member (Release Manager) == Please do not email me off-list with technical support questions. Using the lists will gain more exposure for your issues and the knowledge surrounding your issue will be shared with all. Visit http://linfiniti.com to find out about: * QGIS programming and support services * Mapserver and PostGIS based hosting plans * FOSS Consulting Services Skype: timlinux Irc: timlinux on #qgis at freenode.net == ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] update pull request
Hi, Thanks all for your hints. Still, I could not find a way to make those changes on existing branch and on the pull request #3, so I forked again and added a new pull request: https://github.com/qgis/Quantum-GIS/pull/7 In the meantime, there was a new commit in the 1_7_0 branch. (Yes, I know, it is simple to solve this but sorry, no, I'm not smart enough yet...). Sorry for those probably bad practices... Mayeul Le samedi 07 mai 2011 à 15:29 +0200, Sandro Santilli a écrit : On Sat, May 07, 2011 at 12:40:18PM +0200, Mayeul Kauffmann wrote: I would have created a new personal repository forking the main one and started from zero, but since it is not possible to download a single branch, downloading all takes hours for me, so their might be another commit in the mean time... this way I will never catch up. There's no problem importing changes from upstream, git pull merges them in. Optionally the --rebase switch acts like if you created patches for your changes, updated the repository to upstream, and re-applied those patches. --strk; () Free GIS Flash consultant/developer /\ http://strk.keybit.net/services.html ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Git repo available for testing
Is this git thing on? Questions and confusion. Is there a git guide for dummies? I found http://www.qgis.org/wiki/Using_Git but it seems overly complex. I just want to do like I've done with svn - check out/update, make changes, and commit the changes. 3 steps. Git checkout itself looks complex, let alone committing a change. ...Sorry if I seem a bit resistant. Are users migrated to git? Or do I need to register with github and ask for commit access? How long until 1.7 release? I would like to do the workaround for http://trac.osgeo.org/qgis/ticket/3497 before release, and check over the Mac install/build instructions. On May 2, 2011, at 10:16 AM, Tim Sutton wrote: If you are interested in the git migration, you can test and play around with it here: http://github.com/qgis/Quantum-GIS You can go ahead and fork it and see if everything works ok for you. If we encounter any major issues, we may need to trash and repopulate it so please don't consider it production ready yet. I made detailed notes on the migration for anyone interested here: http://linfiniti.com/2011/05/some-notes-on-the-great-migration-qgis-svn-to-git/ If any git experts notice anything untoward with my procedures please feel free to suggest better working practices. I'll give it a couple of days and if nobody has any major issues, we can start to use that as our canonical repository. Next we will start to work on the trac - redmine migration (and svn commitlog - git commitlog in redmine). If anyone has particular expertise in these (especially the latter), please feel free to volunteer your services. The other directories (code examples etc under svn trunk) I will migrate after the release has gone out. Regards Tim -- Tim Sutton - QGIS Project Steering Committee Member (Release Manager) == Please do not email me off-list with technical support questions. Using the lists will gain more exposure for your issues and the knowledge surrounding your issue will be shared with all. Visit http://linfiniti.com to find out about: * QGIS programming and support services * Mapserver and PostGIS based hosting plans * FOSS Consulting Services Skype: timlinux Irc: timlinux on #qgis at freenode.net == ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer - William Kyngesburye kyngchaos*at*kyngchaos*dot*com http://www.kyngchaos.com/ The beast is actively interested only in now, and, as it is always now and always shall be, there is an eternity of time for the accomplishment of objects. - the wisdom of Tarzan ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Git repo available for testing
Le 07/05/2011 18:31, William Kyngesburye a écrit : Is this git thing on? Questions and confusion. Is there a git guide for dummies? I found http://www.qgis.org/wiki/Using_Git but it seems overly complex. I just want to do like I've done with svn - check out/update, make changes, and commit the changes. 3 steps. Git checkout itself looks complex, let alone committing a change. ...Sorry if I seem a bit resistant. Have a look at the help - http://help.github.com/ Here is a nice cheatsheet - http://ktown.kde.org/~zrusin/git/git-cheat-sheet-medium.png Are users migrated to git? Or do I need to register with github and ask for commit access? You need to register to github but you don't need to ask for commit access : the best way of enjoying git is to make your own fork the trunk, work on it and then push the changes back. It is still possible to have one repo with everybody writing directly to it but, Tim will correct me, that's not the choice made at the hackfest. How long until 1.7 release? I would like to do the workaround for http://trac.osgeo.org/qgis/ticket/3497 before release, and check over the Mac install/build instructions. On May 2, 2011, at 10:16 AM, Tim Sutton wrote: If you are interested in the git migration, you can test and play around with it here: http://github.com/qgis/Quantum-GIS You can go ahead and fork it and see if everything works ok for you. If we encounter any major issues, we may need to trash and repopulate it so please don't consider it production ready yet. I made detailed notes on the migration for anyone interested here: http://linfiniti.com/2011/05/some-notes-on-the-great-migration-qgis-svn-to-git/ If any git experts notice anything untoward with my procedures please feel free to suggest better working practices. I'll give it a couple of days and if nobody has any major issues, we can start to use that as our canonical repository. Next we will start to work on the trac - redmine migration (and svn commitlog - git commitlog in redmine). If anyone has particular expertise in these (especially the latter), please feel free to volunteer your services. The other directories (code examples etc under svn trunk) I will migrate after the release has gone out. Regards Tim -- Tim Sutton - QGIS Project Steering Committee Member (Release Manager) == Please do not email me off-list with technical support questions. Using the lists will gain more exposure for your issues and the knowledge surrounding your issue will be shared with all. Visit http://linfiniti.com to find out about: * QGIS programming and support services * Mapserver and PostGIS based hosting plans * FOSS Consulting Services Skype: timlinux Irc: timlinux on #qgis at freenode.net == ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer - William Kyngesburyekyngchaos*at*kyngchaos*dot*com http://www.kyngchaos.com/ The beast is actively interested only in now, and, as it is always now and always shall be, there is an eternity of time for the accomplishment of objects. - the wisdom of Tarzan ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Git repo available for testing
Is ad494d4 before or after a87cb60? Is there a plan to add some sequential number to nightly builds QGIS/About? Right now the only indicator of freshness of the nightly build is suffix of the package which most of the users don't pay attention to while installig/updating. Maxim ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] update pull request
Hi, Thanks a lot Tim for the detailed commands! Will be useful for next time. While searching for documentation, I found several very good diagrams (including the one on the qgis wiki): http://osteele.com/archives/2008/05/commit-policies http://blog.interlinked.org/tutorials/git.html http://www.google.com/search?q=site:book.git-scm.comum=1ie=UTF-8tbm=isch from http://book.git-scm.com/ The most detailed graphic cheat sheet I found is here: http://panela.blog-city.com/update_of_git_supervisual_cheatsheet.htm But on the project page you find an even more detailed svg a python script (I could not make it work, though, even after sudo easy_install pysvg) I have added the first two of those here: http://www.qgis.org/wiki/Using_Git By the way, I also corrected the code formatting for braces in the, er..., editing section of the good formatting example at: http://www.qgis.org/wiki/Developers_Manual#Editing (should we run astyle on code extracts in the wiki? ;-) ) Hope this helps, Mayeul Le samedi 07 mai 2011 à 18:28 +0200, Tim Sutton a écrit : Hi On Sat, May 7, 2011 at 6:03 PM, Mayeul Kauffmann mayeul.kauffm...@free.fr wrote: Hi, Thanks all for your hints. Still, I could not find a way to make those changes on existing branch and on the pull request #3, so I forked again and added a new pull request: Ok no need to refork, you can just do (in your local repo): git remote add qgis-upstream git://github.com/qgis/Quantum-GIS.git git fetch qgis-upstream git branch --track release-1_7_0 origin/release-1_7_0 git checkout release-1_7_0 git pull qgis-upstream release-1_7_0 git push origin release-1_7_0 That will pull any changes from qgis repo and push them up to your clone of it. Obviously you need to commit any fixes you made in response to the comments and push those too. Then just issue a new pull request and cancel the old one. I will write up some working practice docs in CODING soon I promise :-) Regards Tim https://github.com/qgis/Quantum-GIS/pull/7 In the meantime, there was a new commit in the 1_7_0 branch. (Yes, I know, it is simple to solve this but sorry, no, I'm not smart enough yet...). Sorry for those probably bad practices... Mayeul Le samedi 07 mai 2011 à 15:29 +0200, Sandro Santilli a écrit : On Sat, May 07, 2011 at 12:40:18PM +0200, Mayeul Kauffmann wrote: I would have created a new personal repository forking the main one and started from zero, but since it is not possible to download a single branch, downloading all takes hours for me, so their might be another commit in the mean time... this way I will never catch up. There's no problem importing changes from upstream, git pull merges them in. Optionally the --rebase switch acts like if you created patches for your changes, updated the repository to upstream, and re-applied those patches. --strk; () Free GIS Flash consultant/developer /\ http://strk.keybit.net/services.html ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Git repo available for testing
Hi, I like versioning systems so learning a new one is interesting. The paradoxal point with this github is as follows: (+) One of the idea is to let non-core developers contribute (make commits... in their branch only) in an easy way. I love the github tool that shows you which branch will merge easily with yours... (well, I love it when it's green). That's great. (-) Less experienced developers are not allowed to commit to the trunk because... they are less experienced; that's OK. But in the meantime, IMHO they are required to have a better understanding of git than what is required to commit directly to the main repository. Still, probably the (+) is bigger than the (-). I saw the same doubts in teams migrating from cvs to svn, and none of them wish to go back. Just my 2 cents. Mayeul Le samedi 07 mai 2011 à 11:31 -0500, William Kyngesburye a écrit : Is this git thing on? Questions and confusion. Is there a git guide for dummies? I found http://www.qgis.org/wiki/Using_Git but it seems overly complex. I just want to do like I've done with svn - check out/update, make changes, and commit the changes. 3 steps. Git checkout itself looks complex, let alone committing a change. ...Sorry if I seem a bit resistant. Are users migrated to git? Or do I need to register with github and ask for commit access? How long until 1.7 release? I would like to do the workaround for http://trac.osgeo.org/qgis/ticket/3497 before release, and check over the Mac install/build instructions. On May 2, 2011, at 10:16 AM, Tim Sutton wrote: If you are interested in the git migration, you can test and play around with it here: http://github.com/qgis/Quantum-GIS You can go ahead and fork it and see if everything works ok for you. If we encounter any major issues, we may need to trash and repopulate it so please don't consider it production ready yet. I made detailed notes on the migration for anyone interested here: http://linfiniti.com/2011/05/some-notes-on-the-great-migration-qgis-svn-to-git/ If any git experts notice anything untoward with my procedures please feel free to suggest better working practices. I'll give it a couple of days and if nobody has any major issues, we can start to use that as our canonical repository. Next we will start to work on the trac - redmine migration (and svn commitlog - git commitlog in redmine). If anyone has particular expertise in these (especially the latter), please feel free to volunteer your services. The other directories (code examples etc under svn trunk) I will migrate after the release has gone out. Regards Tim -- Tim Sutton - QGIS Project Steering Committee Member (Release Manager) == Please do not email me off-list with technical support questions. Using the lists will gain more exposure for your issues and the knowledge surrounding your issue will be shared with all. Visit http://linfiniti.com to find out about: * QGIS programming and support services * Mapserver and PostGIS based hosting plans * FOSS Consulting Services Skype: timlinux Irc: timlinux on #qgis at freenode.net == ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer - William Kyngesburye kyngchaos*at*kyngchaos*dot*com http://www.kyngchaos.com/ The beast is actively interested only in now, and, as it is always now and always shall be, there is an eternity of time for the accomplishment of objects. - the wisdom of Tarzan ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] update pull request
On Sat, May 7, 2011 at 9:28 AM, Tim Sutton li...@linfiniti.com wrote: Hi On Sat, May 7, 2011 at 6:03 PM, Mayeul Kauffmann mayeul.kauffm...@free.fr wrote: Hi, Thanks all for your hints. Still, I could not find a way to make those changes on existing branch and on the pull request #3, so I forked again and added a new pull request: Ok no need to refork, you can just do (in your local repo): git remote add qgis-upstream git://github.com/qgis/Quantum-GIS.git git fetch qgis-upstream git branch --track release-1_7_0 origin/release-1_7_0 git checkout release-1_7_0 git pull qgis-upstream release-1_7_0 git push origin release-1_7_0 That will pull any changes from qgis repo and push them up to your clone of it. Obviously you need to commit any fixes you made in response to the comments and push those too. Then just issue a new pull request and cancel the old one. I will write up some working practice docs in CODING soon I promise :-) Regards Tim Although it is *strongly* recommended to create a separate branch for each feature. For example, if you only use a release-1_7_0 branch: git branch --track release-1_7_0 origin/release-1_7_0 And work on two features, x and y you will have a problem when opening pull requests from that branch: The pull request for feature x will contain all commits for feature y and vice versa. A better method would be: git checkout -b feature/x --track origin/release-1_7_0 git checkout -b feature/y --track origin/realease-1_7_0 That sets up both branches so that `git pull` will bring in upstream changes, yet changes made by `git commit` are segregated. Pull requests opened from `feature/x` will only contain commits related to x. ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] update pull request
On Sat, May 7, 2011 at 10:55 AM, Charlie Sharpsteen ch...@sharpsteen.netwrote: A better method would be: git checkout -b feature/x --track origin/release-1_7_0 git checkout -b feature/y --track origin/realease-1_7_0 Err, sorry---if you were following Tim's instructions, that should be: git checkout -b feature/x --track qgis-upstream/release-1_7_0 git checkout -b feature/x --track qgis-upstream/release-1_7_0 ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
