Re: [QGIS-Developer] Enable github actions in QGIS-Training-Data repository

2021-10-18 Thread Richard Duivenvoorde 
Hi Harrissou,

You're admin now, if I thicked the right boxes... :-)

Regards,

Richard Duivenvoorde

On 10/19/21 12:19 AM, Delaz J wrote:
> I meant https://github.com/qgis/QGIS-Training-Data repository of course
> 
> Le 18/10/2021 à 23:18, Delaz J a écrit :
>> Hi Devs,
>>
>> Can someone with admin rights in the https://qgis/QGIS-Training-Data 
>> repository either enables github actions in the repo or provide me with 
>> enough access to do so, please? I'd like to add (at least) the backport bot.
>>
>> Thanks.
>>
>> Harrissou
>>
> ___
> QGIS-Developer mailing list
> QGIS-Developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Crash in QgsAppication.initQgis()

2021-10-18 Thread Asim 

On 8/20/21 6:38 PM, Asim wrote:
The stack trace indicates QgsProject failed to get created because 
sqlite3_create_function_v2() tried to de-reference a NULL pointer.  
Full stack trace is attached.  Is this something MacOS specific?



Apparently, the libsqlite3 installed natively in MacOS is different from 
libsqlite3 that is bundled within QGIS.  The workaround is to set 
DYLD_INSERT_LIBRARIES environment variable to the libsqlite3.dylib 
library within QGIS installation. More details can be found in 
https://github.com/qgis/QGIS/issues/40378


Asim


___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Enable github actions in QGIS-Training-Data repository

2021-10-18 Thread Delaz J 

I meant https://github.com/qgis/QGIS-Training-Data repository of course

Le 18/10/2021 à 23:18, Delaz J a écrit :

Hi Devs,

Can someone with admin rights in the https://qgis/QGIS-Training-Data 
repository either enables github actions in the repo or provide me 
with enough access to do so, please? I'd like to add (at least) the 
backport bot.


Thanks.

Harrissou


___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

[QGIS-Developer] Enable github actions in QGIS-Training-Data repository

2021-10-18 Thread Delaz J 

Hi Devs,

Can someone with admin rights in the https://qgis/QGIS-Training-Data 
repository either enables github actions in the repo or provide me with 
enough access to do so, please? I'd like to add (at least) the backport bot.


Thanks.

Harrissou

___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

[QGIS-Developer] Empty vs. Null rectangle, bogus ?

2021-10-18 Thread Sandro Santilli 
Still chasing bug
QgsVectorLayerFeatureIterator::QgsVectorLayerFeatureIterator
I reached QgsRectangle, whose "Null" or "Empty" nature changes
behavior of QgsFeatureVectorFeatureIterator in a way that prevents
proper WithinDistance filter from working.

Details are written in
https://github.com/qgis/QGIS/issues/45352
but what I wanted to ask here is:

According to the comments Empty means that some information is still
available (bounding box of a point) but the unit test for QgsRectangle
(and the isEmpty method implementation) seem to check for Max < Min,
which would NOT be the case for the bounding box of a point,
so is puzzling.

I'm not sure how to proceed for fixing the bug I'm seeing because
one simple fix would be avoiding to call setRectangle on a QgsRequest
if the iterator's mFilterRect is Empty, but a more complex solution
could be to *allow* those QgsRequests to have multiple filters, rather
than one excluding the other.

Also I've yet to understand WHY at construction time a
QgsAbstractFeatureIterator shoul dhave an Empty rather than Null
rectangle, which brings back to the first question (is the distinction
really defined?).

--strk; 

  Libre GIS consultant/developer
  https://strk.kbt.io/services.html
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] QgsFeatureSource::getFeatures - why returning Iterator by value instead of pointer ?

2021-10-18 Thread Sandro Santilli 
On Sun, Oct 17, 2021 at 09:13:10PM +0200, Martin Dobias wrote:
> Hi Sandro
> 
> On Fri, Oct 15, 2021 at 5:32 PM Sandro Santilli  wrote:
> 
> > My question is: why is a QgsFeatureIterator being constructed here,
> > just for returning it as a value ?
> 
> If I remember correctly, that's mainly for convenience in the client code,
> no need to deal with raw pointers that need to be deleted afterwards.
> QgsFeatureIterator also adds implicit sharing, just like many other Qt
> classes do (e.g. QString).
> 
> > Why not returning a pointer
> > instead, to allow subclasses to return whatever derived class they want ?
> 
> Well, in that code snippet we are already in a subclass that returns the
> derived class as wanted, so I am not sure if I understand your concern...

My problem is that I'm debug-printing properties of the
QgsFeatureRequest as passed to QgsFeatureProvider::getFeatures
and while the value passed to it has one kind of SpatialFilter
the value seen by QgsPostgresFeatureIterator (subclass of
QgsAbstractFeatureIterator) has a *different* SpatialFilter:

   request 0x7fe2f27fa4e0 for target source someData has spatialFilterType 2
  XXX QgsFeatureRequest::setFilterRect called on request 0x7fe2d40129a8 having 
spatialFilterType == 2
  XXX QgsPostgresFeatureSource::getFeatures called, request 0x7fe2d4012b18 has 
spatialFilterType 1

I'm printing the *pointer* value to try at following *when* things are
changing but as you see the pointer value keeps changing due to
copies...

Anyway, I'll fire a debugger and break on QgsFeatureRequest::setFilterRect,
which might be the problem here.

--strk;
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

[QGIS-Developer] Compile qGis

2021-10-18 Thread Abhishek Kumar Rana 
Dear Devs,
I tried to compile qGis for Windows . I have Successfully created a
Solution file for Visual studio ( Community version 2015 ) .When I opened
the Solution file  after that I found so many errors in the code. Please
give me a better solution to successfully compile qGis.

Cheers
Abhishek Rana

-- 
Leading organisations trust MapmyIndia maps, location and IoT technologies. 
To learn why, visit *mapmyindia.com 
*.
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Cleaning up the QGIS Developers/QGIS Community groups

2021-10-18 Thread Nyall Dawson 
On Mon, 18 Oct 2021 at 17:46, Alessandro Pasotti  wrote:
>
> Hi Nyall,
>
> To summarize:
>
> 1. QGIS core contributor status is for life
> 2. github core committer rights will be revoked after 24 months of inactivity
> 3. github core committer rights will be given back if the contributor 
> restarts to contribute

Exactly. (So the main distinction here is that core contributor status
=== QGIS.org implicitly trusts a PERSON, not a "github user account").

Nyall

>
> This makes total sense to me, we discussed this briefly in the PSC but we 
> didn't decide anything yet.
>
> We can put it in the agenda for the following meeting but I think that if 
> there are no objections from the qgis-dev ML I guess it will be approved 
> right away.
>
> Kind regards.
>
> --
> Alessandro Pasotti
> QCooperative:  www.qcooperative.net
> ItOpen:   www.itopen.it
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Cleaning up the QGIS Developers/QGIS Community groups

2021-10-18 Thread Alessandro Pasotti 
On Mon, Oct 18, 2021 at 12:55 AM Nyall Dawson 
wrote:

> Hi lists,
>
> Given that we've recently granted membership to the github QGIS
> Developers group to a bunch of new members, I think it's timely that
> we also take the opportunity to clean up the membership and drop some
> members.
>
> What I specifically mean here is that we should (hopefully
> temporarily!!) remove developers/contributors from the groups if they
> haven't been active in the project for say, the last 24 months. While
> it's obviously sad to see once regular contributors move on, it's a
> perfectly natural thing as people's work/life situations evolve and
> change.
>
> Leaving these users with access to the repos is ultimately a security
> risk to QGIS. I'm concerned that there's github accounts with
> absolutely no Github activity at all in recent years who still have
> direct commit access to the QGIS repository (e.g.
> https://github.com/homann ).
>
> So I would propose that we set some policy regarding "temporary
> hiatus/removal" from the QGIS Developers/QGIS Community groups for
> users who aren't currently active in the project. Something like "if
> the user shows no activity on the QGIS repositories for 24 months,
> then that user will be temporarily removed from the security groups.
> The user is still considered a core contributor/community member, and
> can have these access rights revived at any time via emailing the QGIS
> PSC".
>
> Thoughts?
>
> Nyall
>

Hi Nyall,

To summarize:

1. QGIS core contributor status is for life
2. github core committer rights will be revoked after 24 months of
inactivity
3. github core committer rights will be given back if the contributor
restarts to contribute

This makes total sense to me, we discussed this briefly in the PSC but we
didn't decide anything yet.

We can put it in the agenda for the following meeting but I think that if
there are no objections from the qgis-dev ML I guess it will be approved
right away.

Kind regards.

-- 
Alessandro Pasotti
QCooperative:  www.qcooperative.net
ItOpen:   www.itopen.it
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer