Re: [QGIS-Developer] Consistent Ordering (and terms) for buttons in dialogs

2019-05-14 Thread Tim Sutton 
Hi

This is usually a symptom of not using a QDialogButtonBox. If used the button 
box will automatically adjust the sequence to match the HIG guidelines for the 
client OS.

Regards

Tim

> On 13 May 2019, at 01:03, Jonathan Moules  
> wrote:
> 
> Hi List,
> 
> There seems to be some inconsistent ordering and usage of the buttons on 
> dialogs. Does QGIS have developer guidelines on this?
> 
> Largely it's fairly consistent but sometimes button orders seem incongruous. 
> Also the use of "Cancel" versus "Close".
> 
> For example, Raster > "Raster Calculator" has: Ok, Cancel, Help
> 
> Raster > "Align Rasters": Ok, Close, Help
> 
> All the other data processing tools I looked at (not all) (Vector and Raster 
> menus) were consistent:  Run, Close, Help
> 
> Data Source Manager: (other buttons), Close, Add, Help
> 
> Add new service/database dialog: Ok, Cancel, Help
> 
> CRS Dialog: Ok, Cancel, Help
> 
> Project settings: OK, Cancel, Apply, Help
> 
> Options: Ok, Cancel, Help
> 
> Style Manager: Close, Help
> 
> 
> 
> 
> The ones that particularly jump out at me are:
> 
> * "Align Raster" using "close" not "cancel"
> 
> * Project Settings has an "Apply" but "Options" doesn't.
> 
> * Apply and Add seem to come after cancel/close but ok/run always comes 
> before. Shouldn't add/apply be to the left?
> 
> * Data processing tools seem like they should be "Cancel" as they're 
> Do/Do-Not dialogs.
> 
> These are minor things but consistency in the UI makes the application much 
> easier to use as it lowers the cognitive burden on the user.
> 
> (3.4.3)
> 
> Cheers,
> 
> Jonathan
> 
> 
> 
> ___
> QGIS-Developer mailing list
> QGIS-Developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

—









Tim Sutton

Co-founder: Kartoza
Ex Project chair: QGIS.org

Visit http://kartoza.com  to find out about open source:

Desktop GIS programming services
Geospatial web development
GIS Training
Consulting Services

Skype: timlinux 
IRC: timlinux on #qgis at freenode.net

I'd love to connect. Here's my calendar link  to 
make finding time easy.

___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Consistent Ordering (and terms) for buttons in dialogs

2019-05-12 Thread Paolo Cavallini 
Hi Jonathan,
thanks for the report. I suspect in different OSs there may be more
differences. This kind of polishing has usually lower priority, so it is
often overlooked, but I agree, important for the project.
Could you please open a ticket, if not already there?
Cheers.

On 13/05/19 02:03, Jonathan Moules wrote:
> Hi List,
> 
> There seems to be some inconsistent ordering and usage of the buttons on
> dialogs. Does QGIS have developer guidelines on this?
> 
> Largely it's fairly consistent but sometimes button orders seem
> incongruous. Also the use of "Cancel" versus "Close".
> 
> For example, Raster > "Raster Calculator" has: Ok, Cancel, Help
> 
> Raster > "Align Rasters": Ok, Close, Help
> 
> All the other data processing tools I looked at (not all) (Vector and
> Raster menus) were consistent:  Run, Close, Help
> 
> Data Source Manager: (other buttons), Close, Add, Help
> 
> Add new service/database dialog: Ok, Cancel, Help
> 
> CRS Dialog: Ok, Cancel, Help
> 
> Project settings: OK, Cancel, Apply, Help
> 
> Options: Ok, Cancel, Help
> 
> Style Manager: Close, Help
> 
> 
> 
> 
> The ones that particularly jump out at me are:
> 
> * "Align Raster" using "close" not "cancel"
> 
> * Project Settings has an "Apply" but "Options" doesn't.
> 
> * Apply and Add seem to come after cancel/close but ok/run always comes
> before. Shouldn't add/apply be to the left?
> 
> * Data processing tools seem like they should be "Cancel" as they're
> Do/Do-Not dialogs.
> 
> These are minor things but consistency in the UI makes the application
> much easier to use as it lowers the cognitive burden on the user.
> 
> (3.4.3)
> 
> Cheers,
> 
> Jonathan
> 
> 
> 
> ___
> QGIS-Developer mailing list
> QGIS-Developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

-- 
Paolo Cavallini - www.faunalia.eu
QGIS.ORG Chair:
http://planet.qgis.org/planet/user/28/tag/qgis%20board/
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

[QGIS-Developer] Consistent Ordering (and terms) for buttons in dialogs

2019-05-12 Thread Jonathan Moules 

Hi List,

There seems to be some inconsistent ordering and usage of the buttons on 
dialogs. Does QGIS have developer guidelines on this?


Largely it's fairly consistent but sometimes button orders seem 
incongruous. Also the use of "Cancel" versus "Close".


For example, Raster > "Raster Calculator" has: Ok, Cancel, Help

Raster > "Align Rasters": Ok, Close, Help

All the other data processing tools I looked at (not all) (Vector and 
Raster menus) were consistent:  Run, Close, Help


Data Source Manager: (other buttons), Close, Add, Help

Add new service/database dialog: Ok, Cancel, Help

CRS Dialog: Ok, Cancel, Help

Project settings: OK, Cancel, Apply, Help

Options: Ok, Cancel, Help

Style Manager: Close, Help




The ones that particularly jump out at me are:

* "Align Raster" using "close" not "cancel"

* Project Settings has an "Apply" but "Options" doesn't.

* Apply and Add seem to come after cancel/close but ok/run always comes 
before. Shouldn't add/apply be to the left?


* Data processing tools seem like they should be "Cancel" as they're 
Do/Do-Not dialogs.


These are minor things but consistency in the UI makes the application 
much easier to use as it lowers the cognitive burden on the user.


(3.4.3)

Cheers,

Jonathan



___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer