Re: [QGIS-Developer] Processing options broken in QGIS LTR 2.18.19 (?)

[Jürgen E . Fischer]

Hi Paolo,

On Fri, 04. May 2018 at 08:13:35 +0200, Paolo Cavallini wrote:
> I'd be in favour of this - of course this will have a cost, and the
> release manager has the final word here.

First of all we need a fix.  Then we can decide if the next point release is
still far enough away to justify the extra effort.  We have 14 days left ;)

The commit apparently fixes something - reloadProvider expects the provider
name not the provider.  Now the call actually reloads something as it should
but that for some reason causes an endless recursion.  Maybe because the
modeler also scans the algorithms?  But I'm just guessing here.

Odd that it didn't error out before and also odd that the traceback is still
that short.


Jürgen

-- 
Jürgen E. Fischer   norBIT GmbH Tel. +49-4931-918175-31
Dipl.-Inf. (FH) Rheinstraße 13  Fax. +49-4931-918175-50
Software Engineer   D-26506 Norden http://www.norbit.de
QGIS release manager (PSC)  GermanyIRC: jef on FreeNode


signature.asc
Description: PGP signature
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Processing options broken in QGIS LTR 2.18.19 (?)

[Paolo Cavallini]

Il 04/05/2018 01:32, Nyall Dawson ha scritto:

> I wouldn't mind seeing some policy/process put in place for pulling
> stable releases/unscheduled updates when serious regressions are
> found. I can think of 3/4 releases in the past where we've had similar
> serious issues and would have been nice to have a way to push out
> immediate fixes for these.

I'd be in favour of this - of course this will have a cost, and the
release manager has the final word here.
All the best.

-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
https://www.google.com/trends/explore?date=all=IT=qgis,arcgis
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Processing options broken in QGIS LTR 2.18.19 (?)

[Nyall Dawson]

On 3 May 2018 at 19:36, Giovanni Manghi  wrote:
> Hi all,
>
>> It doesn't help 2.18, but unit tests are the fix here. At least in 3.0
>> the whole of processing core is totally soaked in unit tests.
>>
>> I'm going to be submitting a grant proposal to start adding gui unit
>> tests to processing. That's now the most fragile part of the
>> processing framework.
>
>
> thanks Nyall.
>
> We have anyway a hot potato now to handle: all people that upgraded
> recently to the latest and greatest LTR have now the problem they
> can't configure Processing and QGIS is left in a state it must be
> killed. Is this enough to trigger and emergency new point release? I
> would say yes.

(Apologies if my earlier reply sounded "flippant" - I didn't mean to
dismiss this issue. Rather I was just focusing on the "how can we
avoid in future" part here.)

I wouldn't mind seeing some policy/process put in place for pulling
stable releases/unscheduled updates when serious regressions are
found. I can think of 3/4 releases in the past where we've had similar
serious issues and would have been nice to have a way to push out
immediate fixes for these.

Nyall




>
> regards
>
> -- G --
> ___
> QGIS-Developer mailing list
> QGIS-Developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Processing options broken in QGIS LTR 2.18.19 (?)

[Giovanni Manghi]

Hi all,

> It doesn't help 2.18, but unit tests are the fix here. At least in 3.0
> the whole of processing core is totally soaked in unit tests.
>
> I'm going to be submitting a grant proposal to start adding gui unit
> tests to processing. That's now the most fragile part of the
> processing framework.


thanks Nyall.

We have anyway a hot potato now to handle: all people that upgraded
recently to the latest and greatest LTR have now the problem they
can't configure Processing and QGIS is left in a state it must be
killed. Is this enough to trigger and emergency new point release? I
would say yes.

regards

-- G --
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Processing options broken in QGIS LTR 2.18.19 (?)

[Nyall Dawson]

On 3 May 2018 at 16:49, Paolo Cavallini  wrote:
> Thanks Giovanni for checking. This kind of issues, in LTR minor
> releases, are particularly undesirable. We had already a few instances
> like this. Does anyone have ideas or suggestions on what we can do to
> prevent it?
> All the best.

It doesn't help 2.18, but unit tests are the fix here. At least in 3.0
the whole of processing core is totally soaked in unit tests.

I'm going to be submitting a grant proposal to start adding gui unit
tests to processing. That's now the most fragile part of the
processing framework.

Nyall

>
> Il 02/05/2018 22:11, Giovanni Manghi ha scritto:
>> this is the commit that apparently broke it
>>
>> https://github.com/qgis/QGIS/commit/c83261395476b62f67eace32c78460bdcfd79a8f
>>
>>
>> cheers
>>
>> -- G --
>>
>>
>>
>>
>>
>> On Wed, May 2, 2018 at 8:21 PM, Giovanni Manghi
>>  wrote:
>>> Hi all,
>>> I just noticed the following (on both Ubuntu and Window):
>>>
>>> clicking "ok" in Processing options dialog generated a python error,
>>> then clicking on "close" generates another one and so on and the only
>>> thing left is killing the program. Does not seems to happen on
>>> 2.18.18.
>>>
>>> Anyone confirms? If confirmed any chance to make an new point release asap?
>>>
>>> thanks in advance
>>>
>>> -- G --
>>>
>>>
>>> error:
>>>
>>> Traceback (most recent call last):
>>>   File 
>>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\gui\ProcessingToolbox.py",
>>> line 163, in updateProvider
>>> item.refresh()
>>>   File 
>>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\gui\ProcessingToolbox.py",
>>> line 377, in refresh
>>> Processing.updateAlgsList()
>>>   File 
>>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\Processing.py",
>>> line 184, in updateAlgsList
>>> Processing.reloadProvider(p.getName())
>>>   File 
>>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\Processing.py",
>>> line 189, in reloadProvider
>>> algList.reloadProvider(providerName)
>>>   File 
>>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\alglist.py",
>>> line 55, in reloadProvider
>>> p.loadAlgorithms()
>>>   File 
>>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\AlgorithmProvider.py",
>>> line 56, in loadAlgorithms
>>> self._loadAlgorithms()
>>>   File 
>>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\modeler\ModelerAlgorithmProvider.py",
>>> line 73, in _loadAlgorithms
>>> folders = ModelerUtils.modelsFolders()
>>>   File 
>>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\modeler\ModelerUtils.py",
>>> line 46, in modelsFolders
>>> folder = ProcessingConfig.getSetting(ModelerUtils.MODELS_FOLDER)
>>>   File 
>>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\ProcessingConfig.py",
>>> line 209, in getSetting
>>> if name in ProcessingConfig.settings.keys():
>>> RuntimeError: maximum recursion depth exceeded in cmp
>> ___
>> QGIS-Developer mailing list
>> QGIS-Developer@lists.osgeo.org
>> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>>
>
>
> --
> Paolo Cavallini - www.faunalia.eu
> QGIS & PostGIS courses: http://www.faunalia.eu/training.html
> https://www.google.com/trends/explore?date=all=IT=qgis,arcgis
> ___
> QGIS-Developer mailing list
> QGIS-Developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Processing options broken in QGIS LTR 2.18.19 (?)

[Paolo Cavallini]

Thanks Giovanni for checking. This kind of issues, in LTR minor
releases, are particularly undesirable. We had already a few instances
like this. Does anyone have ideas or suggestions on what we can do to
prevent it?
All the best.

Il 02/05/2018 22:11, Giovanni Manghi ha scritto:
> this is the commit that apparently broke it
> 
> https://github.com/qgis/QGIS/commit/c83261395476b62f67eace32c78460bdcfd79a8f
> 
> 
> cheers
> 
> -- G --
> 
> 
> 
> 
> 
> On Wed, May 2, 2018 at 8:21 PM, Giovanni Manghi
>  wrote:
>> Hi all,
>> I just noticed the following (on both Ubuntu and Window):
>>
>> clicking "ok" in Processing options dialog generated a python error,
>> then clicking on "close" generates another one and so on and the only
>> thing left is killing the program. Does not seems to happen on
>> 2.18.18.
>>
>> Anyone confirms? If confirmed any chance to make an new point release asap?
>>
>> thanks in advance
>>
>> -- G --
>>
>>
>> error:
>>
>> Traceback (most recent call last):
>>   File 
>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\gui\ProcessingToolbox.py",
>> line 163, in updateProvider
>> item.refresh()
>>   File 
>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\gui\ProcessingToolbox.py",
>> line 377, in refresh
>> Processing.updateAlgsList()
>>   File 
>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\Processing.py",
>> line 184, in updateAlgsList
>> Processing.reloadProvider(p.getName())
>>   File 
>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\Processing.py",
>> line 189, in reloadProvider
>> algList.reloadProvider(providerName)
>>   File 
>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\alglist.py",
>> line 55, in reloadProvider
>> p.loadAlgorithms()
>>   File 
>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\AlgorithmProvider.py",
>> line 56, in loadAlgorithms
>> self._loadAlgorithms()
>>   File 
>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\modeler\ModelerAlgorithmProvider.py",
>> line 73, in _loadAlgorithms
>> folders = ModelerUtils.modelsFolders()
>>   File 
>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\modeler\ModelerUtils.py",
>> line 46, in modelsFolders
>> folder = ProcessingConfig.getSetting(ModelerUtils.MODELS_FOLDER)
>>   File 
>> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\ProcessingConfig.py",
>> line 209, in getSetting
>> if name in ProcessingConfig.settings.keys():
>> RuntimeError: maximum recursion depth exceeded in cmp
> ___
> QGIS-Developer mailing list
> QGIS-Developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> 


-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
https://www.google.com/trends/explore?date=all=IT=qgis,arcgis
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Processing options broken in QGIS LTR 2.18.19 (?)

[Luigi Pirelli]

I'll try to replicate... seems strange that this commit could generate the
error. I'll check

Luigi Pirelli

**
* LinkedIn: https://www.linkedin.com/in/luigipirelli
* Stackexchange: http://gis.stackexchange.com/users/19667/luigi-pirelli
* GitHub: https://github.com/luipir
* Mastering QGIS 2nd Edition:
*
https://www.packtpub.com/big-data-and-business-intelligence/mastering-qgis-second-edition
* Hire me: http://goo.gl/BYRQKg
**

On 2 May 2018 at 22:11, Giovanni Manghi  wrote:

> this is the commit that apparently broke it
>
> https://github.com/qgis/QGIS/commit/c83261395476b62f67eace32c78460
> bdcfd79a8f
>
>
> cheers
>
> -- G --
>
>
>
>
>
> On Wed, May 2, 2018 at 8:21 PM, Giovanni Manghi
>  wrote:
> > Hi all,
> > I just noticed the following (on both Ubuntu and Window):
> >
> > clicking "ok" in Processing options dialog generated a python error,
> > then clicking on "close" generates another one and so on and the only
> > thing left is killing the program. Does not seems to happen on
> > 2.18.18.
> >
> > Anyone confirms? If confirmed any chance to make an new point release
> asap?
> >
> > thanks in advance
> >
> > -- G --
> >
> >
> > error:
> >
> > Traceback (most recent call last):
> >   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\gui\
> ProcessingToolbox.py",
> > line 163, in updateProvider
> > item.refresh()
> >   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\gui\
> ProcessingToolbox.py",
> > line 377, in refresh
> > Processing.updateAlgsList()
> >   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\
> core\Processing.py",
> > line 184, in updateAlgsList
> > Processing.reloadProvider(p.getName())
> >   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\
> core\Processing.py",
> > line 189, in reloadProvider
> > algList.reloadProvider(providerName)
> >   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\
> core\alglist.py",
> > line 55, in reloadProvider
> > p.loadAlgorithms()
> >   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\
> core\AlgorithmProvider.py",
> > line 56, in loadAlgorithms
> > self._loadAlgorithms()
> >   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\modeler\
> ModelerAlgorithmProvider.py",
> > line 73, in _loadAlgorithms
> > folders = ModelerUtils.modelsFolders()
> >   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\
> modeler\ModelerUtils.py",
> > line 46, in modelsFolders
> > folder = ProcessingConfig.getSetting(ModelerUtils.MODELS_FOLDER)
> >   File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\
> core\ProcessingConfig.py",
> > line 209, in getSetting
> > if name in ProcessingConfig.settings.keys():
> > RuntimeError: maximum recursion depth exceeded in cmp
> ___
> QGIS-Developer mailing list
> QGIS-Developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Processing options broken in QGIS LTR 2.18.19 (?)

[Giovanni Manghi]

this is the commit that apparently broke it

https://github.com/qgis/QGIS/commit/c83261395476b62f67eace32c78460bdcfd79a8f


cheers

-- G --





On Wed, May 2, 2018 at 8:21 PM, Giovanni Manghi
 wrote:
> Hi all,
> I just noticed the following (on both Ubuntu and Window):
>
> clicking "ok" in Processing options dialog generated a python error,
> then clicking on "close" generates another one and so on and the only
> thing left is killing the program. Does not seems to happen on
> 2.18.18.
>
> Anyone confirms? If confirmed any chance to make an new point release asap?
>
> thanks in advance
>
> -- G --
>
>
> error:
>
> Traceback (most recent call last):
>   File 
> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\gui\ProcessingToolbox.py",
> line 163, in updateProvider
> item.refresh()
>   File 
> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\gui\ProcessingToolbox.py",
> line 377, in refresh
> Processing.updateAlgsList()
>   File 
> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\Processing.py",
> line 184, in updateAlgsList
> Processing.reloadProvider(p.getName())
>   File 
> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\Processing.py",
> line 189, in reloadProvider
> algList.reloadProvider(providerName)
>   File 
> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\alglist.py",
> line 55, in reloadProvider
> p.loadAlgorithms()
>   File 
> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\AlgorithmProvider.py",
> line 56, in loadAlgorithms
> self._loadAlgorithms()
>   File 
> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\modeler\ModelerAlgorithmProvider.py",
> line 73, in _loadAlgorithms
> folders = ModelerUtils.modelsFolders()
>   File 
> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\modeler\ModelerUtils.py",
> line 46, in modelsFolders
> folder = ProcessingConfig.getSetting(ModelerUtils.MODELS_FOLDER)
>   File 
> "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\ProcessingConfig.py",
> line 209, in getSetting
> if name in ProcessingConfig.settings.keys():
> RuntimeError: maximum recursion depth exceeded in cmp
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

[QGIS-Developer] Processing options broken in QGIS LTR 2.18.19 (?)

[Giovanni Manghi]

Hi all,
I just noticed the following (on both Ubuntu and Window):

clicking "ok" in Processing options dialog generated a python error,
then clicking on "close" generates another one and so on and the only
thing left is killing the program. Does not seems to happen on
2.18.18.

Anyone confirms? If confirmed any chance to make an new point release asap?

thanks in advance

-- G --


error:

Traceback (most recent call last):
  File 
"C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\gui\ProcessingToolbox.py",
line 163, in updateProvider
item.refresh()
  File 
"C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\gui\ProcessingToolbox.py",
line 377, in refresh
Processing.updateAlgsList()
  File 
"C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\Processing.py",
line 184, in updateAlgsList
Processing.reloadProvider(p.getName())
  File 
"C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\Processing.py",
line 189, in reloadProvider
algList.reloadProvider(providerName)
  File "C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\alglist.py",
line 55, in reloadProvider
p.loadAlgorithms()
  File 
"C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\AlgorithmProvider.py",
line 56, in loadAlgorithms
self._loadAlgorithms()
  File 
"C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\modeler\ModelerAlgorithmProvider.py",
line 73, in _loadAlgorithms
folders = ModelerUtils.modelsFolders()
  File 
"C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\modeler\ModelerUtils.py",
line 46, in modelsFolders
folder = ProcessingConfig.getSetting(ModelerUtils.MODELS_FOLDER)
  File 
"C:/OSGEO4~1/apps/qgis-ltr/./python/plugins\processing\core\ProcessingConfig.py",
line 209, in getSetting
if name in ProcessingConfig.settings.keys():
RuntimeError: maximum recursion depth exceeded in cmp
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer