Re: [Qgis-developer] Header files order

2013-04-24 Thread Radim Blazek
On Sun, Apr 21, 2013 at 9:50 AM, Martin Dobias wonder...@gmail.com wrote:
 On Sat, Apr 20, 2013 at 10:18 AM, Radim Blazek radim.bla...@gmail.com wrote:
 do you agree with that order (least specific - most specific) extend
 for system etc (each section sorted lexically):

 * system headers
 * standard libraries headers
 * qt headers
 * other 3rd party libraries headers
 * qgis headers

 Personally I do not care so much about the order of the sections. I
 would say we should just:
 1. #include the corresponding header file first (e.g. for abc.cpp the
 first include should be #include abc.h) to ensure that the header
 file does not have some hidden include dependencies
 2. keep each section sorted

 Anyway the least specific - most specific order makes more sense than
 the opposite order.

I have modified the manual in this sense.

Radim

 Martin
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] Header files order

2013-04-21 Thread Martin Dobias
On Sat, Apr 20, 2013 at 10:18 AM, Radim Blazek radim.bla...@gmail.com wrote:
 do you agree with that order (least specific - most specific) extend
 for system etc (each section sorted lexically):

 * system headers
 * standard libraries headers
 * qt headers
 * other 3rd party libraries headers
 * qgis headers

Personally I do not care so much about the order of the sections. I
would say we should just:
1. #include the corresponding header file first (e.g. for abc.cpp the
first include should be #include abc.h) to ensure that the header
file does not have some hidden include dependencies
2. keep each section sorted

Anyway the least specific - most specific order makes more sense than
the opposite order.

Martin
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer