Re: [Qgis-developer] Mixing GPL-2 & GPL-3 code in QGIS (official Debian package rejected by FTP master)
On 02/28/2015 07:21 PM, Sebastiaan Couwenberg wrote: > The "Do not Rip/Merge" clause may prevent inclusion in QGIS if the > cpt-city collection is considered an "All in one gradients ... for > download". > > Since the README.txt included in cpt-city clearly states that copyright > is held by the respective authors, the clause does not seem to apply. > The gradients collection is not claimed to be by a different author. > > If the FTP masters cannot be persuaded of this view, excluding the es > gradient doesn't look very problematic either. The problematic ElevenSword gradients needed to be excluded from the Debian package, FTP master accepted QGIS 2.8.1 after the second repacking that also excluded the gradients. Next up, the very probable build failures on arm*. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1 ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Mixing GPL-2 & GPL-3 code in QGIS (official Debian package rejected by FTP master)
On Sat, Feb 28, 2015 at 11:21:01PM +0100, Sebastiaan Couwenberg wrote: > On 02/28/2015 10:47 PM, Jürgen E. Fischer wrote: > > On Sat, 28. Feb 2015 at 19:21:23 +0100, Sebastiaan Couwenberg > >> Removing the dxf2shp_converter plugin from QGIS would get rid of > >> the problematic GPL-2 licensed works, but the inclusion of GPL-3+ > >> works still upgrades the GPL-2+ license for QGIS to GPL-3+. > > > > Would that be a problem? In that case Debian is free to > > redistribute. > > It's not a problem with the DFSG, but it may not be the intention or > desire of the QGIS developers. If it wasn't, QGIS would be GPL-2 only. Previous discussion: http://hub.qgis.org/issues/3432 A couple of still-open tickets about licensing: http://hub.qgis.org/issues/3789 http://hub.qgis.org/issues/11216 --strk; ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Mixing GPL-2 & GPL-3 code in QGIS (official Debian package rejected by FTP master)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Jürgen, On 02/28/2015 10:47 PM, Jürgen E. Fischer wrote: > On Sat, 28. Feb 2015 at 19:21:23 +0100, Sebastiaan Couwenberg > wrote: >> The dxf2shp_converter plugin contains code under GPL-2 (v2 only), >> GPL-2+ (v2 or later), MIT, LGPL-2+ and commercial licenses. This >> is documented in the debian/copyright file as follows: >> > > The GPL-2 code in dxf2shp can be removed. And the dxf2shp lib can > be upgraded to 3.7.5 that is licensed under GPL-2+. The > getInsertions code is trivial and AFAICT the handling is wrong > anyway - the content of a block is only inserted once at the > location of the first insert instead of repeatedly on every > location of the inserts. It's probably better to handle inserts > similar to the texts. > > After that there's not GPL-2 only code in QGIS, right? That's right, the dxf2shp converter plugin is the only one with GPL-2 licensed files. I've updated the Debian packaging to exclude the dxf2shp converter plugin from the upstream tarball, and patched the build to not install the library. That should address this issue on the Debian side for the time being. Upgrading the library to the current version in which the license issue is resolved sounds much better on the longer term. >> Removing the dxf2shp_converter plugin from QGIS would get rid of >> the problematic GPL-2 licensed works, but the inclusion of GPL-3+ >> works still upgrades the GPL-2+ license for QGIS to GPL-3+. > > Would that be a problem? In that case Debian is free to > redistribute. It's not a problem with the DFSG, but it may not be the intention or desire of the QGIS developers. >> Excluding the GPL-3+ resources doesn't look very problematic at >> first glance, but I expect the removal of libpal to cause more >> breakage. > > That would kill labeling. Enough reason to keep it, or search for a GPL-2+ replacement if the upgrade to GPL-3+ is considered problematic. >> Besides the GPL-2/GPL-3 issue, one of the resources also has >> problematic license terms: > >> Files: resources/cpt-city-qgis-min/es/* Copyright: 2008, >> ElvenSword (http://elvensword.deviantart.com/) Comment: Credit >> requested for use, required for distribution License: ElvenSword > > Looks like there are more with non-free license and also stuff that > is GPL-2 only. I suppose we can remove all of those too. Etienne? The only other issue I found with the resources is that it seems resources/cpt-city-qgis-min/nd/COPYING.xml does not correspond to the CC-BY-SA-3.0 license stated on the DeviantArt page (and d/copyright). Kind Regards, Bas - -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1 -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAEBCgAGBQJU8j9NAAoJEGdQ8QrojUrxWZAP/j0oeqP3anQSoVVAxVchR7k6 CUBXkNf/tfmAxM+G3PFp1tlsysVVWKRpu5L4G6W6Pbtmv42xjcq1DjayCcKB8RIu GHG62P8/3JohqSNwruuNCaHqO+/n8p36LYoeeAphJBXdET5fDvrfawQK3gRfIePL F09A7J2ln0RWkUzZN8LeFjvNoy42wkUJnJ6PsB0o300ewNetTjLsxZyL0Sgaul84 kJ7xe1nZlON4efNngL3o8F8ztx1Ikhtk4NBgAvvakJsY6MnqXcFGFECGrf8YijaN Kv9hlrTyBic624kVpiRl08PMpZpF8CC1Fb0T7JHsroOmy43CVrSWyF2+kM7HoIFY TQhx2IjI8n9i+j3sUYbNWnA2+tUvedhms6lJP7IWpjHiezpojKmbqGId31nGjAno TeNxWVKZjudr9XyBpUTW0blt6dNR9w0PvoSoHSbwWM3lfcVrlTwp8i+Z7eMLekfe mi14vY1sieGjSekQVjl+0RAIyE9W68Y2rYoqtoMVEEgIibj3fsOaOLrLSJAY2Psu FbNYJu8ZmjiTez6LH33TrbmFHrK6+NiDHqmL+2Lm6cz98HUeD3NWn6aST6ZUegJK BJDd3TLY97AnIoxPuLZFhLi04XDAlt945vNDQ4e7o1QGpGXbhAB5Dk0ZP7n8fAZB yIvhRhHIlyE/4nV1ktY/ =Y8s+ -END PGP SIGNATURE- ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Mixing GPL-2 & GPL-3 code in QGIS (official Debian package rejected by FTP master)
Hi Bas, On Sat, 28. Feb 2015 at 19:21:23 +0100, Sebastiaan Couwenberg wrote: > The dxf2shp_converter plugin contains code under GPL-2 (v2 only), GPL-2+ > (v2 or later), MIT, LGPL-2+ and commercial licenses. This is documented > in the debian/copyright file as follows: > > Files: src/plugins/dxf2shp_converter/getInsertions.h > Copyright: Christopher Michaelis > License: GPL-2 > > Files: src/plugins/dxf2shp_converter/getInsertions.cpp > Copyright: Christopher Michaelis > License: GPL-2+ > Files: src/plugins/dxf2shp_converter/shapelib-1.2.10/* > Copyright: 1999, 2001-2002, Frank Warmerdam > License: MIT or LGPL-2+ > > Files: src/plugins/dxf2shp_converter/dxflib/src/* > Copyright: 2001-2003, RibbonSoft > 2001, Robert J. Campbell Jr > License: GPL-2 or dxflib-Commercial-License The GPL-2 code in dxf2shp can be removed. And the dxf2shp lib can be upgraded to 3.7.5 that is licensed under GPL-2+. The getInsertions code is trivial and AFAICT the handling is wrong anyway - the content of a block is only inserted once at the location of the first insert instead of repeatedly on every location of the inserts. It's probably better to handle inserts similar to the texts. After that there's not GPL-2 only code in QGIS, right? > Removing the dxf2shp_converter plugin from QGIS would get rid of the > problematic GPL-2 licensed works, but the inclusion of GPL-3+ works > still upgrades the GPL-2+ license for QGIS to GPL-3+. Would that be a problem? In that case Debian is free to redistribute. > Excluding the GPL-3+ resources doesn't look very problematic at first > glance, but I expect the removal of libpal to cause more breakage. That would kill labeling. > Besides the GPL-2/GPL-3 issue, one of the resources also has problematic > license terms: > Files: resources/cpt-city-qgis-min/es/* > Copyright: 2008, ElvenSword (http://elvensword.deviantart.com/) > Comment: Credit requested for use, required for distribution > License: ElvenSword Looks like there are more with non-free license and also stuff that is GPL-2 only. I suppose we can remove all of those too. Etienne? Jürgen -- Jürgen E. Fischer norBIT GmbH Tel. +49-4931-918175-31 Dipl.-Inf. (FH) Rheinstraße 13 Fax. +49-4931-918175-50 Software Engineer D-26506 Norden http://www.norbit.de QGIS release manager (PSC) GermanyIRC: jef on FreeNode signature.asc Description: Digital signature ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
[Qgis-developer] Mixing GPL-2 & GPL-3 code in QGIS (official Debian package rejected by FTP master)
Hi all,
After 4 releases and a significant update of the debian/copyright file,
the Debian FTP masters have reviewed the qgis package and unfortunately
rejected it due to incompatibly licensed code.
I've included the FTP master response below, and it's also available in
the list archive:
http://lists.alioth.debian.org/pipermail/pkg-grass-devel/2015-February/027884.html
The dxf2shp_converter plugin contains code under GPL-2 (v2 only), GPL-2+
(v2 or later), MIT, LGPL-2+ and commercial licenses. This is documented
in the debian/copyright file as follows:
Files: src/plugins/dxf2shp_converter/builder.cpp
src/plugins/dxf2shp_converter/builder.h
Copyright: 1999, Frank Warmerdam
Comment: The code is heavily based on Christopher Michaelis' DXF to
Shapefile Converter (http://www.wanderingidea.com/content/view/12/25/),
released under GPL License
.
This code is based on two other products:
DXFLIB (http://www.ribbonsoft.com/dxflib.html)
This is a library for reading DXF files, also GPL.
SHAPELIB (http://shapelib.maptools.org/)
Used for the Shapefile functionality.
License: MIT
Files: src/plugins/dxf2shp_converter/getInsertions.h
Copyright: Christopher Michaelis
License: GPL-2
Files: src/plugins/dxf2shp_converter/getInsertions.cpp
Copyright: Christopher Michaelis
License: GPL-2+
Files: src/plugins/dxf2shp_converter/shapelib-1.2.10/*
Copyright: 1999, 2001-2002, Frank Warmerdam
License: MIT or LGPL-2+
Files: src/plugins/dxf2shp_converter/dxflib/src/*
Copyright: 2001-2003, RibbonSoft
2001, Robert J. Campbell Jr
License: GPL-2 or dxflib-Commercial-License
The GPL-2 (v2 only) files are problematic because their license prevents
the upgrade to the GPL-3+ license used for libpal:
Files: src/core/pal/*
Copyright: 2008, Maxence Laurent, MIS-TIC, HEIG-VD
License: GPL-3+
Files: src/core/pal/costcalculator.cpp
src/core/pal/costcalculator.h
Copyright: 2009, Martin Dobias
License: GPL-2+
Files: src/core/pal/rtree.hpp
Copyright: disclaimed
Comment: from http://www.superliminal.com/
.
AUTORS
- 1983 Original algorithm and test code by Antonin Guttman and
Michael Stonebraker, UC Berkely
- 1994 ANCI C ported from original test code by Melinda Green -
meli...@superliminal.com
- 1995 Sphere volume fix for degeneracy problem submitted by
Paul Brook
- 2004 Templated C++ port by Greg Douglas
- 2008 Portability issues fixed by Maxence Laurent
License: public-domain
LICENSE : Entirely free for all uses. Enjoy!
This File is in the public domain
The use of the GPL instead of LGPL by libpal is unfortunate, because the
GPL doesn't have the link exceptions. The use libpal in QGIS makes the
combination fall under the GPL-3+ which GPL-2+ license for QGIS allows,
but the GPL-2 licensed work do not.
See the GPL license compatibility matrix for an overview of the effects
of combining works under various GPL licenses:
http://www.gnu.org/licenses/gpl-faq.html#AllCompatibility
To keep the combined work shipped in QGIS releases under the GPL-2+
license of GPL-3+ works needs to be changed. This requires all copyright
holders of the work to consent with the GPL-2+ license for their
contributions.
libpam is not the only problematic GPL-3+ work included in QGIS, a
couple of resources are too:
Files: resources/cpt-city-qgis-min/ds9/*
Copyright: 2010, William Joye
License: GPL-3+
Files: resources/cpt-city-qgis-min/grass/*
Copyright: 2009, GRASS Development Team
License: GPL-3+
Removing the dxf2shp_converter plugin from QGIS would get rid of the
problematic GPL-2 licensed works, but the inclusion of GPL-3+ works
still upgrades the GPL-2+ license for QGIS to GPL-3+.
Excluding the GPL-3+ resources doesn't look very problematic at first
glance, but I expect the removal of libpal to cause more breakage.
Besides the GPL-2/GPL-3 issue, one of the resources also has problematic
license terms:
Files: resources/cpt-city-qgis-min/es/*
Copyright: 2008, ElvenSword (http://elvensword.deviantart.com/)
Comment: Credit requested for use, required for distribution
License: ElvenSword
For use:
.
* Using for commercial works, prints:
Yes. There is no need ask permission first, or after.
My resources are free for personal or commercial arts works. Credit is
enough if possible, if there is a description. Note link to me not
necessary. But it is good, I can not see them otherwise, feel free
about it.
.
* Using in only DA:
I submit them only DA yes, but you may use out of DA.
.
For distribute:
.
* I like sharing. So okay distributing my resources with credit,
for good, for free. But,
.
* Do not distribute my resource files without original preview.
('cause previews including credit. Credit is important point on
this situation.)
.
* Do not remove my name on it (preview). I saw some Turkish and
Russian forum sites delete artists names though, and they puting
their own cursed crappy logos on the previews. It is not sharing.
It is ...
.
* Do not create collect
