Re: [Qgis-developer] Preventing bad raster filenames - advice?

2013-05-08 Thread Etienne Tourigny
On Wed, May 8, 2013 at 2:45 AM, Paolo Cavallini cavall...@faunalia.itwrote:

 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1

 Il 08/05/2013 05:12, Nyall Dawson ha scritto:

  I'm thinking it's probably best to make the file name edits read only,

  Before I make this change, does anyone have any ideas on alternative
  ways to handle this situation?

 Hi Nyall,
 thanks for taking this; you jit a soft spot, saving rasters is implemented
 in
 different ways within QGIS, something that has to be corrected sooner or
 later.
 I agree that browsing rather than typing the filename is a good practice.
 I do not agree this should be made compulsory: most dialogs remember the
 last used
 dir, so just changing the filename is faster than browsing.
 IMHO, better fix the crash upstream.


yes better to make sure the filename contains path when file dialog is not
used.



 All the best.
 - --
 Paolo Cavallini - Faunalia
 www.faunalia.eu
 Full contact details at www.faunalia.eu/pc
 Nuovi corsi QGIS e PostGIS: http://www.faunalia.it/calendario
 -BEGIN PGP SIGNATURE-
 Version: GnuPG v1.4.12 (GNU/Linux)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

 iEYEARECAAYFAlGJ5o8ACgkQ/NedwLUzIr6iBQCfdHk/G7TOq25lwgdv4hYer7VT
 qgMAn0pn/0HLZtFDzwil6mdLSCXSMk4y
 =X6Jc
 -END PGP SIGNATURE-
 ___
 Qgis-developer mailing list
 Qgis-developer@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/qgis-developer

___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


[Qgis-developer] Preventing bad raster filenames - advice?

2013-05-07 Thread Nyall Dawson
Hi all,

I'm after some quick advice - in investigating
http://hub.qgis.org/issues/7624 I've tracked the crash down to users
entering a destination raster filename without a path (only occurs
under Windows). If they use the ... button next to the filename
field then the full path is correctly filled in and no crash occurs.

While the bug report is specifically for the heatmap plugin I've since
noticed this behaviour applies to some other areas too, such as the
raster calculator dialog.

I'm thinking it's probably best to make the file name edits read only,
so the only way to choose a destination file is by clicking the ...
button and using the file chooser dialog. This will force the
destination filename to be a full absolute path. (After all, if a user
enters a relative path for the destination there's no way of
identifying what they'd like it to be relative to..! The input file?
The project?)

Before I make this change, does anyone have any ideas on alternative
ways to handle this situation?

Nyall
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


Re: [Qgis-developer] Preventing bad raster filenames - advice?

2013-05-07 Thread Paolo Cavallini
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Il 08/05/2013 05:12, Nyall Dawson ha scritto:

 I'm thinking it's probably best to make the file name edits read only,

 Before I make this change, does anyone have any ideas on alternative
 ways to handle this situation?

Hi Nyall,
thanks for taking this; you jit a soft spot, saving rasters is implemented in
different ways within QGIS, something that has to be corrected sooner or later.
I agree that browsing rather than typing the filename is a good practice.
I do not agree this should be made compulsory: most dialogs remember the last 
used
dir, so just changing the filename is faster than browsing.
IMHO, better fix the crash upstream.
All the best.
- -- 
Paolo Cavallini - Faunalia
www.faunalia.eu
Full contact details at www.faunalia.eu/pc
Nuovi corsi QGIS e PostGIS: http://www.faunalia.it/calendario
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlGJ5o8ACgkQ/NedwLUzIr6iBQCfdHk/G7TOq25lwgdv4hYer7VT
qgMAn0pn/0HLZtFDzwil6mdLSCXSMk4y
=X6Jc
-END PGP SIGNATURE-
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer