Re: [Qgis-developer] Pull request responsibility
Has anybody ever heard of this redmine plugin: https://github.com/jamtur01/ghostred According to the project description GhostRed connects to GitHub ... Each· pull request is then captured, a corresponding ticket opened in a· Redmine project I think this could help us to manage this problem, if we stick to redmine. In redmine, devs can also get a list of open tasks and not only get a one-time-notification informing about the responsibility. Matthias ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Pull request responsibility
On Fre 06 Sep 2013 15:24:33 CEST, Martin Dobias wrote: On Thu, Sep 5, 2013 at 4:52 PM, Matthias Kuhn matthias.k...@gmx.ch wrote: However, I just found a pull request which is assigned to me and I didn't realize before. Same happened already several times, when asking an assigned developer about the status, he normally didn't know about his assignment. At the same time, others will hesitate from taking care of a pull request assigned to somebody else. Same here. The worst of all is that there is no way how to actually find out which pull requests are assigned to me unless I go through them one by one. Some time ago I have asked GitHub guys about that - they told me that it is possible to see what is assigned to you, but we would need to turn on GitHub issue tracking system where this feature is integrated... Martin We just did a test and didn't find a solution for getting a list of assigned pull requests (or assignment notifications) even with issue tracking turned on. It seems you only get this list for issues assigned to you, but still not for pull requests. So we would still need to open an issue for every pull request. We can do that on our own issue tracker also I guess. Marco, did your assigned to @developer test work? Matthias ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Pull request responsibility
On 09/09/2013 10:36 AM, Matthias Kuhn wrote: We just did a test and didn't find a solution for getting a list of assigned pull requests (or assignment notifications) even with issue tracking turned on. It seems you only get this list for issues assigned to you, but still not for pull requests. So we would still need to open an issue for every pull request. We can do that on our own issue tracker also I guess. in a project I work (using github) each pull request gets an automatic issue as well [0] I don't know maybe there is a setting? ciao [0] https://github.com/gem/oq-eqcatalogue-tool/issues/created_by/mbernasocchi?state=closed -- Marco Bernasocchi http://opengis.ch ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Pull request responsibility
On 09/09/2013 10:39 AM, Marco Bernasocchi wrote: On 09/09/2013 10:36 AM, Matthias Kuhn wrote: We just did a test and didn't find a solution for getting a list of assigned pull requests (or assignment notifications) even with issue tracking turned on. It seems you only get this list for issues assigned to you, but still not for pull requests. So we would still need to open an issue for every pull request. We can do that on our own issue tracker also I guess. in a project I work (using github) each pull request gets an automatic issue as well [0] Maybe we could use issue tracking on github for pull requests only? I don't know maybe there is a setting? ciao [0] https://github.com/gem/oq-eqcatalogue-tool/issues/created_by/mbernasocchi?state=closed ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Pull request responsibility
Hi Marco is looking for an option to enable these notifications. In case there's nothing I think we should open a ticket on github's github page I didn't find out how to enable pull request assign notifications. Now I've sent a support request to github, let's see if they reply. Regards, Marco On 05.09.2013 18:15, Matthias Kuhn wrote: Hi Larry On Don 05 Sep 2013 18:11:44 CEST, Larry Shaffer wrote: Hi Matthias, On Thu, Sep 5, 2013 at 8:52 AM, Matthias Kuhn matthias.k...@gmx.ch mailto:matthias.k...@gmx.ch wrote: Hi, The last couple of months, (almost?) every pull request has a core developer assigned. I personally think, the idea is good to make somebody responsible for the pull request (who can pass it on if required of course) so they don't get forgotten. However, I just found a pull request which is assigned to me and I didn't realize before. Same happened already several times, when asking an assigned developer about the status, he normally didn't know about his assignment. At the same time, others will hesitate from taking care of a pull request assigned to somebody else. Very important to get those notifications. To this end, I added a pull request and assigned it to you (feel free to close or commit it). Please verify you are receiving the notification that I assigned it to you. I already verified with Marco, and he got no verification, and I didn't either. Marco is looking for an option to enable these notifications. In case there's nothing I think we should open a ticket on github's github page (I just guess there is one :-) ) I shortly checked, the information would be present in the github API, but honestly, we got enough issues to solve in our software. Regards, Matthias Regards, Larry Now, I guess somebody is assigning these? Is this done by any criteria? And has somebody found a solution to get notifications about assignments or have a list of one's assigned pull requests? Is there a plan for the process of pull requests, so they don't just pile up until we totally loose the overview? Matthias ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org mailto:Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer -- Dr. Marco Hugentobler Sourcepole - Linux Open Source Solutions Weberstrasse 5, CH-8004 Zürich, Switzerland marco.hugentob...@sourcepole.ch http://www.sourcepole.ch Technical Advisor QGIS Project Steering Committee ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
[Qgis-developer] Pull request responsibility
Hi, The last couple of months, (almost?) every pull request has a core developer assigned. I personally think, the idea is good to make somebody responsible for the pull request (who can pass it on if required of course) so they don't get forgotten. However, I just found a pull request which is assigned to me and I didn't realize before. Same happened already several times, when asking an assigned developer about the status, he normally didn't know about his assignment. At the same time, others will hesitate from taking care of a pull request assigned to somebody else. Now, I guess somebody is assigning these? Is this done by any criteria? And has somebody found a solution to get notifications about assignments or have a list of one's assigned pull requests? Is there a plan for the process of pull requests, so they don't just pile up until we totally loose the overview? Matthias ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Pull request responsibility
I've been also sometimes assigning my own pull requests to Jurgen, now I'm not sure he ever got notified about them. I took the chance to merge those requests myself: https://github.com/qgis/Quantum-GIS/pull/805 https://github.com/qgis/Quantum-GIS/pull/777 There are still 36 open pull requests, some of which fix real bugs. I hope assigners can find the time to review them as there might be good stuff to put in 2.0.0. There's no way to get the list of assigned tickets from the UI, which sucks :( -- would it be possible to automatically file a ticket on hub when a pull request is made on github ? --strk; On Thu, Sep 05, 2013 at 05:03:02PM +0200, Marco Hugentobler wrote: Hi Matthias I'm assigning the pull requests normally. And has somebody found a solution to get notifications about assignments Hm, I thought github sends out notifications whenever something changes in a pull request. But maybe it is only for new requests, comments and closes? Regards, Marco On 05.09.2013 16:52, Matthias Kuhn wrote: Hi, The last couple of months, (almost?) every pull request has a core developer assigned. I personally think, the idea is good to make somebody responsible for the pull request (who can pass it on if required of course) so they don't get forgotten. However, I just found a pull request which is assigned to me and I didn't realize before. Same happened already several times, when asking an assigned developer about the status, he normally didn't know about his assignment. At the same time, others will hesitate from taking care of a pull request assigned to somebody else. Now, I guess somebody is assigning these? Is this done by any criteria? And has somebody found a solution to get notifications about assignments or have a list of one's assigned pull requests? Is there a plan for the process of pull requests, so they don't just pile up until we totally loose the overview? Matthias ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Pull request responsibility
Hi Matthias, On Thu, Sep 5, 2013 at 8:52 AM, Matthias Kuhn matthias.k...@gmx.ch wrote: Hi, The last couple of months, (almost?) every pull request has a core developer assigned. I personally think, the idea is good to make somebody responsible for the pull request (who can pass it on if required of course) so they don't get forgotten. However, I just found a pull request which is assigned to me and I didn't realize before. Same happened already several times, when asking an assigned developer about the status, he normally didn't know about his assignment. At the same time, others will hesitate from taking care of a pull request assigned to somebody else. Very important to get those notifications. To this end, I added a pull request and assigned it to you (feel free to close or commit it). Please verify you are receiving the notification that I assigned it to you. Regards, Larry Now, I guess somebody is assigning these? Is this done by any criteria? And has somebody found a solution to get notifications about assignments or have a list of one's assigned pull requests? Is there a plan for the process of pull requests, so they don't just pile up until we totally loose the overview? Matthias ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Pull request responsibility
Hi Larry On Don 05 Sep 2013 18:11:44 CEST, Larry Shaffer wrote: Hi Matthias, On Thu, Sep 5, 2013 at 8:52 AM, Matthias Kuhn matthias.k...@gmx.ch mailto:matthias.k...@gmx.ch wrote: Hi, The last couple of months, (almost?) every pull request has a core developer assigned. I personally think, the idea is good to make somebody responsible for the pull request (who can pass it on if required of course) so they don't get forgotten. However, I just found a pull request which is assigned to me and I didn't realize before. Same happened already several times, when asking an assigned developer about the status, he normally didn't know about his assignment. At the same time, others will hesitate from taking care of a pull request assigned to somebody else. Very important to get those notifications. To this end, I added a pull request and assigned it to you (feel free to close or commit it). Please verify you are receiving the notification that I assigned it to you. I already verified with Marco, and he got no verification, and I didn't either. Marco is looking for an option to enable these notifications. In case there's nothing I think we should open a ticket on github's github page (I just guess there is one :-) ) I shortly checked, the information would be present in the github API, but honestly, we got enough issues to solve in our software. Regards, Matthias Regards, Larry Now, I guess somebody is assigning these? Is this done by any criteria? And has somebody found a solution to get notifications about assignments or have a list of one's assigned pull requests? Is there a plan for the process of pull requests, so they don't just pile up until we totally loose the overview? Matthias ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org mailto:Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Pull request responsibility
On Thu, Sep 5, 2013 at 1:44 PM, Sandro Santilli s...@keybit.net wrote: On Thu, Sep 05, 2013 at 06:15:18PM +0200, Matthias Kuhn wrote: Marco is looking for an option to enable these notifications. In case there's nothing I think we should open a ticket on github's github page (I just guess there is one :-) ) I shortly checked, the information would be present in the github API, but honestly, we got enough issues to solve in our software. Remember github is not free software... How about disabling pull requests from github as a whole and rely on the existing bug tracker for that ? It's just a matter of including someone's repository url and branch name to make a pull request, and there's even a convenience `git request-pull` command to generate the text for you. or attach a link to the pull request in the bug report... --strk; ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Pull request responsibility
That is strange. I tend to get notifications for GitHub notifications when assigned to stuff. - Nathan On Fri, Sep 6, 2013 at 2:15 AM, Matthias Kuhn matthias.k...@gmx.ch wrote: Hi Larry On Don 05 Sep 2013 18:11:44 CEST, Larry Shaffer wrote: Hi Matthias, On Thu, Sep 5, 2013 at 8:52 AM, Matthias Kuhn matthias.k...@gmx.ch mailto:matthias.k...@gmx.ch wrote: Hi, The last couple of months, (almost?) every pull request has a core developer assigned. I personally think, the idea is good to make somebody responsible for the pull request (who can pass it on if required of course) so they don't get forgotten. However, I just found a pull request which is assigned to me and I didn't realize before. Same happened already several times, when asking an assigned developer about the status, he normally didn't know about his assignment. At the same time, others will hesitate from taking care of a pull request assigned to somebody else. Very important to get those notifications. To this end, I added a pull request and assigned it to you (feel free to close or commit it). Please verify you are receiving the notification that I assigned it to you. I already verified with Marco, and he got no verification, and I didn't either. Marco is looking for an option to enable these notifications. In case there's nothing I think we should open a ticket on github's github page (I just guess there is one :-) ) I shortly checked, the information would be present in the github API, but honestly, we got enough issues to solve in our software. Regards, Matthias Regards, Larry Now, I guess somebody is assigning these? Is this done by any criteria? And has somebody found a solution to get notifications about assignments or have a list of one's assigned pull requests? Is there a plan for the process of pull requests, so they don't just pile up until we totally loose the overview? Matthias ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org mailto: Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Pull request responsibility
On Thu, Sep 05, 2013 at 06:15:18PM +0200, Matthias Kuhn wrote: Marco is looking for an option to enable these notifications. In case there's nothing I think we should open a ticket on github's github page (I just guess there is one :-) ) I shortly checked, the information would be present in the github API, but honestly, we got enough issues to solve in our software. Remember github is not free software... How about disabling pull requests from github as a whole and rely on the existing bug tracker for that ? It's just a matter of including someone's repository url and branch name to make a pull request, and there's even a convenience `git request-pull` command to generate the text for you. --strk; ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
