Re: [Qgis-developer] Question re api freeze
On Fri, May 16, 2014 at 3:07 PM, Hugo Mercier wrote: > Le 15/05/2014 12:03, Nyall Dawson a écrit : >> Hi all, >> >> Quick question about the api freeze for the qgis 2 series - am I >> allowed to change a function which is currently a void to instead >> return a bool? Does this classify as an api break, or would this be >> allowed? >> > > Hi Nyall, > > Good question :) > I would say : we have to ensure that the new API does not break > compilation of a code designed with the previous API. > And since calling a function returning bool and ignoring its returned > parameter is not a compilation error in C++, and it does not neither > break a Python code calling it, I'd see no problem. > > Can others confirm ? I also consider a change of return value from void to non-void to be source compatible change and therefore allowed. Cheers Martin ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [Qgis-developer] Question re api freeze
Le 15/05/2014 12:03, Nyall Dawson a écrit : > Hi all, > > Quick question about the api freeze for the qgis 2 series - am I > allowed to change a function which is currently a void to instead > return a bool? Does this classify as an api break, or would this be > allowed? > Hi Nyall, Good question :) I would say : we have to ensure that the new API does not break compilation of a code designed with the previous API. And since calling a function returning bool and ignoring its returned parameter is not a compilation error in C++, and it does not neither break a Python code calling it, I'd see no problem. Can others confirm ? -- Hugo Mercier Oslandia ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
[Qgis-developer] Question re api freeze
Hi all, Quick question about the api freeze for the qgis 2 series - am I allowed to change a function which is currently a void to instead return a bool? Does this classify as an api break, or would this be allowed? Nyall ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer
