Re: [Qgis-developer] What happened to processing.runalg?

2015-02-06 Thread Arnaud Morvan


I've just meet the same problem

it comes from this commit : 
https://github.com/qgis/QGIS/commit/956c155e8f45cb1a0fc4c5d6204f607f80edc6b0#diff-111
some imports where removes from processing.__init__.py in context of a 
pep8 check

this is the source of the regression

Arnaud

Le 06/02/2015 14:41, Tim Sutton a écrit :

Hi All

Once of our tests in InaSAFE fails against master (see below). Can 
someone tell me where runalg went, and more broadly which parts of the 
processing framework can be relied of as API compatible between 
releases? I guess more and more people will start relying on its API 
and we should make it clear what the best practice is.


Thanks!

Regards

Tim

==
ERROR: Test if line aggregation works
--
Traceback (most recent call last):
  File 
/home/timlinux/dev/python/inasafe-dev/safe/impact_statistics/test/test_aggregator.py, 
line 596, in test_line_aggregation

impact_layer_attributes=impact_layer_attributes)
  File 
/home/timlinux/dev/python/inasafe-dev/safe/impact_statistics/test/test_aggregator.py, 
line 338, in _aggregate

aggregator.aggregate(impact_layer)
  File 
/home/timlinux/dev/python/inasafe-dev/safe/impact_statistics/aggregator.py, 
line 527, in aggregate

qgis_impact_layer, safe_impact_layer)
  File 
/home/timlinux/dev/python/inasafe-dev/safe/impact_statistics/aggregator.py, 
line 634, in _aggregrate_vector_impact

self._aggregate_line_impact(safe_impact_layer)
  File 
/home/timlinux/dev/python/inasafe-dev/safe/impact_statistics/aggregator.py, 
line 920, in _aggregate_line_impact

res = self.processing.runalg('qgis:intersection',
AttributeError: 'module' object has no attribute 'runalg'




--
--
Tim Sutton
Visit http://kartoza.com http://kartoza.com/ to find out about open 
source:

 * Desktop GIS programming services
 * Geospatial web development
* GIS Training
* Consulting Services
Skype: timlinux Irc: timlinux on #qgis at freenode.net 
http://freenode.net/

Tim is a member of the QGIS Project Steering Committee
---
Kartoza is a merger between Linfiniti and Afrispatial


___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer


___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] What happened to processing.runalg?

2015-02-06 Thread Victor Olaya
the core methods should not change...and definitely not the runalg method,
which is likely to be the most important one.

This is clearly a blocker and has to be reverted.

2015-02-06 14:52 GMT+01:00 Arnaud Morvan arnaud.mor...@camptocamp.com:


 I've just meet the same problem

 it comes from this commit :
 https://github.com/qgis/QGIS/commit/956c155e8f45cb1a0fc4c5d6204f607f80edc6b0#diff-111
 some imports where removes from processing.__init__.py in context of a
 pep8 check
 this is the source of the regression

 Arnaud

 Le 06/02/2015 14:41, Tim Sutton a écrit :

  Hi All

  Once of our tests in InaSAFE fails against master (see below). Can
 someone tell me where runalg went, and more broadly which parts of the
 processing framework can be relied of as API compatible between releases? I
 guess more and more people will start relying on its API and we should make
 it clear what the best practice is.

  Thanks!

  Regards

  Tim

  ==
 ERROR: Test if line aggregation works
 --
 Traceback (most recent call last):
   File
 /home/timlinux/dev/python/inasafe-dev/safe/impact_statistics/test/test_aggregator.py,
 line 596, in test_line_aggregation
 impact_layer_attributes=impact_layer_attributes)
   File
 /home/timlinux/dev/python/inasafe-dev/safe/impact_statistics/test/test_aggregator.py,
 line 338, in _aggregate
 aggregator.aggregate(impact_layer)
   File
 /home/timlinux/dev/python/inasafe-dev/safe/impact_statistics/aggregator.py,
 line 527, in aggregate
 qgis_impact_layer, safe_impact_layer)
   File
 /home/timlinux/dev/python/inasafe-dev/safe/impact_statistics/aggregator.py,
 line 634, in _aggregrate_vector_impact
 self._aggregate_line_impact(safe_impact_layer)
   File
 /home/timlinux/dev/python/inasafe-dev/safe/impact_statistics/aggregator.py,
 line 920, in _aggregate_line_impact
 res = self.processing.runalg('qgis:intersection',
 AttributeError: 'module' object has no attribute 'runalg'




  --

 --
  Tim Sutton
 Visit http://kartoza.com to find out about open source:
  * Desktop GIS programming services
  * Geospatial web development
 * GIS Training
 * Consulting Services
  Skype: timlinux Irc: timlinux on #qgis at freenode.net
  Tim is a member of the QGIS Project Steering Committee

 ---
 Kartoza is a merger between Linfiniti and Afrispatial


 ___
 Qgis-developer mailing 
 listQgis-developer@lists.osgeo.orghttp://lists.osgeo.org/mailman/listinfo/qgis-developer



 ___
 Qgis-developer mailing list
 Qgis-developer@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/qgis-developer

___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] What happened to processing.runalg?

2015-02-06 Thread Tim Sutton
Hi

Ah thanks for the feedback Victor and Arnaud!

Regards

Tim

On Fri, Feb 6, 2015 at 3:58 PM, Victor Olaya vola...@gmail.com wrote:

 the core methods should not change...and definitely not the runalg method,
 which is likely to be the most important one.

 This is clearly a blocker and has to be reverted.

 2015-02-06 14:52 GMT+01:00 Arnaud Morvan arnaud.mor...@camptocamp.com:


 I've just meet the same problem

 it comes from this commit :
 https://github.com/qgis/QGIS/commit/956c155e8f45cb1a0fc4c5d6204f607f80edc6b0#diff-111
 some imports where removes from processing.__init__.py in context of a
 pep8 check
 this is the source of the regression

 Arnaud

 Le 06/02/2015 14:41, Tim Sutton a écrit :

  Hi All

  Once of our tests in InaSAFE fails against master (see below). Can
 someone tell me where runalg went, and more broadly which parts of the
 processing framework can be relied of as API compatible between releases? I
 guess more and more people will start relying on its API and we should make
 it clear what the best practice is.

  Thanks!

  Regards

  Tim

  ==
 ERROR: Test if line aggregation works
 --
 Traceback (most recent call last):
   File
 /home/timlinux/dev/python/inasafe-dev/safe/impact_statistics/test/test_aggregator.py,
 line 596, in test_line_aggregation
 impact_layer_attributes=impact_layer_attributes)
   File
 /home/timlinux/dev/python/inasafe-dev/safe/impact_statistics/test/test_aggregator.py,
 line 338, in _aggregate
 aggregator.aggregate(impact_layer)
   File
 /home/timlinux/dev/python/inasafe-dev/safe/impact_statistics/aggregator.py,
 line 527, in aggregate
 qgis_impact_layer, safe_impact_layer)
   File
 /home/timlinux/dev/python/inasafe-dev/safe/impact_statistics/aggregator.py,
 line 634, in _aggregrate_vector_impact
 self._aggregate_line_impact(safe_impact_layer)
   File
 /home/timlinux/dev/python/inasafe-dev/safe/impact_statistics/aggregator.py,
 line 920, in _aggregate_line_impact
 res = self.processing.runalg('qgis:intersection',
 AttributeError: 'module' object has no attribute 'runalg'




  --

 --
  Tim Sutton
 Visit http://kartoza.com to find out about open source:
  * Desktop GIS programming services
  * Geospatial web development
 * GIS Training
 * Consulting Services
  Skype: timlinux Irc: timlinux on #qgis at freenode.net
  Tim is a member of the QGIS Project Steering Committee

 ---
 Kartoza is a merger between Linfiniti and Afrispatial


 ___
 Qgis-developer mailing 
 listQgis-developer@lists.osgeo.orghttp://lists.osgeo.org/mailman/listinfo/qgis-developer



 ___
 Qgis-developer mailing list
 Qgis-developer@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/qgis-developer



 ___
 Qgis-developer mailing list
 Qgis-developer@lists.osgeo.org
 http://lists.osgeo.org/mailman/listinfo/qgis-developer




-- 
--
Tim Sutton
Visit http://kartoza.com to find out about open source:
 * Desktop GIS programming services
 * Geospatial web development
* GIS Training
* Consulting Services
Skype: timlinux Irc: timlinux on #qgis at freenode.net
Tim is a member of the QGIS Project Steering Committee
---
Kartoza is a merger between Linfiniti and Afrispatial
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer