Re: [qmailadmin] upgraded, no change to behavior
On Thu, 2003-03-06 at 08:38, Jesse Guardiani wrote: On Thursday 06 March 2003 09:23, Rick Romero wrote: On Thu, 2003-03-06 at 08:04, Jesse Guardiani wrote: On Thursday 06 March 2003 00:08, Tom Collins wrote: snip Anyway, the point of this is: I'd love to see this thing in the next production release. Is anyone planning a new production release soon? Or is it still up in the air? Kinda of along these lines, I've implemented the use of a FORM to automatically log users into qmailadmin from IMP. I've noticed on my mailbox, with 50MB in it, the main_menu takes a couple seconds to load.. I think it's because of the 'du'. I hate re-inventing the wheel, so I HAVE to ask why is there a 'du' for doing quotas, when that should already exist in maildirsize? I have my own hack to qmailadmin that I would like to see in the 'release' but I haven't heard any interest in it, so I haven't cleaned anything up. Should I cleanup, and add ifdefs to my 'Service Level' stuff? It current form only works with MySQL, and vpopmail also has to be modified. Hi Rick, Sounds like you have some cleanup work to do. Generally, I think any developer would much rather include a patch that is clean, clear, and works in as many different environments as possible under as many different circumstances as possible with a minimum of confusion on the user's part. snip Whoops, I meant to add - Is anyone interested in that functionality? I've sent my patches to the vpopmail list for 'documentation' purposes, but nobody has expressed any interest either way. They're small enough that patching my own version of qmailadmin for the next year will take less time that cleaning it up, and making it work for everyone. So I ask, does anyone want that functionality in qmailadmin, and/or does anyone have suggestions of a better way to do it, than what I submitted to the vpopmail list (because it requires a patch to vpopmail also). Frankly, I don't consider myself a programmer, and I know it would take me longer than I'd like to spend on it ;) I spent at least an hour last night trying to get yesterday's date from Perl. Yes, I know date()-86000, but apparently that doesn't work if you happen to also 'use Date::something'.. grumble.. can't remember offhand, but an hour to get 'yesterday'? I'm not going to tackle making this work for everyone, if no one else is interested. My wife would kill me :) Rick snip snip
Re: [qmailadmin] upgraded, no change to behavior
On Thursday 06 March 2003 11:37, Rick Romero wrote: On Thu, 2003-03-06 at 08:38, Jesse Guardiani wrote: On Thursday 06 March 2003 09:23, Rick Romero wrote: On Thu, 2003-03-06 at 08:04, Jesse Guardiani wrote: On Thursday 06 March 2003 00:08, Tom Collins wrote: snip Anyway, the point of this is: I'd love to see this thing in the next production release. Is anyone planning a new production release soon? Or is it still up in the air? Kinda of along these lines, I've implemented the use of a FORM to automatically log users into qmailadmin from IMP. I've noticed on my mailbox, with 50MB in it, the main_menu takes a couple seconds to load.. I think it's because of the 'du'. I hate re-inventing the wheel, so I HAVE to ask why is there a 'du' for doing quotas, when that should already exist in maildirsize? I have my own hack to qmailadmin that I would like to see in the 'release' but I haven't heard any interest in it, so I haven't cleaned anything up. Should I cleanup, and add ifdefs to my 'Service Level' stuff? It current form only works with MySQL, and vpopmail also has to be modified. Hi Rick, Sounds like you have some cleanup work to do. Generally, I think any developer would much rather include a patch that is clean, clear, and works in as many different environments as possible under as many different circumstances as possible with a minimum of confusion on the user's part. snip Whoops, I meant to add - Is anyone interested in that functionality? I've sent my patches to the vpopmail list for 'documentation' purposes, but nobody has expressed any interest either way. They're small enough that patching my own version of qmailadmin for the next year will take less time that cleaning it up, and making it work for everyone. So I ask, does anyone want that functionality in qmailadmin, and/or does anyone have suggestions of a better way to do it, than what I submitted to the vpopmail list (because it requires a patch to vpopmail also). Frankly, I don't consider myself a programmer, and I know it would take me longer than I'd like to spend on it ;) I spent at least an hour last night trying to get yesterday's date from Perl. Yes, I know date()-86000, but apparently that doesn't work if you happen to also 'use Date::something'.. grumble.. can't remember offhand, but an hour to get 'yesterday'? I'm not going to tackle making this work for everyone, if no one else is interested. My wife would kill me :) I hear ya. That's the name of the game really: Is it worth it? Most of the patches I submit are critical to our customer's happiness. It would be a massive drain on my resources to maintain a patch from release to release, so I much prefer to submit it to the maintainers. Besides, no-one else in my company can write a bit of code, so if I were to leave, my code would leave with me because they wouldn't be able to maintain the patches internally. I consider that bad practice and unacceptable behavior. So... my boss tends to allow me to take the time necessary to make sure my patches are professional, complete, and most importantly: Included in the distribution. As for the functionality: Yes, I'm interested, but maybe not the way you implemented it. (Then again, maybe.) I've been contemplating the very same thing lately, but I'd like to explore all of my other options too. Have a great day! Rick snip snip -- Jesse Guardiani, Systems Administrator WingNET Internet Services, P.O. Box 2605 // Cleveland, TN 37320-2605 423-559-LINK (v) 423-559-5145 (f) http://www.wingnet.net We are actively looking for companies that do a lot of long distance faxing and want to cut their long distance bill by up to 50%. Contact [EMAIL PROTECTED] for more info.
[qmailadmin] qmailadmin-1.0.12 - images problem
I'm using the new feature --enable-imageurl= It works fine except at the login page and the main menu. The problem is in the files list below main_menu.html show_login.html show_login_help.html
[qmailadmin] qmailadmin-1.0.12 - quota problem - bug fix
I found a bug,
if you set a quota for a user
the qmailadmin convert from MB to bytes with .00 at
the end.
---
File util.c
int quota_to_bytes(char returnval[], char *quota)
{ char *tmpstr; double
tmp;
if (quota == NULL) { return 1;
} if (tmp = atol(quota)) { tmp *= 1048576;
} else { return 1; }
sprintf(returnval, "%-2.2lf",
tmp);
---bug return
0;}
---
sprintf(returnval, "%-2.0lf",
tmp);
correction
^^
Re: [qmailadmin] qmailadmin-1.0.12 - quota problem - bug fix
Yes, this was discovered over a month ago (I posted a patch
way back when), but it appears that it didn't get included.
I'm actually working on updating qmailadmin vqadmin to
use the vlimits API and the maildir++ quotas functions.
I'll send a patch as soon as its ready.
Thanks,
Brian
I found a bug,
if you set a quota for a user
the qmailadmin convert from MB to bytes with .00 at the end.
---
File util.c
int quota_to_bytes(char returnval[], char *quota) {
char *tmpstr;
double tmp;
if (quota == NULL) { return 1; }
if (tmp = atol(quota)) { tmp *= 1048576; }
else { return 1; }
sprintf(returnval, %-2.2lf, tmp); ---
bug
return 0;
}
---
sprintf(returnval, %-2.0lf, tmp);
correction
^^
[qmailadmin] different image directory
hi, how do i set the image dir, to different directory than on apache root dir. or where to modify to set the html point to different image directory ? thanks Luqman.H www.unhas.ac.id/~luqe
Re: [qmailadmin] qmailadmin-1.0.12 - images problem - PATCH
On Thursday, March 6, 2003, at 11:15 AM, Alexandre Barbosa wrote: I'm using the new feature --enable-imageurl= It works fine except at the login page and the main menu. The problem is in the files list below main_menu.html show_login.html show_login_help.html Here's a patch that fixes this problem. I've added the macro ##Z to substitute the images directory in the HTML code. It's just a quick fix, but I went ahead and organized the macros in template.c to be in alphabetical order to make finding them (and finding available macros) easier. I also added a missing break on option 'O'. This bug didn't show up in earlier releases, because it would insert the output of ##P in the middle of a SELECT tag. Something that most (all?) browsers would ignore. patch-1.0.12-tc.txt.gz Description: GNU Zip compressed data -- Tom Collins [EMAIL PROTECTED]
Re: [qmailadmin] upgraded, no change to behavior
On Thursday, March 6, 2003, at 07:58 AM, Brian Kolaci wrote: From IMP, I do a du for regular system users, and use vuserinfo to get the quota. Its much faster. Will vuserinfo report usage if the account is set to NOQUOTA? I'm not using quotas, but my customers have found it very helpful to see how much disk space each account is using. I just ran vuserinfo on one of my accounts, and it reported NOQUOTA for both quota and usage. I'm using vpopmail 5.2. -- Tom Collins [EMAIL PROTECTED]
