Re: [qmailadmin] Template problem?
Rick Widmer wrote: First, I suggest you try something like adding H1HERE I AM!/H1 in the footer.html file just above the /body tag, then load a QmailAdmin page. This will let you make sure you are really using the template files you think you are. this is working proplery, the footer loads with the additional test html. Once you are sure which template files are being used, look in the file colortable. This view source output tells me the first line is: 000 #FF the colortable file is correct -- 000 #ff 001 #00 002 #cc 003 #cfcfcf 004 #e6e6e6 It should be: 000 #FF Once we know what _is_ there, we have a better idea where to look. Rick Just for testing, I changed 000 #ff to 000 #00 in the colortable file. The html was truncated again (with the different color code) tr bgcolor=#00td align=left. I've also tried downgrading to older releases with the same situation. I don't believe I was not having problems with these relases previously. I've also used lynx on the server to load the page and changed to a source view. The html shows truncated there as well. I guess that rules out somthing local at my location. Brandon
Re: [qmailadmin] Template problem? PATCH
On Jan 7, 2004, at 6:30 AM, Brandon Weisz wrote:
Just for testing, I changed 000 #ff to 000 #00 in the
colortable file. The html was truncated again (with the different
color code) tr bgcolor=#00td align=left. I've also tried
downgrading to older releases with the same situation. I don't
believe I was not having problems with these relases previously.
I've also used lynx on the server to load the page and changed to a
source view. The html shows truncated there as well. I guess that
rules out somthing local at my location.
Wow. I just found the bug in get_color_text(). It's returning a
pointer to a buffer in the function, but that buffer isn't declared
static. So, there's no guarantee that it won't disappear or get munged
before it is used. get_quota_used() suffered from the same problem.
Try this diff and see if it fixes the problem:
===
RCS file: /cvsroot/qmailadmin/qmailadmin/util.c,v
retrieving revision 1.3
diff -u -r1.3 util.c
--- util.c 8 Dec 2003 17:52:12 - 1.3
+++ util.c 7 Jan 2004 15:20:54 -
@@ -316,7 +316,7 @@
char *get_color_text( char *index )
{
- char tmpbuf[400];
+ static char tmpbuf[400];
char *tmpstr;
if (color_table == NULL) return();
@@ -333,8 +333,7 @@
}
/* bk - use maildir++ quotas now
char *get_quota_used(char *dir) {
-char *tmpstr;
-char tmpbuff[MAX_BUFF];
+static char tmpbuff[40];
double size;
size = get_du(dir);
@@ -342,8 +341,7 @@
size = size / 1048576;
}
sprintf(tmpbuff, %.2lf, size);
-tmpstr = tmpbuff;
-return tmpstr;
+return tmpbuff;
}
*/
/* quota_to_bytes: used to convert user entered quota (given in MB)
--
Tom Collins - [EMAIL PROTECTED]
QmailAdmin: http://qmailadmin.sf.net/ Vpopmail: http://vpopmail.sf.net/
Info on the Sniffter hand-held Network Tester: http://sniffter.com/
Re: [qmailadmin] SOLVED - Template problem? PATCH
Tom Collins wrote: Wow. I just found the bug in get_color_text(). It's returning a pointer to a buffer in the function, but that buffer isn't declared static. So, there's no guarantee that it won't disappear or get munged before it is used. get_quota_used() suffered from the same problem. Try this diff and see if it fixes the problem: Great, This patch fixes my problem. The page now renders properly. Thanks Tom! Brandon === RCS file: /cvsroot/qmailadmin/qmailadmin/util.c,v retrieving revision 1.3 diff -u -r1.3 util.c --- util.c 8 Dec 2003 17:52:12 - 1.3 +++ util.c 7 Jan 2004 15:20:54 -
Re: [qmailadmin] spam assassin support
On Tue, 06 Jan 2004 22:29:14 -0600 David Rodgers [EMAIL PROTECTED] wrote: DR how hard would it be to add a seconf spam command check box for DR DR instance one checkbox that made it use one filter and DR a different check box to use another? And third, and fourth, and so on? I guess there will be, one day, annother pannel to configure user preferences, and better, much better, not hacked around, way to integrate vpopmail, qmailadmin and spamassassin... -- Alex.
Re: [qmailadmin] spam assassin support
David Rodgers wrote: how hard would it be to add a seconf spam command check box for instance one checkbox that made it use one filter and a different check box to use another? Hi David, I hacked mine to have two --enable-spam-commands: --enable-spam-command-local and --enable-spam-command-forward. There was a little bit of work in user.c to allow it to insert the appropriate one into .qmail based on whether the Routing checkbox was for Standard delivery or Forward delivery and to fix the list of forwards (nforward) to play both ways (i.e. with/without and \n). The vast majority of the work is in all the files used to actually configure and build qmailadmin. I think I had to change five of them to get it to accept the new configure options and to pass them correctly. I'm not a c programmer but the code is written well enough for even me to follow and modify (good job, Tom). I don't really think anybody really wants to implement this in qmailadmin but if you don't mind hacking your own version I have a set of patches that, if you are interested, I will send you off-list. You might be able to apply them to your needs. fwiw, Mike Wright
[qmailadmin] IDN-Domains
Hi, today I thought about the new domain names with some country specific chars (IDN-Domains), like they are offered for com/net/org already and for some European domains (de etc.) from March 1st on. Is it right, that if I want to login into qmailadmin, that I would have to enter the punycode-encoded domain name? That is bad for customers, because they normally don't remember their punycode-domainname, but only their domain name with the special characters. For example, the domain schülerzeitung.net would be xn--schlerzeitung-yob.net Is it possible to integrate that conversion into qmailadmin like the webbrowser does it? greetings, Philipp PS: I would do the CSS-stuff for the templates, if it's time for that.
