Re: [qmailadmin] Working on new 1.0.7 version

2003-01-14 Thread Ken Jones 
On Monday 13 January 2003 08:10 pm, Michael Bowe wrote:
  -Original Message-
  From: Ken Jones [mailto:[EMAIL PROTECTED]]
  Sent: Friday, 10 January 2003 7:49 AM
  To: [EMAIL PROTECTED]
  Subject: [qmailadmin] Working on new 1.0.7 version
 
  I'm putting together a new 1.0.7 version.
  So anyone with updated code, or bug reports.
  Please post the information here.

 On the Email Accounts screen, at the top of the page, a count of the
 total number of email accounts is displayed

 In qmailadmin-1.0.4 this count was labelled Total:

 In qmailadmin-1.0.5 and later, the wording there incorrectly says Total
 Moderators:

 This is because token 228 was altered in the html/en file for the 1.0.5
 release.

 I took a bit of a look through the html/en file to see if there was another
 suitable token to use, however I didn't see any likely candidates.
 Therefore I would suggest that a new token be created (maybe call it Total
 Accounts: or something like that), and the template updated accordingly.

 Michael

Added a new line to the end of the language files for Total Accounts.

Also added a line for Prefix on the add mailing list screen. It was showing
Quota (MB).

Ken Jones

RE: [qmailadmin] Working on new 1.0.7 version

2003-01-13 Thread Michael Bowe 
 -Original Message-
 From: Ken Jones [mailto:[EMAIL PROTECTED]] 
 Sent: Friday, 10 January 2003 7:49 AM
 To: [EMAIL PROTECTED]
 Subject: [qmailadmin] Working on new 1.0.7 version
 
 I'm putting together a new 1.0.7 version. 
 So anyone with updated code, or bug reports.
 Please post the information here.

In the mailing list menus, you have menus to show 
subscribers / moderators / digest subscribers

This patch fixes two issues with this area :

 1. Make the menu layout more consistent with other parts
of qmailadmin. ie put the email address on the left and
the action button on the right 

 2. In the show subscribers menu, the column headings were
the reverse of the data. ie the action button was in the
address column, and the address was in the action column.


Michael Bowe (B.App.Sc)
Managing Director - Pipeline Internet
96 Pakington Street, Geelong West. VIC. 3218
Tel (03) 5229 7643
Fax (03) 5229 0282
Mobile 0419 242 136
http://www.pipeline.com.au/
  

##
## In the mailing list menus, you have menus to show 
## subscribers / moderators / digest subscribers
##
## This patch fixes two issues with this area :
##   1. Make the menu layout more consistent with other parts
##  of qmailadmin. ie put the email address on the left and
##  the action button on the right 
##   2. In the show subscribers menu, the column headings were
##  the reverse of the data. ie the action button was in the
##  address column, and the address was in the action column.
##
##  Michael Bowe [EMAIL PROTECTED] 14/1/2003
##
##

--- mailinglist.c   Wed Aug  7 08:04:59 2002
+++ ../../qmailadmin-1.0.6/mailinglist.cTue Jan 14 12:46:13 2003
@@ -609,9 +609,9 @@
 
 /* Display subscriber/moderator/digest list, along with delete button */
 if(mod == 1) {
-strcpy(TmpBuf, 228); strcpy(TmpBuf1, 087); strcpy(TmpBuf2, 220);
+strcpy(TmpBuf, 228); strcpy(TmpBuf1, 220); strcpy(TmpBuf2, 087);
 } else if(mod == 2) {
-strcpy(TmpBuf, 244); strcpy(TmpBuf1, 245); strcpy(TmpBuf2, 246);
+strcpy(TmpBuf, 244); strcpy(TmpBuf1, 246); strcpy(TmpBuf2, 245);
 } else {
 strcpy(TmpBuf, 230); strcpy(TmpBuf1, 222); strcpy(TmpBuf2, 084);
 }
@@ -635,14 +635,14 @@
 }
 for(z = 0; z  index; ++z) {
   fprintf(actout, TR align=middle);
+  fprintf(actout,  TD align=left%s/TD\n, pa[z]);
   fprintf(actout,  TD align=middleA 
href=%s/com/%s?modu=%snewu=%sdom=%suser=%stime=%dIMG 
src=/images/qmailadmin/delete.png border=0/A/TD\n,
 CGIPATH, TmpBuf, ActionUser, pa[z], Domain, Username, Mytime);
-  fprintf(actout,  TD align=left%s/TD\n, pa[z]);
   ++z;
   if(pa[z] != NULL) {
+  fprintf(actout,  TD align=left%s/TD\n, pa[z]);
 fprintf(actout,  TD align=middleA 
href=%s/com/%s?modu=%snewu=%sdom=%suser=%stime=%dIMG 
src=/images/qmailadmin/delete.png border=0/A/TD\n,
   CGIPATH, TmpBuf, ActionUser, pa[z], Domain, Username, Mytime);
-fprintf(actout,  TD align=left%s/TD, pa[z]);
   } else {
 fprintf(actout,  TD COLSPAN=2 /TD);
   }

[qmailadmin] Working on new 1.0.7 version

2003-01-09 Thread Ken Jones 
Hi,

I'm putting together a new 1.0.7 version. 
So anyone with updated code, or bug reports.
Please post the information here.

Paul Theodoropoulos: I have your posting
about the file permissions error. I'll try to
update the code.

Main change I needed was an easier way to
automatically log into qmailadmin via a url link.
Does anyone see a problem with that? 
Besides the obvious possibility of seeing the
login information in the url link.

A typical URL would be similar to:
https://hostname/cgi-bin/qmailadmin?username=postmaster
domain=somedomain.compassword=postmaster_password

Ken Jones

RE: [qmailadmin] Working on new 1.0.7 version

2003-01-09 Thread Jessie Bryan 

Im not sure it 1.0.7 will have it or not, but the quota patch for 
1.0.6 worked great. Would it be possible to integrate this into 1.0.7

I believe Yavuz Aydin wrote it
http://laguna.qweb.nl/contrib/qmailadmin/qmailadmin-1.0.6-quota.tar.gz

RE: [qmailadmin] Working on new 1.0.7 version

2003-01-09 Thread Michael Bowe 
 -Original Message-
 From: Ken Jones [mailto:[EMAIL PROTECTED]] 
 Sent: Friday, 10 January 2003 7:49 AM
 To: [EMAIL PROTECTED]
 Subject: [qmailadmin] Working on new 1.0.7 version
 
 
 Hi,
 
 I'm putting together a new 1.0.7 version. 
 So anyone with updated code, or bug reports.
 Please post the information here.

Hello Ken

Please find attached four patches for qmailadmin-1.0.6 that fix an
assortment of bugs and cosmetic issues. There are comments in the top bit of
each of the patches that include a more detailed description of why they are
needed.

qmailadmin-1.0.6-forwardalias-nextpage.patch.txt
  Fix the bug in the forwards/aliases screen where the nextpage hyperlink
  is shown even when there are no more users to display 

qmailadmin-1.0.6-configure-maxaliasesperpage.patch.txt
  Fix the typo in the configure script regarding the maxaliasesperpage
option

qmailadmin-1.0.6-forwardalias-sorted.patch.txt
  Enable sorting of the userlist on the forwards/aliases screen
  (Same as patch for qmailadmin-1.0.2 as posted to this list the 
  other day by Tim Janes)

qmailadmin-1.0.6-userlist-sorted.patch.txt
  Enable alphabetical sorting of the email accounts screens and also
  the userlist dropdownboxes for people using a vpopmail backend 
  other than cdb (eg MySQL). 
  The cdb backend already provides alphabetical sorting, so it makes
  sense that the other backends should be configured to provide
  alphabetical sorting by default also.


Michael Bowe (B.App.Sc)
Managing Director - Pipeline Internet
96 Pakington Street, Geelong West. VIC. 3218
Tel (03) 5229 7643
Fax (03) 5229 0282
Mobile 0419 242 136
http://www.pipeline.com.au/
  


###
#
# The configure script for qmailadmin-1.0.6 contains a typo for the 
# maxaliasesperpage configure command 
#
# By Michael Bowe  [EMAIL PROTECTED]
#
###

--- configure.orig  Sat Nov 30 12:02:49 2002
+++ configure   Sat Nov 30 12:02:54 2002
@@ -1778,7 +1778,7 @@
 # Check whether --enable-maxaliasesperpage or --disable-maxaliasesperpage was given.
 if test ${enable_maxaliasesperpage+set} = set; then
   enableval=$enable_maxaliasesperpage
-  maxusersperpage=$enableval
+  maxaliasesperpage=$enableval
 fi
 
 cat  confdefs.h EOF

###
#
# In qmailadmin-1.0.6, the page navigation hyperlinks at the bottom
# of the show forwards/aliases screen alway display next page
# even when there are no more users to display
#
# By Michael Bowe [EMAIL PROTECTED]
#
###

--- alias.c.origSat Nov 30 12:56:39 2002
+++ alias.c Sat Nov 30 13:00:56 2002
@@ -46,6 +46,7 @@
 
 show_dotqmail_lines(char *user, char *dom, time_t mytime, char *dir)
 {
+ int moreusers=0;
  DIR *mydir;
  struct dirent *mydirent;
  FILE *fs;
@@ -89,6 +90,7 @@
 continue;
   }
   if ( k MAXALIASESPERPAGE + startnumber) {
+moreusers=1;
 break;
   }
 
@@ -174,9 +176,11 @@
 fprintf(actout, a 
href=\%s/com/showforwards?user=%sdom=%stime=%dpage=%s\%s/a,
   CGIPATH,user,dom,mytime,Pagenumber,get_html_text(136));
 fprintf(actout, nbsp;|nbsp;);
-fprintf(actout, a 
href=\%s/com/showforwards?user=%sdom=%stime=%dpage=%d\%s/a,
-  CGIPATH,user,dom,mytime,atoi(Pagenumber)+1,get_html_text(137));
-fprintf(actout, nbsp;]);
+if (moreusers) {
+  fprintf(actout, a 
+href=\%s/com/showforwards?user=%sdom=%stime=%dpage=%d\%s/a,
+CGIPATH,user,dom,mytime,atoi(Pagenumber)+1,get_html_text(137));
+  fprintf(actout, nbsp;]);
+}
 fprintf(actout, /td/tr);
   }
 }

###
#
# Adjust qmailadmin-1.0.6 so that the entries on the 
# forwards/aliases screen are shown in alphabetical order
#
# Written for qmailadmin-1.0.2 by Tim Janes [EMAIL PROTECTED]
# and applied to qmailadmin-1.0.6 by Michael Bowe [EMAIL PROTECTED]
#
###
 
--- alias.c.origWed Aug  7 08:04:59 2002
+++ alias.c Sat Nov 30 11:35:24 2002
@@ -53,6 +53,8 @@
  char alias_name[MAX_FILE_NAME];
  char *alias_name_from_command;
  int i,j,stop,k,startnumber;
+ int m,n;
+ struct dirent **namelist;
 
   if ( AdminType!=DOMAIN_ADMIN ) {
 sprintf(StatusMessage,%s, get_html_text(142));
@@ -74,7 +76,10 @@
 return(0);
   }
 
-  while ((mydirent=readdir(mydir)) != NULL) {
+  n = scandir(., namelist, 0, alphasort);
+  
+  for (m=0; mn; m++) {
+mydirent=namelist[m];
 /*
  *  don't read files that are really ezmlm-idx listowners,
  *  i.e. .qmail-user-owner
@@ -159,9 +164,11 @@
   fclose(fs);
   k++;
 }
+free(namelist[m]);
   }
 
   closedir(mydir

Re: [qmailadmin] Working on new 1.0.7 version

2003-01-09 Thread Rick Widmer 
At 02:49 PM 1/9/03 -0600, Ken Jones wrote:



Main change I needed was an easier way to
automatically log into qmailadmin via a url link.
Does anyone see a problem with that?
Besides the obvious possibility of seeing the
login information in the url link.


Loud cheer!



A typical URL would be similar to:
https://hostname/cgi-bin/qmailadmin?username=postmaster
domain=somedomain.compassword=postmaster_password



Do you have it working already, or should I update my patch that adds this 
ability?


Rick



Ken Jones

Re: [qmailadmin] Working on new 1.0.7 version

2003-01-09 Thread Iain 
It would be great to see the patches for proper sorting incorporated into this 
version. They were posted on this list a little while ago.

cheers, Iain.

On Fri, 10 Jan 2003 07:49, Ken Jones wrote:
 Hi,

 I'm putting together a new 1.0.7 version.
 So anyone with updated code, or bug reports.
 Please post the information here.

 Paul Theodoropoulos: I have your posting
 about the file permissions error. I'll try to
 update the code.

 Main change I needed was an easier way to
 automatically log into qmailadmin via a url link.
 Does anyone see a problem with that?
 Besides the obvious possibility of seeing the
 login information in the url link.

 A typical URL would be similar to:
 https://hostname/cgi-bin/qmailadmin?username=postmaster
 domain=somedomain.compassword=postmaster_password

 Ken Jones