Re: [Qt-creator] lupdate_only broken ?

2016-06-20 Thread Benjamin TERRIER 
2016-06-20 9:31 GMT+02:00 Eike Ziller :
>
>> On Jun 17, 2016, at 5:29 PM, Benjamin TERRIER  wrote:
>>
>> Hi everyone,
>>
>> I've just noticed, after upgrading to 4.0.3 that my qml files were
>> listed as "Sources”.
>
> What did you use before?
>
> Anyhow, see e.g. https://bugreports.qt.io/browse/QTCREATORBUG-15619
>
> Br, Eike
>

Hi,

I've used every version of Qt Creator, so it seems I didn't notice it
but the behavior was introduced some versions before (I'm pretty sure
it wasn't there when I set up the project).
Anyhow I have seen that there is a change request in gerrit to get rid
of lupdate_only, which I think is nice.

BR,

Benjamin


>> It seems to be caused by :
>>
>>QML_FILES += *.qml
>>lupdate_only {
>> SOURCES += $$QML_FILES
>>}
>>
>> However doing this:
>>QML_FILES += *.qml
>>lupdate_only {
>>   SOURCES += $$QML_FILES
>>   message (1)
>>}
>>else
>>{
>>message (2)
>>}
>>
>> displays "Project MESSAGE: 2" as expected.
>>
>> Should I file a bug ?
>>
>> BR,
>>
>> Benjamin Terrier
>> ___
>> Qt-creator mailing list
>> Qt-creator@qt-project.org
>> http://lists.qt-project.org/mailman/listinfo/qt-creator
>
> --
> Eike Ziller
> Principal Software Engineer
>
> The Qt Company GmbH
> Rudower Chaussee 13
> D-12489 Berlin
> eike.zil...@qt.io
> +123 45 6789012
> http://qt.io
> Geschäftsführer: Mika Pälsi, Juha Varelius, Tuula Haataja
> Sitz der Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, 
> HRB 144331 B
>
>
>
___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

Re: [Qt-creator] lupdate_only broken ?

2016-06-18 Thread ekke 
valid points

I also noticed that they're listed twice and because all my apps use
lupdate,
I was happy to remove QML entry and have to manage my sub folders for
qml files only once ;-)

Am 18.06.16 um 15:38 schrieb Benjamin TERRIER:
> Why I disagree:
>  - I do not like them listed in "Sources" as the UI makes it clear
> that "Sources" contains C/C++ code (see the icon).
>  - Also "SOURCES" is understood by qmake as C/C++ source files which
> must be compiled. QML files are not SOURCES in this aspect.
>  - Your solution is to trick qmake and Qt Creator by using a lupdate
> feature, which I do not find elegant.
>Projects which do not support translations shouldn't have to use
> "lupdate_only" to trick Qt Creator to display QML files.
>  - Qt Creator displays QML files in a specific "QML" entry in the
> project explorer, so now I get them listed twice: once in QML and once
> in Sources (and even one more time if I use a qrc).
>
> A similar issue I have is that now files used as input by extra
> compilers (QMAKE_EXTRA_COMPILERS) are now listed in Sources, whereas
> you had to add them to OTHER_FILES to get them listed in QtCreator
> before.
> So now they get listed twice when using old projects (or they will not
> get listed anywhere if people open a new project with an old Qt
> Creator). Maybe it would be possible to ensure that files only get
> listed once in the project explorer.
>
> BR,
>
> Benjamin
>
> 2016-06-17 19:54 GMT+02:00 ekke :
>> For me QML files are also SOURCES, so from my POV it's great to get them
>> under Sources listed.
>>
>> see this screenshot
>> https://appbus.files.wordpress.com/2016/06/project_structure_tabbar.png
>> from my Qt 5.7 Example app http://bit.ly/qt-tab-pages-x
>>
>> it's easier instead of managing QML files extra to get them listed
>>
>> ekke
>>
>> Am 17.06.16 um 17:29 schrieb Benjamin TERRIER:
>>> Hi everyone,
>>>
>>> I've just noticed, after upgrading to 4.0.3 that my qml files were
>>> listed as "Sources".
>>>
>>> It seems to be caused by :
>>>
>>> QML_FILES += *.qml
>>> lupdate_only {
>>>  SOURCES += $$QML_FILES
>>> }
>>>
>>> However doing this:
>>> QML_FILES += *.qml
>>> lupdate_only {
>>>SOURCES += $$QML_FILES
>>>message (1)
>>> }
>>> else
>>> {
>>> message (2)
>>> }
>>>
>>> displays "Project MESSAGE: 2" as expected.
>>>
>>> Should I file a bug ?
>>>
>>> BR,
>>>
>>> Benjamin Terrier
>>> ___
>>> Qt-creator mailing list
>>> Qt-creator@qt-project.org
>>> http://lists.qt-project.org/mailman/listinfo/qt-creator
>>>
>> ___
>> Qt-creator mailing list
>> Qt-creator@qt-project.org
>> http://lists.qt-project.org/mailman/listinfo/qt-creator
> ___
> Qt-creator mailing list
> Qt-creator@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/qt-creator
>

___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

Re: [Qt-creator] lupdate_only broken ?

2016-06-18 Thread Benjamin TERRIER 
Why I disagree:
 - I do not like them listed in "Sources" as the UI makes it clear
that "Sources" contains C/C++ code (see the icon).
 - Also "SOURCES" is understood by qmake as C/C++ source files which
must be compiled. QML files are not SOURCES in this aspect.
 - Your solution is to trick qmake and Qt Creator by using a lupdate
feature, which I do not find elegant.
   Projects which do not support translations shouldn't have to use
"lupdate_only" to trick Qt Creator to display QML files.
 - Qt Creator displays QML files in a specific "QML" entry in the
project explorer, so now I get them listed twice: once in QML and once
in Sources (and even one more time if I use a qrc).

A similar issue I have is that now files used as input by extra
compilers (QMAKE_EXTRA_COMPILERS) are now listed in Sources, whereas
you had to add them to OTHER_FILES to get them listed in QtCreator
before.
So now they get listed twice when using old projects (or they will not
get listed anywhere if people open a new project with an old Qt
Creator). Maybe it would be possible to ensure that files only get
listed once in the project explorer.

BR,

Benjamin

2016-06-17 19:54 GMT+02:00 ekke :
> For me QML files are also SOURCES, so from my POV it's great to get them
> under Sources listed.
>
> see this screenshot
> https://appbus.files.wordpress.com/2016/06/project_structure_tabbar.png
> from my Qt 5.7 Example app http://bit.ly/qt-tab-pages-x
>
> it's easier instead of managing QML files extra to get them listed
>
> ekke
>
> Am 17.06.16 um 17:29 schrieb Benjamin TERRIER:
>> Hi everyone,
>>
>> I've just noticed, after upgrading to 4.0.3 that my qml files were
>> listed as "Sources".
>>
>> It seems to be caused by :
>>
>> QML_FILES += *.qml
>> lupdate_only {
>>  SOURCES += $$QML_FILES
>> }
>>
>> However doing this:
>> QML_FILES += *.qml
>> lupdate_only {
>>SOURCES += $$QML_FILES
>>message (1)
>> }
>> else
>> {
>> message (2)
>> }
>>
>> displays "Project MESSAGE: 2" as expected.
>>
>> Should I file a bug ?
>>
>> BR,
>>
>> Benjamin Terrier
>> ___
>> Qt-creator mailing list
>> Qt-creator@qt-project.org
>> http://lists.qt-project.org/mailman/listinfo/qt-creator
>>
>
> ___
> Qt-creator mailing list
> Qt-creator@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/qt-creator
___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

Re: [Qt-creator] lupdate_only broken ?

2016-06-17 Thread ekke 
For me QML files are also SOURCES, so from my POV it's great to get them
under Sources listed.

see this screenshot
https://appbus.files.wordpress.com/2016/06/project_structure_tabbar.png
from my Qt 5.7 Example app http://bit.ly/qt-tab-pages-x

it's easier instead of managing QML files extra to get them listed

ekke

Am 17.06.16 um 17:29 schrieb Benjamin TERRIER:
> Hi everyone,
>
> I've just noticed, after upgrading to 4.0.3 that my qml files were
> listed as "Sources".
>
> It seems to be caused by :
>
> QML_FILES += *.qml
> lupdate_only {
>  SOURCES += $$QML_FILES
> }
>
> However doing this:
> QML_FILES += *.qml
> lupdate_only {
>SOURCES += $$QML_FILES
>message (1)
> }
> else
> {
> message (2)
> }
>
> displays "Project MESSAGE: 2" as expected.
>
> Should I file a bug ?
>
> BR,
>
> Benjamin Terrier
> ___
> Qt-creator mailing list
> Qt-creator@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/qt-creator
>

___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator

[Qt-creator] lupdate_only broken ?

2016-06-17 Thread Benjamin TERRIER 
Hi everyone,

I've just noticed, after upgrading to 4.0.3 that my qml files were
listed as "Sources".

It seems to be caused by :

QML_FILES += *.qml
lupdate_only {
 SOURCES += $$QML_FILES
}

However doing this:
QML_FILES += *.qml
lupdate_only {
   SOURCES += $$QML_FILES
   message (1)
}
else
{
message (2)
}

displays "Project MESSAGE: 2" as expected.

Should I file a bug ?

BR,

Benjamin Terrier
___
Qt-creator mailing list
Qt-creator@qt-project.org
http://lists.qt-project.org/mailman/listinfo/qt-creator