Re: [Rd] Query about .check_packages_used_in_examples
Sounds reasonable to count Imports, so we'll alter this.
Thank you for the report, However, the pre-test period for 2.12.0 is
already 80% over and we are in code freeze -- reports early on in the
period are much more useful and at this stage anything but very simple
localized changes need to be deferred to 2.12.1.
On Mon, 11 Oct 2010, Berwin A Turlach wrote:
G'day all,
sorry, should proof-read better before hitting the send button...
On Mon, 11 Oct 2010 06:06:46 +0800
Berwin A Turlach ber...@maths.uwa.edu.au wrote:
But then I noticed that for another package I have on R-forge a
similar note is issued:
https://r-forge.r-project.org/R/?group_id=630log=check_x86_64_linuxpkg=DeconWKflavor=devel
O.k., R-forge is using R-devel, so I installed R 2.12.0 RC (2010-10-10
r53273) on my machine to check, same note is issued.
The note issued by R CMD check says:
* checking for unstated dependencies in examples ... NOTE
'library' or 'require' call not declared from: ks
which is a bit surprising.
There are three .Rd files that have a library(ks) in them and ks is
listed in the Imports: of the description file.
This seems to be completely in line with the documentation in Writing
R extensions:
@item
Packages whose name space only is needed to load the package
using @code{library(@var{pkgname})} must be listed in the
@samp{Imports} field and not in the @samp{Depends} field.
that's why ks is listed in depends
ks is listed in the Imports: line in the DESCRIPTION file of the package
in question, not in the Depends: line.
@item
All packages that are needed to successfully run @code{R CMD
check} on the package must be listed in one of @samp{Depends}
or @samp{Suggests} or @samp{Imports}. [...]
which seems to be adhered to, since ks is in the depends.
Again, this depends should read Imports.
Sorry if this created confusion.
Cheers,
Berwin
__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel
--
Brian D. Ripley, rip...@stats.ox.ac.uk
Professor of Applied Statistics, http://www.stats.ox.ac.uk/~ripley/
University of Oxford, Tel: +44 1865 272861 (self)
1 South Parks Road, +44 1865 272866 (PA)
Oxford OX1 3TG, UKFax: +44 1865 272595
__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel
Re: [Rd] Query about .check_packages_used_in_examples
G'day Brian, On Mon, 11 Oct 2010 11:11:42 +0100 (BST) Prof Brian Ripley rip...@stats.ox.ac.uk wrote: Sounds reasonable to count Imports, so we'll alter this. Thanks for that. I noticed the changes to R-devel and to the R-2-12-branch. Looking at the diffs (an example is appended below), it seems to me that, except for the ordering, the variables `depends_suggests' and `imports' are the same. This would suggest that only one of them is necessary and that the remaining code could be made leaner... but probably that is something to do after the code freeze is over... Thank you for the report, However, the pre-test period for 2.12.0 is already 80% over and we are in code freeze -- reports early on in the period are much more useful and at this stage anything but very simple localized changes need to be deferred to 2.12.1. Point taken. When I am back home, I will think about what versions of R I want to have installed on my main machine... should probably also write some scripts that regularly check my packages... Cheers, Berwin ber...@goodenia:/opt/src/R-2-12-branch/src/library/tools/R$ svn diff -r53024 QC.R Index: QC.R === --- QC.R(revision 53024) +++ QC.R(working copy) @@ -3937,7 +3937,7 @@ ## it is OK to refer to yourself and standard packages standard_package_names - .get_standard_package_names()$base -depends_suggests - c(depends, suggests, enhances, pkg_name, +depends_suggests - c(depends, imports, suggests, enhances, pkg_name, standard_package_names) imports - c(imports, depends, suggests, enhances, pkg_name, standard_package_names) @@ -4038,7 +4038,7 @@ ## it is OK to refer to yourself and standard packages standard_package_names - .get_standard_package_names()$base -depends_suggests - c(depends, suggests, enhances, pkg_name, +depends_suggests - c(depends, imports, suggests, enhances, pkg_name, standard_package_names) imports - c(imports, depends, suggests, enhances, pkg_name, standard_package_names) __ R-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-devel
Re: [Rd] Query about .check_packages_used_in_examples
G'day all,
sorry, should proof-read better before hitting the send button...
On Mon, 11 Oct 2010 06:06:46 +0800
Berwin A Turlach ber...@maths.uwa.edu.au wrote:
But then I noticed that for another package I have on R-forge a
similar note is issued:
https://r-forge.r-project.org/R/?group_id=630log=check_x86_64_linuxpkg=DeconWKflavor=devel
O.k., R-forge is using R-devel, so I installed R 2.12.0 RC (2010-10-10
r53273) on my machine to check, same note is issued.
The note issued by R CMD check says:
* checking for unstated dependencies in examples ... NOTE
'library' or 'require' call not declared from: ks
which is a bit surprising.
There are three .Rd files that have a library(ks) in them and ks is
listed in the Imports: of the description file.
This seems to be completely in line with the documentation in Writing
R extensions:
@item
Packages whose name space only is needed to load the package
using @code{library(@var{pkgname})} must be listed in the
@samp{Imports} field and not in the @samp{Depends} field.
that's why ks is listed in depends
ks is listed in the Imports: line in the DESCRIPTION file of the package
in question, not in the Depends: line.
@item
All packages that are needed to successfully run @code{R CMD
check} on the package must be listed in one of @samp{Depends}
or @samp{Suggests} or @samp{Imports}. [...]
which seems to be adhered to, since ks is in the depends.
Again, this depends should read Imports.
Sorry if this created confusion.
Cheers,
Berwin
__
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel
