Re: [R-pkg-devel] Package update submission to CRAN fails on pretest
Dear Hadley, many thanks for your comment and much more for your fantastic tutorial and packages! I essentially learned (and still learn) package development by your tutorial. In the concrete case, changing some settings finally did it and devtools worked like charm. I want to thank you for your really great work. There was a strange thing, though, that I do not yet understand. The submission failed on some systems (fedora and Mac OS X; not on Win and Ubuntu) because of errors building the vignette. Adding rmarkdown to imports in the description file solved the pretest rejection and the new version of cNORM is on CRAN, but now, I have the following note: checking dependencies in R code ... NOTE Namespace in Imports field not imported from: ‘rmarkdown’ All declared Imports should be used. Apart from the note, it works now. Maybe, I remove the code from the vignette in future releases and. Best regards, Wolfgang Am 08.12.2018 um 15:31 schrieb Hadley Wickham: You might try reinstalling devtools and dependencies - there was unfortunately a brief combination of versions that lead to build() failing to overwrite existing files. Hadley On Fri, Dec 7, 2018 at 10:46 AM Wolfgang Lenhard wrote: Many thanks for the remark. It seems, it has something to do with submitting via the devtools (maybe I did something wrong with tagging the prior release). Submitting it manually at least does not result in pretest rejection. I guess there is something out of sync which resulted in rechecking and old version. Am 07.12.2018 um 13:46 schrieb Georgi Boshnakov: The link you gave, https://cran.r-project.org/web/checks/check_results_cNORM.html, is to the check results for the package currently on CRAN and it is indeed v. 1.0.1 (it is linked from https://CRAN.R-project.org/package=cNORM). Was this really the link you got from CRAN's pretest? Sometimes they ask if care has been taken about NOTEs/WARNINGs for the current CRAN version, since some tests are not done during submission, but this doesn't seem the case here. Georgi Boshnakov -Original Message- From: R-package-devel [mailto:r-package-devel-boun...@r-project.org] On Behalf Of Wolfgang Lenhard Sent: 07 December 2018 07:55 To: r-package-devel@r-project.org Subject: [R-pkg-devel] Package update submission to CRAN fails on pretest Dear list, I am getting problems when trying to submit an update of the package cNORM to CRAN. I am developing the package with RStudio and devtools and I am using Travis for automatic testing. The package is tested locally on Win10 and Mac OS X and on Travis with Ubuntu and Mac both for development and release versions of R. All local tests and tests on Travis work flawlessly - no errors, warning or notes. When submitting to CRAN, a note and an error show up on some of the Linux OS (Fedora & Solaris) and Mac OS X, while others display an 'OK' (Win, Debian). The results: https://cran.r-project.org/web/checks/check_results_cNORM.html - error: This seems to be related to the vignette with the following message: * checking examples ... ERROR Running examples in ‘cNORM-Ex.R’ failed I can however not identify the location of the error - Note: Check: data for non-ASCII characters The strange thing is: I checked all data files multiple times. They mainly consist of data.frames with numerics and all colnames are ASCII. I am not able to replicate the issue. The same is true for the error, which does not show up on Travis and as well locally. And finally, the results state, that the version of the package is 1.0.1, which had been the first submission to CRAN a month ago. The current version of the package is 1.1.1. Could this be the reason for the problem? Do you have an idea how to progress with the testing or how to locate the errors? Any help is welcome. Best regards, Wolfgang Lenhard [[alternative HTML version deleted]] __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel -- Prof. Dr. Wolfgang Lenhard Lehrstuhl Psychologie IV Raum 02.130 Wittelsbacherplatz 1 D-97070 Würzburg Tel.: 0931 3189791 FAX: 0931 3184891 URL: https://go.uniwue.de/lenhard Map: https://go.uni-wuerzburg.de/3b __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
Re: [R-pkg-devel] Suggested package relies on recent R
Yes, I certainly will do that. I've checked on win-builder and the package
seems to pass, so my examples seem to be in good order.
David
On Sat, 8 Dec 2018 at 15:17, Dirk Eddelbuettel wrote:
>
> On 8 December 2018 at 14:41, David Hugh-Jones wrote:
> | Thanks guys. If CRAN already sets FORCE_SUGGESTS = false, then I think I
> | don't have a problem.
>
> I think you still do as long as you ignore Duncan's advice. It's not
> "just"
> about skirting CRAN tests and rules, it is about doing packaging right.
>
> For that, Suggests != Depends and you should test presence of optional
> ppackage just like Duncan showed you.
>
> Dirk
>
>
> | David
> |
> |
> | On Sat, 8 Dec 2018 at 14:36, Duncan Murdoch
> | wrote:
> |
> | > On 08/12/2018 9:28 AM, Hadley Wickham wrote:
> | > > Can you just set _R_CHECK_FORCE_SUGGESTS_=false?
> | > >
> | > > env:
> | > >global:
> | > ># don't treat missing suggested packages as error
> | > >- _R_CHECK_FORCE_SUGGESTS_=false
> | > >
> | > > I am reasonably certain that is what CRAN uses.
> | >
> | > Also make sure that examples fail gracefully if the suggested package
> is
> | > not present, i.e. wrap uses of the suggested package in
> | >
> | > if (requireNamespace(...)) { ... }
>
>
> --
> http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org
>
[[alternative HTML version deleted]]
__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel
Re: [R-pkg-devel] Suggested package relies on recent R
On 8 December 2018 at 14:41, David Hugh-Jones wrote:
| Thanks guys. If CRAN already sets FORCE_SUGGESTS = false, then I think I
| don't have a problem.
I think you still do as long as you ignore Duncan's advice. It's not "just"
about skirting CRAN tests and rules, it is about doing packaging right.
For that, Suggests != Depends and you should test presence of optional
ppackage just like Duncan showed you.
Dirk
| David
|
|
| On Sat, 8 Dec 2018 at 14:36, Duncan Murdoch
| wrote:
|
| > On 08/12/2018 9:28 AM, Hadley Wickham wrote:
| > > Can you just set _R_CHECK_FORCE_SUGGESTS_=false?
| > >
| > > env:
| > >global:
| > ># don't treat missing suggested packages as error
| > >- _R_CHECK_FORCE_SUGGESTS_=false
| > >
| > > I am reasonably certain that is what CRAN uses.
| >
| > Also make sure that examples fail gracefully if the suggested package is
| > not present, i.e. wrap uses of the suggested package in
| >
| > if (requireNamespace(...)) { ... }
--
http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org
__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel
Re: [R-pkg-devel] Suggested package relies on recent R
Thanks guys. If CRAN already sets FORCE_SUGGESTS = false, then I think I
don't have a problem.
David
On Sat, 8 Dec 2018 at 14:36, Duncan Murdoch
wrote:
> On 08/12/2018 9:28 AM, Hadley Wickham wrote:
> > Can you just set _R_CHECK_FORCE_SUGGESTS_=false?
> >
> > env:
> >global:
> ># don't treat missing suggested packages as error
> >- _R_CHECK_FORCE_SUGGESTS_=false
> >
> > I am reasonably certain that is what CRAN uses.
>
> Also make sure that examples fail gracefully if the suggested package is
> not present, i.e. wrap uses of the suggested package in
>
> if (requireNamespace(...)) { ... }
>
> Duncan Murdoch
>
>
> >
> > Hadley
> >
> > On Fri, Dec 7, 2018 at 9:11 AM David Hugh-Jones
> > wrote:
> >>
> >> Hi,
> >>
> >> My package Suggests a package that relies on R >= 3.5.0. My package
> works
> >> fine with earlier R, though. When travis runs R CMD check on R-oldrel,
> >> therefore, it fails because it can't install the suggested package.
> >>
> >> Is this going to stop me submitting to CRAN? I don't really want to
> require
> >> R 3.5.0 just to satisfy an optional dependency.
>
>
>
[[alternative HTML version deleted]]
__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel
Re: [R-pkg-devel] Package update submission to CRAN fails on pretest
You might try reinstalling devtools and dependencies - there was unfortunately a brief combination of versions that lead to build() failing to overwrite existing files. Hadley On Fri, Dec 7, 2018 at 10:46 AM Wolfgang Lenhard wrote: > > Many thanks for the remark. It seems, it has something to do with > submitting via the devtools (maybe I did something wrong with tagging > the prior release). Submitting it manually at least does not result in > pretest rejection. I guess there is something out of sync which resulted > in rechecking and old version. > > Am 07.12.2018 um 13:46 schrieb Georgi Boshnakov: > > The link you gave, > > https://cran.r-project.org/web/checks/check_results_cNORM.html, > > is to the check results for the package currently on CRAN and it is indeed > > v. 1.0.1 > > (it is linked from https://CRAN.R-project.org/package=cNORM). > > > > Was this really the link you got from CRAN's pretest? Sometimes they ask if > > care has been taken about NOTEs/WARNINGs for the current CRAN version, > > since some tests are not done during submission, but this doesn't seem the > > case here. > > > > Georgi Boshnakov > > > > > > -Original Message- > > From: R-package-devel [mailto:r-package-devel-boun...@r-project.org] On > > Behalf Of Wolfgang Lenhard > > Sent: 07 December 2018 07:55 > > To: r-package-devel@r-project.org > > Subject: [R-pkg-devel] Package update submission to CRAN fails on pretest > > > > Dear list, > > I am getting problems when trying to submit an update of the package > > cNORM to CRAN. I am developing the package with RStudio and devtools and > > I am using Travis for automatic testing. The package is tested locally > > on Win10 and Mac OS X and on Travis with Ubuntu and Mac both for > > development and release versions of R. All local tests and tests on > > Travis work flawlessly - no errors, warning or notes. When submitting to > > CRAN, a note and an error show up on some of the Linux OS (Fedora & > > Solaris) and Mac OS X, while others display an 'OK' (Win, Debian). The > > results: https://cran.r-project.org/web/checks/check_results_cNORM.html > > > > - error: This seems to be related to the vignette with the following > > message: > >> * checking examples ... ERROR > >> Running examples in ‘cNORM-Ex.R’ failed > > I can however not identify the location of the error > > > > - Note: Check: data for non-ASCII characters > > > > The strange thing is: I checked all data files multiple times. They > > mainly consist of data.frames with numerics and all colnames are ASCII. > > I am not able to replicate the issue. The same is true for the error, > > which does not show up on Travis and as well locally. And finally, the > > results state, that the version of the package is 1.0.1, which had been > > the first submission to CRAN a month ago. The current version of the > > package is 1.1.1. Could this be the reason for the problem? > > > > Do you have an idea how to progress with the testing or how to locate > > the errors? Any help is welcome. > > > > Best regards, > > Wolfgang Lenhard > > > > > > [[alternative HTML version deleted]] > > > > __ > > R-package-devel@r-project.org mailing list > > https://stat.ethz.ch/mailman/listinfo/r-package-devel > > -- > Prof. Dr. Wolfgang Lenhard > Lehrstuhl Psychologie IV > Raum 02.130 > Wittelsbacherplatz 1 > D-97070 Würzburg > > Tel.: 0931 3189791 > FAX: 0931 3184891 > URL: https://go.uniwue.de/lenhard > Map: https://go.uni-wuerzburg.de/3b > > __ > R-package-devel@r-project.org mailing list > https://stat.ethz.ch/mailman/listinfo/r-package-devel -- http://hadley.nz __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
Re: [R-pkg-devel] Suggested package relies on recent R
Can you just set _R_CHECK_FORCE_SUGGESTS_=false? env: global: # don't treat missing suggested packages as error - _R_CHECK_FORCE_SUGGESTS_=false I am reasonably certain that is what CRAN uses. Hadley On Fri, Dec 7, 2018 at 9:11 AM David Hugh-Jones wrote: > > Hi, > > My package Suggests a package that relies on R >= 3.5.0. My package works > fine with earlier R, though. When travis runs R CMD check on R-oldrel, > therefore, it fails because it can't install the suggested package. > > Is this going to stop me submitting to CRAN? I don't really want to require > R 3.5.0 just to satisfy an optional dependency. > > Cheers, > David > > [[alternative HTML version deleted]] > > __ > R-package-devel@r-project.org mailing list > https://stat.ethz.ch/mailman/listinfo/r-package-devel -- http://hadley.nz __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
