date:20200310

Re: [R-pkg-devel] Fwd: Re: [CRAN-pretest-archived] CRAN submission SSLR 0.9.0

2020-03-10 Thread Uwe Ligges


I do not speak roxygen, but you have to register the S3 method.

Best,
Uwe Ligges

On 10.03.2020 17:28, fpaloma...@correo.ugr.es wrote:

Hi, I thiks its weird:

The error is:  no applicable method for 'fit' applied to an object of 
class "model_sslr"


In the code:

#' fit
#'
#' @title fit object
#' @param object object
#' @param ... other parameters to be passed
#' @rdname fit
#' @export fit
fit <- function(object, ...){
   UseMethod("fit")
}


And:

#' @title Fit with formula and data
#' @description Funtion to fit through the formula
#' @param object is the model
#' @param formula is the formula
#' @param data is the total data train
#' @param ... unused in this case
#' @importFrom rlang quos
#' @rdname fit
#' @export
#' @export fit.model_sslr
fit.model_sslr <- function(object, formula = NULL, data = NULL, ...) {

   dots <- quos(...)


   if (all(c("x", "y") %in% names(dots)))
     rlang::abort("`fit.model_sslr()` is for the formula methods. Use 
`fit_xy()` instead.")


   fit_form_interface <- check_form_interface(formula, data)

   x_and_y <- get_x_y(formula, data)

   eval_env <- rlang::env()
   eval_env$x <- x_and_y$x
   eval_env$y <- x_and_y$y

   fit_interface <- check_xy_interface(eval_env$x, eval_env$y)

   elapsed <- system.time(model <- object$fit_function(eval_env$x, 
eval_env$y))


new_model_sslr_fitted(model,class(model),object$args,colnames(eval_env$x),elapsed,formula) 



}


Thanks

El 2020-03-10 16:19, lig...@statistik.tu-dortmund.de escribió:

Dear maintainer,

package SSLR_0.9.0.tar.gz does not pass the incoming checks
automatically, please see the following pre-tests:
Windows:
 


Status: 2 ERRORs, 1 WARNING, 1 NOTE
Debian:
 


Status: 1 ERROR, 1 WARNING, 1 NOTE



Please fix all problems and resubmit a fixed version via the webform.
If you are not sure how to fix the problems shown, please ask for help
on the R-package-devel mailing list:

If you are fairly certain the rejection is a false positive, please
reply-all to this message and explain.

More details are given in the directory:
 


The files will be removed after roughly 7 days.

No strong reverse dependencies to be checked.

Best regards,
CRAN teams' auto-check service

Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-ix86+x86_64
Check: CRAN incoming feasibility, Result: NOTE
  Maintainer: 'Francisco JesÃºs Palomares Alabarce 
'


  New submission

  Possibly mis-spelled words in DESCRIPTION:
    SSLR (23:14)
    VM (27:37)

  Found the following (possibly) invalid URLs:
    URL: https://cran.r-project.org/web/packages/RSSL/RSSL.pdf
  From: inst/doc/introduction.html
    inst/doc/models.html
  Status: 200
  Message: OK
  CRAN URL not in canonical form
    The canonical URL of the CRAN page for a package is
  https://CRAN.R-project.org/package=pkgname

  Found the following (possibly) invalid file URI:
    URI: www.cs.ucr.edu/~eamonn/time_series_data/
  From: man/coffee.Rd

  The Description field should not start with the package name,
    'This package' or similar.

Flavor: r-devel-windows-ix86+x86_64
Check: running examples for arch 'i386', Result: ERROR
  Running examples in 'SSLR-Ex.R' failed
  The error most likely occurred in:

  > base::assign(".ptime", proc.time(), pos = "CheckExEnv")
  > ### Name: COREG
  > ### Title: General Interface for COREG model
  > ### Aliases: COREG
  >
  > ### ** Examples
  >
  > library(tidyverse)
  -- Attaching packages ---
tidyverse 1.3.0 --
  v ggplot2 3.3.0 v purrr   0.3.3
  v tibble  2.1.3 v dplyr   0.8.5
  v tidyr   1.0.2 v stringr 1.4.0
  v readr   1.3.1 v forcats 0.5.0
  -- Conflicts --
tidyverse_conflicts() --
  x dplyr::filter() masks stats::filter()
  x dplyr::lag()    masks stats::lag()
  > library(tidymodels)
  -- Attaching packages --
tidymodels 0.1.0 --
  v broom 0.5.5 v rsample   0.0.5
  v dials 0.0.4 v tune  0.0.1
  v infer 0.5.1 v workflows 0.1.0
  v parsnip   0.0.5 v yardstick 0.0.5
  v recipes   0.1.9
  -- Conflicts -
tidymodels_conflicts() --
  x scales::discard()   masks purrr::discard()
  x dplyr::filter() masks stats::filter()
  x recipes::fixed()    masks stringr::fixed()
  x dplyr::lag()    masks stats::lag()
  x dials::margin() masks ggplot2::margin()
  x yardstick::spec()   masks readr::spec()
  x recipes::step() masks stats::step()
  x recipes::yj_trans() masks scales::yj_trans()
  > library(SSLR)
  >
  > data <- na.omit(airquality)
  > #data <- na.omit(airquality)
  >
  > cls <-

Re: [R-pkg-devel] package daewr does not pass incoming checks automatically

2020-03-10 Thread Uwe Ligges

We do not accept submissions that strongnly depend on orphaned packages 
as these are subject to be archived from CRAN.


Best,
Uwe Ligges


On 10.03.2020 17:48, John Lawson wrote:

The package daewr contains the data sets and functions shown in the book
"Design and Analysis of Experiments with R" published by CRC press. It has
been on CRAN since the book was first published in 2015.  Recently I
included a new function, but have not been able to include the modified
package on CRAN.

I get the message from Debian:

* DONE
Status: 1 WARNING, 1 NOTE

Current CRAN status: WARN: 1, OK: 12
See: 

Version: 1.1-8
Check: package dependencies, Result: WARNING
   Requires orphaned package: ‘BsMD’
See: 



I do not get this warning from the Windows:

Although the package BsMD is orphaned, it is still available on CRAN and
all examples in the book that use functions in daewr that call functions
from BsMD work as they always have. The new function I have added does not
require BsMD. Is there any way I can upload my modified package to CRAN so
that the new function is available?  Any help would be greatly appreciated.

John Lawson

[[alternative HTML version deleted]]

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel



__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel

Re: [R-pkg-devel] package daewr does not pass incoming checks automatically

2020-03-10 Thread Duncan Murdoch


On 10/03/2020 9:48 a.m., John Lawson wrote:

The package daewr contains the data sets and functions shown in the book
"Design and Analysis of Experiments with R" published by CRC press. It has
been on CRAN since the book was first published in 2015.  Recently I
included a new function, but have not been able to include the modified
package on CRAN.

I get the message from Debian:

* DONE
Status: 1 WARNING, 1 NOTE

Current CRAN status: WARN: 1, OK: 12
See: 

Version: 1.1-8
Check: package dependencies, Result: WARNING
   Requires orphaned package: ‘BsMD’
See: 



I do not get this warning from the Windows:

Although the package BsMD is orphaned, it is still available on CRAN and
all examples in the book that use functions in daewr that call functions
from BsMD work as they always have. The new function I have added does not
require BsMD. Is there any way I can upload my modified package to CRAN so
that the new function is available?  Any help would be greatly appreciated.



I suspect the logic is this:

Even though BsMD checks OK now, eventually some change in R or the check 
process will likely require changes to it.  However, since it is 
orphaned, there is nobody to ask to make those changes, so other 
packages should be discouraged from depending on it until a new 
maintainer steps forward.


So you have three choices:

1.  Volunteer to maintain BsMD, and take on the responsibility of 
modifying it in the future.


2.  Stop depending on it now, so that when it eventually breaks, your 
package won't be affected.


Either one of those choices requires some extra work from you, but it's 
not an emergency, as it would be if BsMD was suddenly unavailable.


Your third choice is less work, but less satisfying:

3.  Don't include the new function until someone else steps forward to 
maintain BsMD, or you are forced to make changes for some other reason.


Duncan Murdoch

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel

[R-pkg-devel] package daewr does not pass incoming checks automatically

2020-03-10 Thread John Lawson

The package daewr contains the data sets and functions shown in the book
"Design and Analysis of Experiments with R" published by CRC press. It has
been on CRAN since the book was first published in 2015.  Recently I
included a new function, but have not been able to include the modified
package on CRAN.

I get the message from Debian:

* DONE
Status: 1 WARNING, 1 NOTE

Current CRAN status: WARN: 1, OK: 12
See: 

Version: 1.1-8
Check: package dependencies, Result: WARNING
  Requires orphaned package: ‘BsMD’
See: 



I do not get this warning from the Windows:

Although the package BsMD is orphaned, it is still available on CRAN and
all examples in the book that use functions in daewr that call functions
from BsMD work as they always have. The new function I have added does not
require BsMD. Is there any way I can upload my modified package to CRAN so
that the new function is available?  Any help would be greatly appreciated.

John Lawson

[[alternative HTML version deleted]]

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel

[R-pkg-devel] Fwd: Re: [CRAN-pretest-archived] CRAN submission SSLR 0.9.0

2020-03-10 Thread fpalomares


Hi, I thiks its weird:

The error is:  no applicable method for 'fit' applied to an object of 
class "model_sslr"


In the code:

#' fit
#'
#' @title fit object
#' @param object object
#' @param ... other parameters to be passed
#' @rdname fit
#' @export fit
fit <- function(object, ...){
  UseMethod("fit")
}


And:

#' @title Fit with formula and data
#' @description Funtion to fit through the formula
#' @param object is the model
#' @param formula is the formula
#' @param data is the total data train
#' @param ... unused in this case
#' @importFrom rlang quos
#' @rdname fit
#' @export
#' @export fit.model_sslr
fit.model_sslr <- function(object, formula = NULL, data = NULL, ...) {

  dots <- quos(...)


  if (all(c("x", "y") %in% names(dots)))
rlang::abort("`fit.model_sslr()` is for the formula methods. Use 
`fit_xy()` instead.")


  fit_form_interface <- check_form_interface(formula, data)

  x_and_y <- get_x_y(formula, data)

  eval_env <- rlang::env()
  eval_env$x <- x_and_y$x
  eval_env$y <- x_and_y$y

  fit_interface <- check_xy_interface(eval_env$x, eval_env$y)

  elapsed <- system.time(model <- object$fit_function(eval_env$x, 
eval_env$y))


  
new_model_sslr_fitted(model,class(model),object$args,colnames(eval_env$x),elapsed,formula)


}


Thanks

El 2020-03-10 16:19, lig...@statistik.tu-dortmund.de escribió:

Dear maintainer,

package SSLR_0.9.0.tar.gz does not pass the incoming checks
automatically, please see the following pre-tests:
Windows:

Status: 2 ERRORs, 1 WARNING, 1 NOTE
Debian:

Status: 1 ERROR, 1 WARNING, 1 NOTE



Please fix all problems and resubmit a fixed version via the webform.
If you are not sure how to fix the problems shown, please ask for help
on the R-package-devel mailing list:

If you are fairly certain the rejection is a false positive, please
reply-all to this message and explain.

More details are given in the directory:

The files will be removed after roughly 7 days.

No strong reverse dependencies to be checked.

Best regards,
CRAN teams' auto-check service

Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-ix86+x86_64
Check: CRAN incoming feasibility, Result: NOTE
  Maintainer: 'Francisco JesÃºs Palomares Alabarce 
'


  New submission

  Possibly mis-spelled words in DESCRIPTION:
SSLR (23:14)
VM (27:37)

  Found the following (possibly) invalid URLs:
URL: https://cran.r-project.org/web/packages/RSSL/RSSL.pdf
  From: inst/doc/introduction.html
inst/doc/models.html
  Status: 200
  Message: OK
  CRAN URL not in canonical form
The canonical URL of the CRAN page for a package is
  https://CRAN.R-project.org/package=pkgname

  Found the following (possibly) invalid file URI:
URI: www.cs.ucr.edu/~eamonn/time_series_data/
  From: man/coffee.Rd

  The Description field should not start with the package name,
'This package' or similar.

Flavor: r-devel-windows-ix86+x86_64
Check: running examples for arch 'i386', Result: ERROR
  Running examples in 'SSLR-Ex.R' failed
  The error most likely occurred in:

  > base::assign(".ptime", proc.time(), pos = "CheckExEnv")
  > ### Name: COREG
  > ### Title: General Interface for COREG model
  > ### Aliases: COREG
  >
  > ### ** Examples
  >
  > library(tidyverse)
  -- Attaching packages ---
tidyverse 1.3.0 --
  v ggplot2 3.3.0 v purrr   0.3.3
  v tibble  2.1.3 v dplyr   0.8.5
  v tidyr   1.0.2 v stringr 1.4.0
  v readr   1.3.1 v forcats 0.5.0
  -- Conflicts --
tidyverse_conflicts() --
  x dplyr::filter() masks stats::filter()
  x dplyr::lag()masks stats::lag()
  > library(tidymodels)
  -- Attaching packages --
tidymodels 0.1.0 --
  v broom 0.5.5 v rsample   0.0.5
  v dials 0.0.4 v tune  0.0.1
  v infer 0.5.1 v workflows 0.1.0
  v parsnip   0.0.5 v yardstick 0.0.5
  v recipes   0.1.9
  -- Conflicts -
tidymodels_conflicts() --
  x scales::discard()   masks purrr::discard()
  x dplyr::filter() masks stats::filter()
  x recipes::fixed()masks stringr::fixed()
  x dplyr::lag()masks stats::lag()
  x dials::margin() masks ggplot2::margin()
  x yardstick::spec()   masks readr::spec()
  x recipes::step() masks stats::step()
  x recipes::yj_trans() masks scales::yj_trans()
  > library(SSLR)
  >
  > data <- na.omit(airquality)
  > #data <- na.omit(airquality)
  >
  > cls <- which(colnames(data) == "Ozone")
  >
  > colnames(data)[cls]<- "class"
  >
  > set.seed(1)
  > train.index  <- sample(nrow(data), round(0.7 * nrow(data)))

Re: [R-pkg-devel] Package in 'sugests' archived

2020-03-10 Thread Uwe Ligges

Please simply submit a new version ideally without sugesting the 
archived one as you apparently do not need it for your paclkage's 
functionality at all.


Best,
Uwe Ligges

On 09.03.2020 10:43, Fabio Corradini Santander wrote:

Hi,
I recently submitted my frist package to CRAN (
https://CRAN.R-project.org/package=uFTIR). It was accepted last friday. I
was super happy about it. However, today I check the results and there are
several error flags in the package status. What happened?

I included a package called prospectr within the suggested packages. I only
use it to run two examples. The idea was to show potential users that they
can pass functions from other packages in one of the processing steps.

I did not notice that the package was old. It was updated in 2014 for the
last time. Funny enough, the prospectr package was archived on saturday.
Yes, one day after my package was accepted. (
https://CRAN.R-project.org/package=prospectr)

Now I have to deal with the errors. As I mentioned, fixing the problems
should be easy as I only included the package in two examples. My question
is, then, what should I do? Should I fix the problem and submit a new
'version' to CRAN right away or should I wait? I read in the repository
policy that one should wait between versions at least '1–2 months'.



__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel

Re: [R-pkg-devel] Fwd: Re: [CRAN-pretest-archived] CRAN submission SSLR 0.9.0

Re: [R-pkg-devel] package daewr does not pass incoming checks automatically

Re: [R-pkg-devel] package daewr does not pass incoming checks automatically

[R-pkg-devel] package daewr does not pass incoming checks automatically

[R-pkg-devel] Fwd: Re: [CRAN-pretest-archived] CRAN submission SSLR 0.9.0

Re: [R-pkg-devel] Package in 'sugests' archived

6 matches

Site Navigation

Mail list logo

Footer information