Re: [R-pkg-devel] CRAN submission struggle

2024-01-07 Thread Ivan Krylov
On Sun, 7 Jan 2024 10:52:44 +0200
Christiaan Pieterse  wrote:

> I have edited my package to have two examples. One uses a small
> self-generated dataset and another uses a big dataset. For the big
> dataset example, I put \donttest{} around it, should this be fine?

The small example is definitely fine: it exercises the code and does so
fast.

The big example wrapped in \donttest{} could be fine, I'm not sure.
I've seen CRAN packages that wrap the long parts of their examples in
\donttest{} while still making sure that R CMD check --run-donttest
exercises most of their code.

-- 
Best regards,
Ivan

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel


Re: [R-pkg-devel] CRAN submission struggle

2024-01-07 Thread Christiaan Pieterse
Good day

I have edited my package to have two examples. One uses a small
self-generated dataset and another uses a big dataset. For the big dataset
example, I put \donttest{} around it, should this be fine?

I only get one note for the new package, available at
https://github.com/WoutersResearchGroup/R-IO-PS/tree/CRAN-prep.

Kind regards
Christiaan

On Sat, 6 Jan 2024 at 14:59, Ivan Krylov  wrote:

> On Sat, 6 Jan 2024 15:16:01 +0300
> Ivan Krylov  wrote:
>
> > Congratulations! I also get the single expected NOTE in my checks.
>
> Apologies for the double e-mail, but I've read the code now, and
> wrapping the example of your only function in \dontrun{} will most
> likely not be allowed.
>
> Is it really the case that you cannot remove a single row from the
> example dataset without making the example crash? It may help to write
> a function that would remove rows one by one, make sure that the
> example still runs, and keep doing that until not a single row can be
> removed. The complexity is terrible (something like O(n^k)), but let it
> run for a while, and maybe it'll reduce the dataset enough to fit in
> the example time limit.
>
> --
> Best regards,
> Ivan
>

[[alternative HTML version deleted]]

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel