Re: [R-pkg-devel] [External] Re: clang issue
В Mon, 7 Aug 2023 15:52:38 + "Grose, Daniel" пишет: > https://github.com/grosed/anomaly Ah, so this is why I couldn't find your package on CRAN. Now I can see the compiler log, together with the compiler command line: https://www.stats.ox.ac.uk/pub/bdr/clang17/anomaly.log It looks like -DR_NO_REMAP is missing from src/Makevars, both in the last archived version on CRAN and in the version-4.3.0 branch, but if you add it to the line with PKG_CPPFLAGS, it should work. If it's too much to fix, at least make sure to move any R-related #includes below the system #includes. MeanAnomalyMV.cpp originally blew up because (1) -DR_NO_REMAP was missing from the compiler command line, (2) Rinternals.h was included, which provides #define length(x), and (3) a standard C++ header was included, which tried to define a function named length. Moving the R headers below the standard C++ headers would have prevented it. It may also help to change the interface of MeanAnomalyMV so that it either (1) uses Rcpp, enjoying built-in R_NO_REMAP or (2) works purely in terms of R and C types, avoiding the need to #include and . Hope you'll succeed in getting the package back in shape! -- Best regards, Ivan __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
Re: [R-pkg-devel] [External] Re: clang issue
Hi Dirk My apologies. I thought you were asking for compiler output. You can find the code at https://github.com/grosed/anomaly [https://opengraph.githubassets.com/866d37f560339c5ee145d5cd7e40edf768223cf08b8e9f35ae97e14d1f2b47f5/grosed/anomaly]<https://github.com/grosed/anomaly> GitHub - grosed/anomaly<https://github.com/grosed/anomaly> Contribute to grosed/anomaly development by creating an account on GitHub. github.com in the version-4.3.0 branch. Many thanks, Dan From: Dirk Eddelbuettel Sent: 07 August 2023 16:19 To: Grose, Daniel Cc: Dirk Eddelbuettel ; Ivan Krylov ; r-package-devel@r-project.org Subject: Re: [R-pkg-devel] [External] Re: clang issue On 7 August 2023 at 13:55, Grose, Daniel wrote: | As I say - I cannot reproduce the error myself. I will try asking Uwe Ligges | for more information. Methinks you are doing it wrong. We created the r-package-devel list years ago to take load away from the overworked CRAN maintainers who are "on the critical path" and a bottleneck we would rather see lightened. Also, you were asked twice to share your repo or package. As you won't I stop here as you seemingly do not want us to help you. Your call. Dirk -- dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org [[alternative HTML version deleted]] __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
Re: [R-pkg-devel] [External] Re: clang issue
On 7 August 2023 at 13:55, Grose, Daniel wrote: | As I say - I cannot reproduce the error myself. I will try asking Uwe Ligges | for more information. Methinks you are doing it wrong. We created the r-package-devel list years ago to take load away from the overworked CRAN maintainers who are "on the critical path" and a bottleneck we would rather see lightened. Also, you were asked twice to share your repo or package. As you won't I stop here as you seemingly do not want us to help you. Your call. Dirk -- dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
Re: [R-pkg-devel] [External] Re: clang issue
Hi Ivan/Dirk As I say - I cannot reproduce the error myself. I will try asking Uwe Ligges for more information. Best wishes, Dan From: Dirk Eddelbuettel Sent: 07 August 2023 14:53 To: Grose, Daniel Cc: Ivan Krylov ; Dirk Eddelbuettel ; r-package-devel@r-project.org Subject: Re: [R-pkg-devel] [External] Re: clang issue On 7 August 2023 at 13:38, Grose, Daniel wrote: | No - unfortunately not. I cannot reproduce the error locally so I posted the | snippet that Uwe Ligges sent me regarding the failed CRAN submission. That is | all of the information I have. | | For now I will follow Dirk's advice and see if the CRAN submission gets | accepted. Yes as Ivan state using PKG_CFLAGS etc should be equivalent but there can be pitfalls if you eg set PKG_CFLAGS but also have a C++ (or Fortran) file. So as Ivan already asked: what is you repo? We can help better (and faster) with reproducible code. Best, Dirk -- dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org [[alternative HTML version deleted]] __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
Re: [R-pkg-devel] [External] Re: clang issue
On 7 August 2023 at 13:38, Grose, Daniel wrote: | No - unfortunately not. I cannot reproduce the error locally so I posted the | snippet that Uwe Ligges sent me regarding the failed CRAN submission. That is | all of the information I have. | | For now I will follow Dirk's advice and see if the CRAN submission gets | accepted. Yes as Ivan state using PKG_CFLAGS etc should be equivalent but there can be pitfalls if you eg set PKG_CFLAGS but also have a C++ (or Fortran) file. So as Ivan already asked: what is you repo? We can help better (and faster) with reproducible code. Best, Dirk -- dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
Re: [R-pkg-devel] [External] Re: clang issue
Hi Ivan No - unfortunately not. I cannot reproduce the error locally so I posted the snippet that Uwe Ligges sent me regarding the failed CRAN submission. That is all of the information I have. For now I will follow Dirk's advice and see if the CRAN submission gets accepted. Thanks for your help. Best wishes, Dan From: Ivan Krylov Sent: 07 August 2023 14:32 To: Grose, Daniel Cc: Dirk Eddelbuettel ; r-package-devel@r-project.org Subject: Re: [R-pkg-devel] [External] Re: clang issue � Mon, 7 Aug 2023 13:16:33 + "Grose, Daniel" �: > I thought -DR_NO_REMAP in Makevars would set R_NO_REMAP across all > compilation units. Is this not the case ? It should have worked. Can we see the code? Is there a visible compiler command line in the check results that you quoted in the first message? -- Best regards, Ivan [[alternative HTML version deleted]] __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
Re: [R-pkg-devel] [External] Re: clang issue
В Mon, 7 Aug 2023 13:16:33 + "Grose, Daniel" пишет: > I thought -DR_NO_REMAP in Makevars would set R_NO_REMAP across all > compilation units. Is this not the case ? It should have worked. Can we see the code? Is there a visible compiler command line in the check results that you quoted in the first message? -- Best regards, Ivan __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
Re: [R-pkg-devel] [External] Re: clang issue
Hi Dirk Thanks for the quick response. I thought -DR_NO_REMAP in Makevars would set R_NO_REMAP across all compilation units. Is this not the case ? Thanks, Dan From: Dirk Eddelbuettel Sent: 07 August 2023 14:13 To: Grose, Daniel Cc: r-package-devel@r-project.org Subject: [External] Re: [R-pkg-devel] clang issue This email originated outside the University. Check before clicking links or attachments. Daniel, This is not new, and not related to clang. On 7 August 2023 at 12:58, Grose, Daniel wrote: | Any ideas ? Add a line #define R_NO_REMAP 1 before _any_ inclusion of R headers. See Section 6 of Writing R Extensions. If you use eg Rcpp it is done for you when you include Rcpp headers. Cheers, Dirk -- dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org [[alternative HTML version deleted]] __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel
