Re: [R-pkg-devel] Cannot repro failing CRAN autochecks

2024-05-08 Thread Josiah Parry 
Thanks to @yutannihilation for pointing out that the issue repros on
r-universe
https://github.com/r-universe/r-arcgis/actions/runs/8990426306/job/24695887245
.

Do folks know if there are any templates for the linux CRAN check? It
appears that the r-lib/actions linux checks don't cover all of the same
bases. I tried cribbing the r-universe one but it is a bit like unwinding a
cat's cradle.

Waiting an hour for each r-universe check is not really an effective
strategy! 🙈

On Tue, May 7, 2024 at 2:58 PM Ivan Krylov  wrote:

> Ð’ Tue, 7 May 2024 21:40:31 +0300
> Ivan Krylov via R-package-devel  пишет:
>
> > It's too late for Makevars to exclude files from the source package
> > tarball. Use .Rbuildignore instead:
>
> Sorry, that was mostly misguided. .Rbuildignore won't help with the
> contents of the Rust vendor tarball.
>
> 1. Can you omit the .cff file from src/rust/vendor.tar.xz when building
> it?
>
> 2. I think that there is --exclude in both GNU tar and BSD tar. How
> about tar --exclude="*.cff" -x -f rust/vendor.tar.xz ?
>
> 3. From
> <
> https://win-builder.r-project.org/incoming_pretest/arcgisutils_0.3.0_20240507_194020/Debian/00install.out
> >,
> it can be seen that the "clean" target does not get called. Can you
> remove the *.cff file in the same Make target?
>
> --
> Best regards,
> Ivan
>

[[alternative HTML version deleted]]

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel

Re: [R-pkg-devel] Cannot repro failing CRAN autochecks

2024-05-07 Thread Josiah Parry 
Thanks, Ivan!

As you can see, the directory is ignored already
https://github.com/R-ArcGIS/arcgisutils/blob/ff8a0a1b936e27be16ac866aa16605b973d435c7/.Rbuildignore#L14

The directory is created in the Makevars after the zip is untarred:

https://github.com/R-ArcGIS/arcgisutils/blob/ff8a0a1b936e27be16ac866aa16605b973d435c7/src/Makevars#L17

Then the directory is removed during the clean phase I believe as well.

I have other packages that use a similar makevars that are in CRAN.

Since I can’t repro it I’m not sure how to debug it without submitting to
CRAN again.



On Tue, May 7, 2024 at 14:40 Ivan Krylov  wrote:

> Ð’ Tue, 7 May 2024 14:03:42 -0400
> Josiah Parry  пишет:
>
> > This NOTE does not appear in Ubuntu, Mac, or Windows checks
> >
> https://github.com/R-ArcGIS/arcgisutils
> /actions/runs/8989812276/job/24693685840
> 
>
> That's a bit strange. It fires for me in a local R CMD check for a test
> package even without --as-cran. The code performing the check has been
> in R since ~2010.
>
> > I've made an edit to the Makevars to specifically remove this
> > directory, but it seems to continue to persist.
>
> It's too late for Makevars to exclude files from the source package
> tarball. Use .Rbuildignore instead:
> https://cran.r-project.org/doc/manuals/R-exts.html#Building-binary-packages
>
> I think that the line src/vendor/chrono/CITATION\\.cff will prevent the
> file from appearing in the package tarball.
>
> --
> Best regards,
> Ivan
>

[[alternative HTML version deleted]]

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel

Re: [R-pkg-devel] Cannot repro failing CRAN autochecks

2024-05-07 Thread Ivan Krylov via R-package-devel 
Ð’ Tue, 7 May 2024 21:40:31 +0300
Ivan Krylov via R-package-devel  пишет:

> It's too late for Makevars to exclude files from the source package
> tarball. Use .Rbuildignore instead:

Sorry, that was mostly misguided. .Rbuildignore won't help with the
contents of the Rust vendor tarball.

1. Can you omit the .cff file from src/rust/vendor.tar.xz when building
it?

2. I think that there is --exclude in both GNU tar and BSD tar. How
about tar --exclude="*.cff" -x -f rust/vendor.tar.xz ?

3. From
,
it can be seen that the "clean" target does not get called. Can you
remove the *.cff file in the same Make target?

-- 
Best regards,
Ivan

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel

Re: [R-pkg-devel] Cannot repro failing CRAN autochecks

2024-05-07 Thread Ivan Krylov via R-package-devel 
Ð’ Tue, 7 May 2024 14:03:42 -0400
Josiah Parry  пишет:

> This NOTE does not appear in Ubuntu, Mac, or Windows checks
> https://github.com/R-ArcGIS/arcgisutils/actions/runs/8989812276/job/24693685840

That's a bit strange. It fires for me in a local R CMD check for a test
package even without --as-cran. The code performing the check has been
in R since ~2010.

> I've made an edit to the Makevars to specifically remove this
> directory, but it seems to continue to persist.

It's too late for Makevars to exclude files from the source package
tarball. Use .Rbuildignore instead:
https://cran.r-project.org/doc/manuals/R-exts.html#Building-binary-packages

I think that the line src/vendor/chrono/CITATION\\.cff will prevent the
file from appearing in the package tarball.

-- 
Best regards,
Ivan

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel

[R-pkg-devel] Cannot repro failing CRAN autochecks

2024-05-07 Thread Josiah Parry 
I've submitted an R package to CRAN and am failing checks *only on Debian*

https://win-builder.r-project.org/incoming_pretest/arcgisutils_0.3.0_20240507_194020/Debian/00check.log


This NOTE does not appear in Ubuntu, Mac, or Windows checks
https://github.com/R-ArcGIS/arcgisutils/actions/runs/8989812276/job/24693685840

I've made an edit to the Makevars to specifically remove this directory,
but it seems to continue to persist.

https://github.com/R-ArcGIS/arcgisutils/blob/ff8a0a1b936e27be16ac866aa16605b973d435c7/src/Makevars#L31-L35

Does anyone know how I can repro this NOTE or have an idea about what is
happening?

I'm a bit at a loss and do not want to use CRAN as if it is a CI
system--its challenging enough as is.

Thanks!

Josiah

[[alternative HTML version deleted]]

__
R-package-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-package-devel