[R-SIG-Finance] quantmod bug ?
Hi all, I recently posted a problem concerning shaded regions with quantmod package. More precisely, I used the function addTA with a boolean vector: for example addTA(vecB,col=green,border=NA,on=-1) where vecB is the boolean vector. In some cases, the shading result was not conform with the boolean vector. I checked the R source program, and more precisely the function chartTA() in TA.R file. So in the function chartTA, it seems that there is a mistake with the vector x.pos. the vector is given by x.pos - 1 + spacing * (1:length(x.range)) and it seems that this vector should be x.pos - 1:(spacing*x.range[2]) So I hope this indication would be relevant for people who work on the improvements of this package. Best regards. O. ___ R-SIG-Finance@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-sig-finance -- Subscriber-posting only. If you want to post, subscribe first. -- Also note that this is not the r-help list where general R questions should go.
Re: [R-SIG-Finance] quantmod bug ?
Also, shouldn't patches be encouraged? On Wed, Aug 8, 2012 at 10:16 AM, G See gsee...@gmail.com wrote: chartSeries is on CRAN and ?chart_Series says it's highly experimental. IMHO it's really not fair to tell people that they should use undocumented code. Garrett ___ R-SIG-Finance@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-sig-finance -- Subscriber-posting only. If you want to post, subscribe first. -- Also note that this is not the r-help list where general R questions should go.
Re: [R-SIG-Finance] quantmod bug ?
Hi O, I'll check and patch. CRAN is in desperate need of a quantmod update - and one is coming. For now though, the change to watch for will be on R-forge. Thanks!, Jeff On Wed, Aug 8, 2012 at 10:05 AM, Olivier MARTIN olivier.mar...@avignon.inra.fr wrote: Hi all, I recently posted a problem concerning shaded regions with quantmod package. More precisely, I used the function addTA with a boolean vector: for example addTA(vecB,col=green,border=NA,on=-1) where vecB is the boolean vector. In some cases, the shading result was not conform with the boolean vector. I checked the R source program, and more precisely the function chartTA() in TA.R file. So in the function chartTA, it seems that there is a mistake with the vector x.pos. the vector is given by x.pos - 1 + spacing * (1:length(x.range)) and it seems that this vector should be x.pos - 1:(spacing*x.range[2]) So I hope this indication would be relevant for people who work on the improvements of this package. Best regards. O. ___ R-SIG-Finance@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-sig-finance -- Subscriber-posting only. If you want to post, subscribe first. -- Also note that this is not the r-help list where general R questions should go. -- Jeffrey Ryan jeffrey.r...@lemnica.com www.lemnica.com ___ R-SIG-Finance@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-sig-finance -- Subscriber-posting only. If you want to post, subscribe first. -- Also note that this is not the r-help list where general R questions should go.