Re: v3 experimental data=ordered and logging speedups for 2.6.1
On Wed, 2004-02-11 at 10:09, Oleg Drokin wrote: Hello! On Wed, Feb 11, 2004 at 09:59:31AM -0500, Chris Mason wrote: thousands (hundreds of thousands) of times per day. It wasn't an easy bug to hit. What are the symptoms? The rpm database is corrupted, rpm --rebuild-db is required. Hm, that's really strange. But on ia64 default io size is 64k, do they have same problems there? No, ia64 works fine. It really is strange. other tricky parts when the data=journal code is added. We've already made our own file_write call, it doesn't make sense to warp it just to avoid our own __block_commit_write ;-) Well, code duplication is not very good thing. It depends on how much you have to twist things to use the generic code. If we used __block_commit_write, buffers would be marked dirty when it completes. This won't work for data=journal at all, we don't want them marked dirty. Well, if you do not want them marked dirty, you just do not need to call commit_write at all since the only thing it does is marking buffers dirty ;) And you can have a list of buffers at the allocation time anyway, so no need to do extra checks about partial page writes and so on since all these checks were already done. Interesting. I'll look harder at that. -chris
Re: v3 experimental data=ordered and logging speedups for 2.6.1
Hello! On Mon, Jan 19, 2004 at 11:45:26AM -0500, Chris Mason wrote: I've got most of data=ordered finished, there are a few paths like writepage and O_DIRECT that need tweaking. Thanks to Oleg's file_write work in 2.6.x, the data=journal patch is much cleaner than 2.4, it is almost done but not included in the bunch of patches I just uploaded to ftp.suse.com. Oleg is cc'd in case he wants to look over the changes to reiserfs_file_write in reiserfs-jh-2. Cool. I'd certainly take a look at it. But may be in February, as I am in US right now and I have not got any stable internet connection yet. Thank you. Bye, Oleg
Re: v3 experimental data=ordered and logging speedups for 2.6.1
On Mon, 2004-01-19 at 17:53, Dieter Nützel wrote: 05 and 06 needed some handwork 'cause the SuSE kernel inclues xattrs and posix acl's but nothing special. Good to hear. I wasn't expecting the suse merge to be difficult, luckily it doesn't have many patches in it yet. Jeff and I will look at getting them into the suse kernel once data=journal is done as well. An EXPORT was missing in linux/fs/buffer.c to compile ReiserFS 3.x.x as modul (inode.c, unresolved symbol): Thanks, I'll add it into the patch when I get back from linux world. -chris
